From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17373C433E0 for ; Fri, 22 Jan 2021 13:21:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCF5A23428 for ; Fri, 22 Jan 2021 13:21:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCF5A23428 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U1WCFLRhh6Zwcsj0AEtrsfWTa2yg7qJGAHGD96pfzZQ=; b=egHfiv+bKcxG8E+l7vNJde3Ma 8RvsjMzDEBqNKwHbW9WgbDax+ucvMprsnxdbujX6ZuwnzHYr8XARaUt/4hEoiacv4JWy0CfCeSnrB waRfT2uHK69FliM2KO+FKWJLfUzpA0UX1GK+XziieRR7045ZPP+PIf5w+wEl7Gcje74myBR5qv3Ts RBJXwICsRB+Ggy63AhB2R3Eus2m9cBQWFdha/PD11CGWR7dX2M0vdq76B27j4xAhbrgQfPst2lD74 0GLjiJ1TQl0NuG33Q8PONHZVMdBH6NcdfJHbqEe1yXJd8D4UZ+/S6olKoh9K6zICtl32jnZLhRhSZ w50tFtdhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2wLq-0003Ia-1Z; Fri, 22 Jan 2021 13:19:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2wLj-0003HK-AA for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 13:19:43 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BC1AB23428; Fri, 22 Jan 2021 13:19:36 +0000 (UTC) Date: Fri, 22 Jan 2021 13:19:34 +0000 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v5 3/6] kasan: Add report for async mode Message-ID: <20210122131933.GD8567@gaia> References: <20210121163943.9889-1-vincenzo.frascino@arm.com> <20210121163943.9889-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163943.9889-4-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_081939_435911_6FC62E85 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Andrey Konovalov , Evgenii Stepanov , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Andrey Ryabinin , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 04:39:40PM +0000, Vincenzo Frascino wrote: > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index bb862d1f0e15..b0a1d9dfa85c 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -351,6 +351,8 @@ static inline void *kasan_reset_tag(const void *addr) > bool kasan_report(unsigned long addr, size_t size, > bool is_write, unsigned long ip); > > +void kasan_report_async(void); > + > #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ > > static inline void *kasan_reset_tag(const void *addr) > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 234f35a84f19..2fd6845a95e9 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -358,6 +358,17 @@ void kasan_report_invalid_free(void *object, unsigned long ip) > end_report(&flags); > } > > +void kasan_report_async(void) > +{ > + unsigned long flags; > + > + start_report(&flags); > + pr_err("BUG: KASAN: invalid-access\n"); > + pr_err("Asynchronous mode enabled: no access details available\n"); > + dump_stack(); > + end_report(&flags); > +} I think the kernel test robot complains that with KASAN_SW_TAGS and HW_TAGS disabled, the kasan_report_async() prototype is no longer visible but you still have the non-static function definition here. So either move kasan_report_async() out of this #ifdef or add the #ifdef around the function definition. It looks like the original kasan_report() prototype is declared in two places (second one in mm/kasan/kasan.h). I'd remove the latter and try to have a consistent approach for kasan_report() and kasan_report_async(). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel