[PATCH] pinctrl: actions: Add the platform dependency to drivers

[PATCH] pinctrl: actions: Add the platform dependency to drivers

[Manivannan Sadhasivam]

The Actions Semi pinctrl drivers are a mix of both ARM32 and ARM64
platforms. So let's add the correct platform dependency to avoid them
being selected on the other.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/pinctrl/actions/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pinctrl/actions/Kconfig b/drivers/pinctrl/actions/Kconfig
index a1d16e8280e5..8bb8345b17da 100644
--- a/drivers/pinctrl/actions/Kconfig
+++ b/drivers/pinctrl/actions/Kconfig
@@ -12,18 +12,21 @@ config PINCTRL_OWL
 
 config PINCTRL_S500
 	bool "Actions Semi S500 pinctrl driver"
+	depends on ARM
 	depends on PINCTRL_OWL
 	help
 	  Say Y here to enable Actions Semi S500 pinctrl driver
 
 config PINCTRL_S700
 	bool "Actions Semi S700 pinctrl driver"
+	depends on ARM64
 	depends on PINCTRL_OWL
 	help
 	  Say Y here to enable Actions Semi S700 pinctrl driver
 
 config PINCTRL_S900
 	bool "Actions Semi S900 pinctrl driver"
+	depends on ARM64
 	depends on PINCTRL_OWL
 	help
 	  Say Y here to enable Actions Semi S900 pinctrl driver
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pinctrl: actions: Add the platform dependency to drivers

[Linus Walleij]

On Thu, Jan 21, 2021 at 7:26 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:

> The Actions Semi pinctrl drivers are a mix of both ARM32 and ARM64
> platforms. So let's add the correct platform dependency to avoid them
> being selected on the other.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Are you not opting out of build tests when you do this?

What about:

depends on ARM64 || COMPILE_TEST
(etc)
?

Yours,
Linus Walleij

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pinctrl: actions: Add the platform dependency to drivers

[Manivannan Sadhasivam]

On Fri, Jan 22, 2021 at 02:19:07PM +0100, Linus Walleij wrote:
> On Thu, Jan 21, 2021 at 7:26 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> 
> > The Actions Semi pinctrl drivers are a mix of both ARM32 and ARM64
> > platforms. So let's add the correct platform dependency to avoid them
> > being selected on the other.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> Are you not opting out of build tests when you do this?
> 
> What about:
> 
> depends on ARM64 || COMPILE_TEST
> (etc)
> ?
> 

Oh yeah, I missed it. Will send v2.

Thanks,
Mani

> Yours,
> Linus Walleij
> 
> Yours,
> Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel