[PATCH 0/2] mmc: J7200: Add support for higher speed modes in MMCSD subsystems

[PATCH 0/2] mmc: J7200: Add support for higher speed modes in MMCSD subsystems

[Aswath Govindraju]

The following series of patches
- adds support for HS200 and HS400 speed modes in MMCSD0 subsystem
- adds support for UHS-I speed modes in MMCSD1 subsystem 

Aswath Govindraju (2):
  arm64: dts: ti: k3-j7200-main: Add support for HS200 and HS400 modes
    in MMCSD0 subsystem
  arm64: dts: ti: k3-j7200-main: Add support for UHS-I modes in MMCSD1
    subsystem

 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2] arm64: dts: ti: k3-j7200-main: Add support for HS200 and HS400 modes in MMCSD0 subsystem

[Aswath Govindraju]

HS200 and HS400 modes at 1.8 V card voltage, are now supported in MMCSD0
subsystem of J7200 SoC[1].

Set respective tags to indicate it.

[1] - https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 4cc2e9094d0e..03486395e492 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -517,6 +517,8 @@
 		ti,trm-icp = <0x8>;
 		bus-width = <8>;
 		mmc-ddr-1_8v;
+		mmc-hs200-1_8v;
+		mmc-hs400-1_8v;
 		dma-coherent;
 	};
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add support for UHS-I modes in MMCSD1 subsystem

[Aswath Govindraju]

Remove no-1-8-v tag in sdhci1 device tree node as UHS-I speed modes are now
supported in MMCSD1 subsystem of J7200 SoC[1].

[1] - https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 03486395e492..4b3d0b5739e8 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -536,7 +536,6 @@
 		ti,otap-del-sel-sdr50 = <0xc>;
 		ti,otap-del-sel-sdr104 = <0x5>;
 		ti,otap-del-sel-ddr50 = <0xc>;
-		no-1-8-v;
 		dma-coherent;
 	};
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] mmc: J7200: Add support for higher speed modes in MMCSD subsystems

[Nishanth Menon]

On 21:54-20210122, Aswath Govindraju wrote:
> The following series of patches
> - adds support for HS200 and HS400 speed modes in MMCSD0 subsystem
> - adds support for UHS-I speed modes in MMCSD1 subsystem 
> 
> Aswath Govindraju (2):
>   arm64: dts: ti: k3-j7200-main: Add support for HS200 and HS400 modes
>     in MMCSD0 subsystem
>   arm64: dts: ti: k3-j7200-main: Add support for UHS-I modes in MMCSD1
>     subsystem


Just a curious couple of questions:
Does squashing both the patches create a problem for understanding or a
later bisect? I kind of thought these mostly go hand in hand between the
instances, am I mistaken?

Are there any otap delay params update needed or the defaults are good
to go?

Will also help to provide some verification log along with this.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] mmc: J7200: Add support for higher speed modes in MMCSD subsystems

[Aswath Govindraju]

Hi Nishanth,

On 22/01/21 11:36 pm, Nishanth Menon wrote:
> On 21:54-20210122, Aswath Govindraju wrote:
>> The following series of patches
>> - adds support for HS200 and HS400 speed modes in MMCSD0 subsystem
>> - adds support for UHS-I speed modes in MMCSD1 subsystem 
>>
>> Aswath Govindraju (2):
>>   arm64: dts: ti: k3-j7200-main: Add support for HS200 and HS400 modes
>>     in MMCSD0 subsystem
>>   arm64: dts: ti: k3-j7200-main: Add support for UHS-I modes in MMCSD1
>>     subsystem
> 
> 
> Just a curious couple of questions:
> Does squashing both the patches create a problem for understanding or a
> later bisect? I kind of thought these mostly go hand in hand between the
> instances, am I mistaken?
> 

Yes, they can be squashed. I post a respin doing this.

> Are there any otap delay params update needed or the defaults are good
> to go?
> 

The otap values are already up-to-date with the data sheet and don't
need updation.

> Will also help to provide some verification log along with this.
> 

May I know what sort of logs would be best to provide. Would enumeration
logs during boot suffice ?

Like this,
https://pastebin.ubuntu.com/p/v9NRV7GwMw/ ?

Thanks,
Aswath

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] mmc: J7200: Add support for higher speed modes in MMCSD subsystems

[Nishanth Menon]

On 19:12-20210125, Aswath Govindraju wrote:
> Hi Nishanth,
> 
> On 22/01/21 11:36 pm, Nishanth Menon wrote:
> > On 21:54-20210122, Aswath Govindraju wrote:
> >> The following series of patches
> >> - adds support for HS200 and HS400 speed modes in MMCSD0 subsystem
> >> - adds support for UHS-I speed modes in MMCSD1 subsystem 
> >>
> >> Aswath Govindraju (2):
> >>   arm64: dts: ti: k3-j7200-main: Add support for HS200 and HS400 modes
> >>     in MMCSD0 subsystem
> >>   arm64: dts: ti: k3-j7200-main: Add support for UHS-I modes in MMCSD1
> >>     subsystem
> > 
> > 
> > Just a curious couple of questions:
> > Does squashing both the patches create a problem for understanding or a
> > later bisect? I kind of thought these mostly go hand in hand between the
> > instances, am I mistaken?
> > 
> 
> Yes, they can be squashed. I post a respin doing this.

Thanks.

> 
> > Are there any otap delay params update needed or the defaults are good
> > to go?
> > 
> 
> The otap values are already up-to-date with the data sheet and don't
> need updation.

Thanks for the clarification.

> 
> > Will also help to provide some verification log along with this.
> > 
> 
> May I know what sort of logs would be best to provide. Would enumeration
> logs during boot suffice ?
> 
> Like this,
> https://pastebin.ubuntu.com/p/v9NRV7GwMw/ ?

That just says we detected the cards, no?
I thought we had tests around this? Something including /sys/kernel/debug/mmc*/ios

Something that demonstrates that this actually runs at the claimed
speeds? That would be nice on linux-next, if possible as well..

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] mmc: J7200: Add support for higher speed modes in MMCSD subsystems

[Aswath Govindraju]

Hi Nishanth,

On 25/01/21 7:21 pm, Nishanth Menon wrote:
> On 19:12-20210125, Aswath Govindraju wrote:
>> Hi Nishanth,
>>
>> On 22/01/21 11:36 pm, Nishanth Menon wrote:
>>> On 21:54-20210122, Aswath Govindraju wrote:
>>>> The following series of patches
>>>> - adds support for HS200 and HS400 speed modes in MMCSD0 subsystem
>>>> - adds support for UHS-I speed modes in MMCSD1 subsystem 
>>>>
>>>> Aswath Govindraju (2):
>>>>   arm64: dts: ti: k3-j7200-main: Add support for HS200 and HS400 modes
>>>>     in MMCSD0 subsystem
>>>>   arm64: dts: ti: k3-j7200-main: Add support for UHS-I modes in MMCSD1
>>>>     subsystem
>>>
>>>
>>> Just a curious couple of questions:
>>> Does squashing both the patches create a problem for understanding or a
>>> later bisect? I kind of thought these mostly go hand in hand between the
>>> instances, am I mistaken?
>>>
>>
>> Yes, they can be squashed. I post a respin doing this.
> 
> Thanks.
> 
>>
>>> Are there any otap delay params update needed or the defaults are good
>>> to go?
>>>
>>
>> The otap values are already up-to-date with the data sheet and don't
>> need updation.
> 
> Thanks for the clarification.
> 
>>
>>> Will also help to provide some verification log along with this.
>>>
>>
>> May I know what sort of logs would be best to provide. Would enumeration
>> logs during boot suffice ?
>>
>> Like this,
>> https://pastebin.ubuntu.com/p/v9NRV7GwMw/ ?
> 
> That just says we detected the cards, no?
> I thought we had tests around this? Something including /sys/kernel/debug/mmc*/ios
> 
> Something that demonstrates that this actually runs at the claimed
> speeds? That would be nice on linux-next, if possible as well..
> 

Yes there are tests which confirm that claimed speeds are functional. I
will add them in the respin.

Thanks,
Aswath

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] mmc: J7200: Add support for higher speed modes in MMCSD subsystems

[Nishanth Menon]

On 19:43-20210125, Aswath Govindraju wrote:
> >>> Will also help to provide some verification log along with this.
> >>>
> >>
> >> May I know what sort of logs would be best to provide. Would enumeration
> >> logs during boot suffice ?
> >>
> >> Like this,
> >> https://pastebin.ubuntu.com/p/v9NRV7GwMw/ ?
> > 
> > That just says we detected the cards, no?
> > I thought we had tests around this? Something including /sys/kernel/debug/mmc*/ios
> > 
> > Something that demonstrates that this actually runs at the claimed
> > speeds? That would be nice on linux-next, if possible as well..
> > 
> 
> Yes there are tests which confirm that claimed speeds are functional. I
> will add them in the respin.

Awesome.  much appreciated.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel