From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB71C433E0 for ; Sun, 24 Jan 2021 11:43:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 053B322C9D for ; Sun, 24 Jan 2021 11:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 053B322C9D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X9DrihflkioCGjOsUoKxrwacSIYRlXN/ijhWT+6exRA=; b=v1nBHvXcBxzB+C4XtvqCGDyOH XhFpYg4NtWjqLDm4GOKdY99tlARmNMY5kIrOMZ1ZZBzRq4ul1AbHyEtItR1ojMod2LkXFeO+pt0og ujPfp6mKqEMmSQ4q9gxXptZDd8Vp/9z1nh0iH9eUy6bprBDf5QUE4fUvIWY1g4m6pfuYWkLgSrTe9 tirbnwViE+tdX5/4hg3thfTDFElDgfJulm+469k7A9mhTOaN5kZgQXweRcL7Aha0llAHi750m2f+q 7uBx8NMVoQUXiD4Ch3gYn3PAiEYOPQLpCkZYYkzPvFmpU2wJWLPn/UomY1rMsOIbk38kyLn9MMa3H KTZHdVOTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3dlf-0003F8-PP; Sun, 24 Jan 2021 11:41:19 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3dld-0003F0-7X for linux-arm-kernel@merlin.infradead.org; Sun, 24 Jan 2021 11:41:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M3FSAWCV2zmyTdtnVy67d93WEezl2jaS3Y+9V7bxgfg=; b=TIp1qmX+Wc+PSElTTUMYQCiVsq byjIKNxpCDGZTlBLtYSCfzzBQ/svyQIdDu8hmDtW57KcoQgW4aMH8avBI7mkjFI66OoQe4tP6TXY+ VntHOHWgpyQaw54rxeyxKYBsI4YiaNhltMoEV3QvqI+fYWJOLY+uZsHc97xgSqpC+RFRUzNVB+Dal 4ucRF9Z02bGcU7dN2MBNgHSDeanSSmIEuyLn1FMgjM5GYDzQL6dd0R9c+ur3uNZHpHYf3faGylVML qd31reJoqDmyOsc47wypl/AVuY1rQoeVIPwisZOoFAY3IKgbNNtBUVwdUf5XD4bi9xxwtQn9Vh4zg /VGZlMAg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l3dkW-002v8C-GD; Sun, 24 Jan 2021 11:40:29 +0000 Date: Sun, 24 Jan 2021 11:40:08 +0000 From: Christoph Hellwig To: Nicholas Piggin Subject: Re: [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup Message-ID: <20210124114008.GE694255@infradead.org> References: <20210124082230.2118861-1-npiggin@gmail.com> <20210124082230.2118861-6-npiggin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210124082230.2118861-6-npiggin@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Will Deacon , Ingo Molnar , Catalin Marinas , Ding Tianhong , linux-kernel@vger.kernel.org, Christophe Leroy , Christoph Hellwig , linux-mm@kvack.org, Zefan Li , Borislav Petkov , Jonathan Cameron , Andrew Morton , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h > index 2ca708ab9b20..597b40405319 100644 > --- a/arch/arm64/include/asm/vmalloc.h > +++ b/arch/arm64/include/asm/vmalloc.h > @@ -1,4 +1,12 @@ > #ifndef _ASM_ARM64_VMALLOC_H > #define _ASM_ARM64_VMALLOC_H > > +#include > + > +#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP > +bool arch_vmap_p4d_supported(pgprot_t prot); > +bool arch_vmap_pud_supported(pgprot_t prot); > +bool arch_vmap_pmd_supported(pgprot_t prot); > +#endif Shouldn't the be inlines or macros? Also it would be useful if the architectures would not have to override all functions but just those that are it actually implements? Also lots of > 80 char lines in the patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel