From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9F7C433E6 for ; Mon, 25 Jan 2021 08:42:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D337E224DF for ; Mon, 25 Jan 2021 08:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D337E224DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=51YdqMMd2iVuVzPDSiuZrYL09gpIdrnKZp/7eaUzDhA=; b=i1Hr1QNTwl0hhXFsbE770S58L npfePgFkJ9bDAzUfq8UifxaXsq8UgjC7hylRXktM2Qj7ptTClFAaOTzOwifPFUU8VaQiT5AOMUuhy hlPwHuoccP8Jhe0Cb4Pt0j8jss/qmXEmMQKIySUpcto/ylDkMtmJDNpU4F323C+ut8LzciMIhIag8 j22eH49jXBFaXWj+BBRWBRiXRRhfBsPnDPFjk4VdijiL/5S3VtM+O0hA5xnup/f4JyRUUMiFEPlD1 pSd4zGes50syhUZIIm3Z0+FeMFJTGjB/NDMsNXn06Nnza2+NqD+ATonX4XFztXMuoKHr3S58cptZA ZohpzGTXg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3xQi-0002vw-Av; Mon, 25 Jan 2021 08:41:00 +0000 Received: from mail-wm1-f54.google.com ([209.85.128.54]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3xQe-0002um-M7; Mon, 25 Jan 2021 08:40:57 +0000 Received: by mail-wm1-f54.google.com with SMTP id c128so9936174wme.2; Mon, 25 Jan 2021 00:40:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mZo7aKwXK5deoAcrsXLP1GP5WkzKfPSS28ocvilrOE8=; b=jB/lJM1YvCf7MQdGeA7+tlASzDllEgvjicyMUvXsJdPfpXCHUsjztZ1DQDl1tknxTE Rs7TKcHmdfhN6aULmFE4mzPW8AHANSA99pCAokWvj0C1pTAWVeL5zRlpVj5dBClRbmYZ vYWSsVc1vW1tW7u5o3YI44a1oByJDDvxi0qefWNLdSKlkSfsYkAQvNzbqzD5ZCA9Xzpu vB6Ex4RUw5G49OkmsNIB4YoGyIVpEXnEhli+lxov5PU7T8Rax9vFgmB+n+KacruAI7eP 3fBtRP1bdxpUDxyUH61gu1F8qX3viSqG6ptcaCFBCwBGrub9BqWBn7NwUQj5tM2ZmE/s tb5g== X-Gm-Message-State: AOAM532Ltv17UnzfAx+7n5sxEk/OLAkUXPNFV+BhdxCnlleZktW5TMxc nbHCg4z+GGbnUMofhYHvWhc= X-Google-Smtp-Source: ABdhPJzqtyNCKS2sng7AvV/KuXwIGCg36ChTNZfCr5oRaLPx4r2cb6HVrQPNF1aJsw7Pq4EawQNxdA== X-Received: by 2002:a05:600c:2255:: with SMTP id a21mr14774541wmm.79.1611564053570; Mon, 25 Jan 2021 00:40:53 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id n193sm20346055wmb.0.2021.01.25.00.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 00:40:52 -0800 (PST) Date: Mon, 25 Jan 2021 09:40:51 +0100 From: Krzysztof Kozlowski To: Yong Wu Subject: Re: [PATCH 2/3] memory: mtk-smi: Add module_exit and module_license Message-ID: <20210125084051.ipgeu2ksucdag2u4@kozik-lap> References: <20210121062429.26504-1-yong.wu@mediatek.com> <20210121062429.26504-3-yong.wu@mediatek.com> <20210122213427.mwjyjn2wsgnko7mk@kozik-lap> <1611557381.3184.21.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1611557381.3184.21.camel@mhfsdcap03> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_034056_734012_4DDD7962 X-CRM114-Status: GOOD ( 27.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , srv_heupstream@mediatek.com, Robin Murphy , Joerg Roedel , linux-kernel@vger.kernel.org, yi.kuo@mediatek.com, Tomasz Figa , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 25, 2021 at 02:49:41PM +0800, Yong Wu wrote: > On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > > currently. Thus we don't have module_exit before. This patch adds > > > module_exit and module_license. It is a preparing patch for supporting > > > MTK_SMI could been built as a module. > > > > > > Signed-off-by: Yong Wu > > > --- > > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > > --- a/drivers/memory/mtk-smi.c > > > +++ b/drivers/memory/mtk-smi.c > > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > } > > > module_init(mtk_smi_init); > > > + > > > +static void __exit mtk_smi_exit(void) > > > +{ > > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > +} > > > +module_exit(mtk_smi_exit); > > > + > > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > > > Drivers do not use capital letters, so I have doubts whether this alias > > is correct. > > I didn't care the upper/lower-case. I will change to lower case in next > time. Then why do you need the alias? The name does not match driver name, so what's the purpose of this alias/ > > MODULE_ALIAS("platform:MediaTek-smi") > > > > > Adding all these should be squashed with changing Kconfig into tristate. > > It does not have sense on its own. > > Thanks very much for review. > > Only confirm: Squash whole this patch or only squash the MODULE_x into > the next patch? This entire patch 2/3 should be with 3/3. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel