From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE25C433DB for ; Mon, 25 Jan 2021 10:05:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EBB5206CA for ; Mon, 25 Jan 2021 10:05:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EBB5206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ejdNObgtiAoNtyLuo3kPvTX1Xt/1aVQX0sQh3HyAzxs=; b=l1odjoFx8QcRfldKlarh78kTa IrHqQ0KqEqq98vc1v1Yqa7e5vHNfEgDybDHLfZV30GuguIeSH1RCMADBnTDAB4+Bgah76cWjFVDzz hOp7EzVwjD+tm0tvRRPTCp7Rw91w7ElFOMo5zQKkVmylGUAwiB9g2adRhNo72jjyK4LJUXE98Fpx+ mLEXGl+rpWXt3IhfE+/qD2zEcM4mPSC2dIel7ZV1DSYROPEP6nccWWk4QqVaq+OhA8qFmad0QwI9v S84++qQhZicD5bE8ik/3NBQ/aBeZCOhoN+MGxdqsaq7l+S7o7wOC6vvdI2f540Hwapn7TII4/8iZK TsYRqvO0w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3yip-0004z0-OH; Mon, 25 Jan 2021 10:03:47 +0000 Received: from twspam01.aspeedtech.com ([211.20.114.71]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3yim-0004yX-9y for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 10:03:45 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 10P9tsXQ098016; Mon, 25 Jan 2021 17:55:54 +0800 (GMT-8) (envelope-from troy_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 18:01:37 +0800 Date: Mon, 25 Jan 2021 10:01:19 +0000 From: Troy Lee To: Guenter Roeck Subject: Re: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer Message-ID: <20210125100119.GA2349720@aspeedtech.com> References: <20210113070850.1184506-1-troy_lee@aspeedtech.com> <20210113070850.1184506-5-troy_lee@aspeedtech.com> <20210123161405.GA50622@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210123161405.GA50622@roeck-us.net> X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 10P9tsXQ098016 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_050344_743881_996837A5 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:HARDWARE MONITORING" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jean Delvare , Ryan Chen , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Jonathan Corbet , Andrew Jeffery , "openbmc@lists.ozlabs.org" , "open list:DOCUMENTATION" , open list , "leetroy@gmail.com" , Rob Herring , Joel Stanley , Philipp Zabel , ChiaWei Wang , "moderated list:ARM/ASPEED MACHINE SUPPORT" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Guenter, The 01/24/2021 00:14, Guenter Roeck wrote: > On Wed, Jan 13, 2021 at 07:08:48AM +0000, Troy Lee wrote: > > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and > > 16 FAN tacho channel. > > > > Changes since v1: > > - fixed review comments > > - fixed double-looped calculation of div_h and div_l > > - moving configuration to device tree > > - register hwmon driver with devm_hwmon_device_register_with_info() > > > > Signed-off-by: Troy Lee > > checkpatch says: > > total: 0 errors, 9 warnings, 26 checks, 779 lines checked > > This is a bit much. Please run checkpatch --strict and fix the issues > it reports. Please also fix the issues reported by 0-day as well as > the issues reported by the bindings robot, and resubmit. > > Thanks, > Guenter I'll fix the WARNINGs and CHECKs. Thanks, Troy Lee _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel