From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12293C433DB for ; Tue, 26 Jan 2021 00:03:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9F2522597 for ; Tue, 26 Jan 2021 00:03:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9F2522597 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l0swPVn8MQ9lgKuXFHU/apStO/pM3gtrtHFxcNl9rSE=; b=bzYVpUnZ1owTAnVWmDe/NzQKU jKaohj2mscxPjENrNpiCQ2RPwJL9ieRQwR2N1ZNcysyJlefGkZ89EM/h5MdCE9XYA36Zm2Fupb+hn RI1nrs7KZKhKydqriBzyMJZB/qgxM4EbSQTzMevNzFDWISG3XfNdizF1Q4Zym8dKSUSRjvBszh3VI oHDGqySp7A5BhoSmtpsLX25a4kwlvwPmzdM6yLatBvEzGCnBbAisZv3HHL785jCTWvvIzocLXXphm pqTpwGXuo8kGOJhgzojRtRAG8IDYzcY6WijaAyn0ckGHg+BNG6zy46c1ahzHBsQH7fWJky4L3PWFN 8bqbBwgLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4BnG-0002FM-4t; Tue, 26 Jan 2021 00:01:14 +0000 Received: from mail-oi1-f180.google.com ([209.85.167.180]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4BnD-0002EW-Uo for linux-arm-kernel@lists.infradead.org; Tue, 26 Jan 2021 00:01:12 +0000 Received: by mail-oi1-f180.google.com with SMTP id d18so7402169oic.3 for ; Mon, 25 Jan 2021 16:01:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=du5YoegYLBKhCges/+sXzMbO3GMQX37nv6WSDKN2xZ4=; b=JPOA4IYN51QkZz8rFunX6q9w1774VnctwWblS5C4PN7obzIUxzbnVmaQxwXZtovrdi wE5uWikt4pehI9PpZ3MPVfhRqw1kd1PX2OkBQMk8SnIbW3TJ18jb0xTHhz8LO23sJz0E mYv7JwYAGaf1VHScDQ0EFjtCNgdXqO8yW3wglLf8qz/Mi1HuXkU3RNFDA3SYOiXS8ALr bV/qSOwrnOp1ZcN5e2QiDP6HRqa/KhAHwfIuGT0yoqIoGF97yL5WRXtn66wqQF+zkeyg +as8B8qcMX6PDfxvq53VWQr4dA36HOQbFou4J21t5nGJDQ4J8EX/D2/N889zw1387eFZ dn5Q== X-Gm-Message-State: AOAM531a+NcaFWbZPuW0yM72y+d+6hvKO96qw5JBlbn5wFxCIhN0htNV aWnyxAe3EYTQ6yfMU1G9jg== X-Google-Smtp-Source: ABdhPJx07tuOIe51LMcOFboVe0ycViNWO8nGfvcSmhDCtSDNPHuOPvtDnJLKlxnCvD5S61PZkWHSZg== X-Received: by 2002:aca:5185:: with SMTP id f127mr1652630oib.18.1611619270848; Mon, 25 Jan 2021 16:01:10 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id x141sm1828485oia.3.2021.01.25.16.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 16:01:09 -0800 (PST) Received: (nullmailer pid 1303788 invoked by uid 1000); Tue, 26 Jan 2021 00:01:08 -0000 Date: Mon, 25 Jan 2021 18:01:08 -0600 From: Rob Herring To: Grygorii Strashko Subject: Re: [PATCH v2 2/4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller Message-ID: <20210126000108.GA1267192@robh.at.kernel.org> References: <20201117161942.38754-1-nsekhar@ti.com> <20201117161942.38754-3-nsekhar@ti.com> <20201118151259.kpag44djji4ssiup@eldest> <18e41dba-a3dd-308a-605e-63b76ca638e5@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <18e41dba-a3dd-308a-605e-63b76ca638e5@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_190111_997142_B7B703AB X-CRM114-Status: GOOD ( 31.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Device Tree Mailing List , Lokesh Vutla , Andre Przywara , Sekhar Nori , linux-kernel@vger.kernel.org, Tero Kristo , Faiz Abbas , Linux ARM Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 01:17:36PM +0200, Grygorii Strashko wrote: > > > On 18/11/2020 17:12, Nishanth Menon wrote: > > On 13:38-20201118, Grygorii Strashko wrote: > > > Hi Rob, > > > > > > On 17/11/2020 18:19, Sekhar Nori wrote: > > > > With dtc 1.6.0, building TI device-tree files with W=2 results in warnings > > > > like below for all interrupt controllers. > > > > > > > > /bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider > > > > > > > > Fix these by adding #address-cells = <0>; for all interrupt controllers in > > > > TI device-tree files. Any other #address-cells value is really only needed > > > > if interrupt-map property is being used (which is not the case for existing > > > > TI device-tree files) > > > > > > > > Signed-off-by: Sekhar Nori > > > > --- > > > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++++ > > > > arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 ++ > > > > arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 + > > > > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 3 +++ > > > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 1 + > > > > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 1 + > > > > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 11 +++++++++++ > > > > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 +++ > > > > 8 files changed, 27 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > > index aa8725db0187..55aaa1404d7d 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > > > > @@ -440,6 +440,7 @@ > > > > interrupt-controller; > > > > interrupt-parent = <&gic500>; > > > > #interrupt-cells = <1>; > > > > + #address-cells = <0>; > > > Does it really required or mandatory to have #address-cells = <0>; defined for interrupt-controller DT nodes which > > > do not have child nodes and no "interrupt-map"? > > > > Just to help clarify (I could be mistaken as well): is'nt the > > interrupt map for user interrupt map nodes that refer to this > > interrupt controller node to state they dont need a parent address > > specifier - so are we claiming none of the users will have an > > interrupt-map (now and never in the future as well) - we we might want > > to explain why we think that is the case, and if we are expecting dtc > > to deduce that (if so how?)? > > > > The main reason I commented - is hope to get some clarification from DT maintainers. > 90% of interrupt-controller nodes do not have #address-cells and I never seen in in GPIO nodes > (most often is present in PCI and GIC nodes). > and nobody seems fixing it. So, if we are going to move this direction it's reasonable to get clarification to be sure. > > And there is no "never" here - #address-cells always can be added if really required. Once required, how does one figure that out? It's not obvious and requires booting. So we need something at build time. I'm okay with loosening the check as long as it warns when a interrupt parent phandle in an interrupt-map is missing '#address-cells'. Now that I look back at the dtc change, I'm now confused why this check got applied. Both David and I wanted changes in regards to #address-cells. Either a separate check or part of interrupt-map checks. And the interrupt-map check never got applied. Andre? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel