From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B837C433DB for ; Tue, 26 Jan 2021 00:06:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A44522597 for ; Tue, 26 Jan 2021 00:06:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A44522597 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rJY4d3yBwX7mrkZVxyZh9YEfr4zRcaW0oAYSoQ9Wjec=; b=o8ERm6L2vcqNVRXDdALvhqsjg JOoaaO/XYs6jOtncbU0QYcnkwnqtcAzuv5kclf7Li3RojvUiiBaBhQycoMuZ70KtAAbt0N2fakQk9 p1gEJy24HJepPD9cMj/OmZLaGKwAbh2vPIItJsqk31tfTdALoI4ZPprc+rsWqz8fA9LCMBojf8/b5 WV0SXDOeDRveuZ0m8ffD5JiJsjLudlKGbnXqIH2oC9kbzux32S5nWv0D3S8/0OJhJUMfbqmeS+j54 4fZ2wfWQgjxa+Jpatv6+8Yai0fl3wj+u+aDdOmwFncFBQoxAq2Ww69wfIHBs/MyjreW/nkrh60R3l 023z/cEXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4Bqj-0003Et-Ra; Tue, 26 Jan 2021 00:04:49 +0000 Received: from mail-oi1-f173.google.com ([209.85.167.173]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4Bqg-0003Ds-Mp for linux-arm-kernel@lists.infradead.org; Tue, 26 Jan 2021 00:04:47 +0000 Received: by mail-oi1-f173.google.com with SMTP id h6so15384828oie.5 for ; Mon, 25 Jan 2021 16:04:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5FTRQMQR2ih35r3X59niVzE0TzLmbbqDggAUfz/28Wg=; b=tm2ez4pB5cX/sb91hnHZf1j4m04IlJa1HQ1gK6icV5LpVznv5w1CfZXa2GTT9xSdGN NA3Xus7cuRnu9T4ISsk5uoZkdciUCk5/TsH6Jode/sczs1BAi1AO6bjmf6J+I4D0d3aZ QWmyrKEhylLDwTpd17rq9X8nuSjhUu8FXgZqvXwnAS71jJD7qzAoUvpaiinT4y/AJF/b JWSwmpD2tirUUqGnNOrSkr2/El/l050Vpdh1GWWY1qxgMitjYavrtkpgOr4+GjeXAiHW jKLgCVEdNF5BpoKtqCrC0omdLJYmdhxpw3F4tdFFmU3C0+JTTfKtwfT2yh+NMx3w3JIz v+LQ== X-Gm-Message-State: AOAM531QNJfxZ1Cw0Idc75HH6bN3bXVWuHFBNOsLtA8+eR1+Ub0+l3Bb dpFMwWqIuBn7hm6/I3NvNQ== X-Google-Smtp-Source: ABdhPJwPgy6Zz8wcdpbFSAg+p6w1ktKW/dTzzjT0M0bJrrHC9Mb1T96ctJ6h2nxHB0K1dup7VArzPQ== X-Received: by 2002:aca:d5cf:: with SMTP id m198mr1592801oig.99.1611619485613; Mon, 25 Jan 2021 16:04:45 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id s8sm2359022ood.39.2021.01.25.16.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 16:04:44 -0800 (PST) Received: (nullmailer pid 1310160 invoked by uid 1000); Tue, 26 Jan 2021 00:04:43 -0000 Date: Mon, 25 Jan 2021 18:04:43 -0600 From: Rob Herring To: Suman Anna Subject: Re: [PATCH] dt-bindings: irqchip: Add #address-cells to PRUSS INTC Message-ID: <20210126000443.GA1223706@robh.at.kernel.org> References: <20210115205819.19426-1-s-anna@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210115205819.19426-1-s-anna@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_190446_762206_E1E05FFF X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , devicetree@vger.kernel.org, Grzegorz Jaszczyk , David Lechner , Lokesh Vutla , Marc Zyngier , Sekhar Nori , linux-kernel@vger.kernel.org, Jan Kiszka , Thomas Gleixner , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 15, 2021 at 02:58:19PM -0600, Suman Anna wrote: > The '#address-cells' property looks to be a required property for > interrupt controller nodes as indicated by a warning message seen > when building dtbs with W=2. Adding the property to the PRUSS INTC > dts nodes though fails the dtbs_check. Add this property to the > PRUSS INTC binding to make it compliant with both dtbs_check and > building dtbs. > > Signed-off-by: Suman Anna > --- > Hi Rob, > > This patch is also part of our effort to get rid of the warnings seen > around interrupt providers on TI K3 dtbs [1]. I needed this in the PRUSS > INTC bindings to not get a warning with dtbs_check while also ensuring > no warnings while building dtbs with W=2. > > I would have expected the '#address-cells' requirement to be inherited > automatically. And looking through the schema files, I actually do not > see the interrupt-controller.yaml included automatically anywhere. You > had asked us to drop the inclusion in this binding in our first version > with YAML [3]. Am I missing something, and how do we ensure that this > is enforced automatically for everyone? interrupt-controller.yaml is applied to any node named 'interrupt-controller'. More generally, if 'compatible' is not present, then we look at $nodename for the default 'select'. In your case, you didn't name the node appropriately. We can't check this in interrupt-controller.yaml because #address-cells is not always 0. GICv3 is one notable exception. > > regards > Suman > > [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115083003.27387-1-lokeshvutla@ti.com/ I've commented on this thread now in regards to #address-cells. Rob > [2] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/ > [3] https://patchwork.kernel.org/comment/23484523/ > > .../bindings/interrupt-controller/ti,pruss-intc.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel