Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: mm: Remove unused header file
Date: Tue, 26 Jan 2021 12:39:40 +0000	[thread overview]
Message-ID: <20210126123940.GA29702@willie-the-truck> (raw)
In-Reply-To: <1611663884-43329-1-git-send-email-zhangshaokun@hisilicon.com>

On Tue, Jan 26, 2021 at 08:24:44PM +0800, Shaokun Zhang wrote:
> Many header files are never used, let's remove them directly.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  arch/arm64/mm/mmap.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
> index 07937b49cb88..c66b3878712c 100644
> --- a/arch/arm64/mm/mmap.c
> +++ b/arch/arm64/mm/mmap.c
> @@ -5,20 +5,10 @@
>   * Copyright (C) 2012 ARM Ltd.
>   */
>  
> -#include <linux/elf.h>
> -#include <linux/fs.h>
>  #include <linux/memblock.h>
> -#include <linux/mm.h>
> -#include <linux/mman.h>
> -#include <linux/export.h>
> -#include <linux/shm.h>
> -#include <linux/sched/signal.h>
> -#include <linux/sched/mm.h>
> -#include <linux/io.h>
> -#include <linux/personality.h>
> -#include <linux/random.h>
> +#include <linux/types.h>
>  
> -#include <asm/cputype.h>
> +#include <asm/page.h>

How did you determine that these are safe to remove?

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-26 12:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 12:24 [PATCH] arm64: mm: Remove unused header file Shaokun Zhang
2021-01-26 12:39 ` Will Deacon [this message]
2021-01-27  7:23   ` Shaokun Zhang
2021-01-26 23:39 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126123940.GA29702@willie-the-truck \
    --to=will@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox