From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35623C433DB for ; Wed, 27 Jan 2021 12:48:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C803D207B1 for ; Wed, 27 Jan 2021 12:48:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C803D207B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kWjk6pzmtpdZlusE7QHBzqXzYXRuUasOTwNkikD1rNA=; b=MYwRzQYpRAgS/VAMvNW3SvKO5 RxIQ+63bKsb+5kwWaMCR/zRQC/Pdjq9M21dfihgH3EzNjjBOhKf5eApU1+vR3tXUgOeojMLNTuGG5 YCjq8cum7WwoBV503jiJ88BdQRMY0l2M6faV3OBEXQxvscNUcr/xquFJ64gYkpH0vzyx83LWRvxj7 PeEIKJazmmCYWcftTsNAHh8BJxc47ZMmVk7CGarYwjcelGyFyOZ88GyEkLaQjWVVSRjxXQokF7560 wiIjS7Rd+hfPU2CeK86ALuEhYwFNiZ20Jk0jtnx/TRasPXEYOeU4+ii2obELraImsLCPdtZJxp7// NKlaU+TIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4kD2-0001ha-M3; Wed, 27 Jan 2021 12:46:08 +0000 Received: from mga18.intel.com ([134.134.136.126]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4kD0-0001hA-3Y for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 12:46:07 +0000 IronPort-SDR: PAMj9cmYAbjxvZPrZ6bRXaq/HST+H4yoMJNHyEV+2OnNCezTpVecprwDjat91Exrr3kWwD58CA Svi50BBKUSPA== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="167735532" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="167735532" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:45:57 -0800 IronPort-SDR: 3RTm0iVFoqt3t45cPTzsoQg6veo9tSAFLaRJ69aMN/XC/h1CbnKmPYYR6baItQQ1laD7O8S4JR sN+KUxDGJGfQ== X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="353797488" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:45:55 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 600452067A; Wed, 27 Jan 2021 14:45:53 +0200 (EET) Date: Wed, 27 Jan 2021 14:45:53 +0200 From: Sakari Ailus To: Krzysztof Kozlowski Subject: Re: [PATCH v6 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20210127124553.GB32460@paasikivi.fi.intel.com> References: <20201118202715.6692-1-krzk@kernel.org> <20210122091822.GB27155@paasikivi.fi.intel.com> <20210127122612.evk5sooijid3dmzd@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210127122612.evk5sooijid3dmzd@kozik-lap> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_074606_307261_0A45925E X-CRM114-Status: GOOD ( 25.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 27, 2021 at 01:26:12PM +0100, Krzysztof Kozlowski wrote: > On Fri, Jan 22, 2021 at 11:18:22AM +0200, Sakari Ailus wrote: > > Hi Krysztof, > > > > On Wed, Nov 18, 2020 at 09:27:12PM +0100, Krzysztof Kozlowski wrote: > > > Add bindings for the IMX258 camera sensor. The bindings, just like the > > > driver, are quite limited, e.g. do not support regulator supplies. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > Reviewed-by: Rob Herring > > > > > > --- > > > > > > Changes since v4: > > > 1. Add clock-lanes, > > > 2. Add Rob's review, > > > 3. Add one more example and extend existing one, > > > 4. Add common clock properties (assigned-*). > > > > > > Changes since v3: > > > 1. Document also two lane setup. > > > > > > Changes since v2: > > > 1. Remove clock-frequency, add reset GPIOs, add supplies. > > > 2. Use additionalProperties. > > > > > > Changes since v1: > > > 1. None > > > --- > > > .../devicetree/bindings/media/i2c/imx258.yaml | 140 ++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 141 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx258.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > > > new file mode 100644 > > > index 000000000000..4a3471fb88a1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > > > @@ -0,0 +1,140 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > > > + > > > +maintainers: > > > + - Krzysztof Kozlowski > > > + > > > +description: |- > > > + IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > > > + type stacked image sensor with a square pixel array of size 4208 x 3120. It > > > + is programmable through I2C interface. Image data is sent through MIPI > > > + CSI-2. > > > + > > > +properties: > > > + compatible: > > > + const: sony,imx258 > > > + > > > + assigned-clocks: true > > > + assigned-clock-parents: true > > > + assigned-clock-rates: true > > > + > > > + clocks: > > > + description: > > > + Clock frequency from 6 to 27 MHz. > > > + maxItems: 1 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + reset-gpios: > > > + description: |- > > > + Reference to the GPIO connected to the XCLR pin, if any. > > > + > > > + vana-supply: > > > + description: > > > + Analog voltage (VANA) supply, 2.7 V > > > + > > > + vdig-supply: > > > + description: > > > + Digital I/O voltage (VDIG) supply, 1.2 V > > > + > > > + vif-supply: > > > + description: > > > + Interface voltage (VIF) supply, 1.8 V > > > + > > > + # See ../video-interfaces.txt for more details > > > + port: > > > + type: object > > > + properties: > > > + endpoint: > > > + type: object > > > + properties: > > > + clock-lanes: > > > + const: 0 > > > > This is redundant. Please remove, same for the examples. Can be a separate > > patch, too. > > Before I remove too much - you mean "clock-lanes" is redundant or entire > set of properties in "port" node? Just clock-lanes. The rest are just as they should be IMO. -- Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel