From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD478C4332E for ; Wed, 27 Jan 2021 17:48:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A049564DA3 for ; Wed, 27 Jan 2021 17:48:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A049564DA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=chvxiMsfVuZZ4WmmO/tPi+sKs3uwaUzHXSBSP5j90ZM=; b=Ty56tc2hqffifF+4zsY2+dgJLh 8uOoGnOtzMLUtodVaTQ8hdAsLbfQOj2PCxc4aWLi/LA750Z6+PuMQ0/DHkQ6widkPgcivsEg4RvXL kynHTs5OHtwMYTYhc2uNy/7d2jTyVkIz6eTH6X+cTqc8Qu8xEc66aQFxuCQZSX9/bcKGdIBlFlD1F ytbaJRI6S7h7kmSNMGgN89oLg/6cJR2Dxoa/xn+36mAjEad92ea2V8zz2Au0458bD6QeDgU2b4Klq 9KP9+rksGZ6SO/sBG5B8jj+E/hcOHEVw3fHkJLsTs7m+/QbT9tLVg4O9Ldb6ZXZfkxf0yuZjfxRvt YL9dEMaw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4ouE-00032D-2E; Wed, 27 Jan 2021 17:47:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4oty-0002ve-ES for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 17:46:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B02F64DA3; Wed, 27 Jan 2021 17:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611769605; bh=zWUF7gy1Qf1dX62rn0FAOk2xbwwQdbfUgsxvI5Sklh4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=YfLthjvquvzDDERQauptCyaJCTSpyzmA3O+wbLxSSeY/r0N7yaNmtSONSR8K52tIZ F9qvpIohUGF87//0ndXFGWO83GA/KReBQSwangMAvQ26OdkMqma+gyyRGj0zrqdk/g t3U1kzGBq6aI4EkvwAdUF7u4DZvIk0yWk141HLFaee+FY8MQAMFJe7Fq/qT7tcPcSy HU+on82lWY2AfzsYK7MsQf7yqabxHtdrkw+6hI4BpkokSbpjfvZT4e1SAHIbeVx8lD W3OsMV8wv/4wDIz+uR5G4ktYQOT0TtVAKEKsXnLKuL4tZhjPAb+1qeOSggWgQzM4Xn 98+89PeJdpfTg== From: Krzysztof Kozlowski To: Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 3/4] media: i2c: imx258: simplify getting state container Date: Wed, 27 Jan 2021 18:46:34 +0100 Message-Id: <20210127174635.3596-3-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127174635.3596-1-krzk@kernel.org> References: <20210127174635.3596-1-krzk@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_124646_600204_25FF4A6F X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- Changes since v3: 1. None Changes since v2: 1. New patch --- drivers/media/i2c/imx258.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index ba7f29622974..505981e02cff 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -1018,8 +1018,7 @@ static int imx258_set_stream(struct v4l2_subdev *sd, int enable) static int __maybe_unused imx258_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct imx258 *imx258 = to_imx258(sd); if (imx258->streaming) @@ -1030,8 +1029,7 @@ static int __maybe_unused imx258_suspend(struct device *dev) static int __maybe_unused imx258_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct imx258 *imx258 = to_imx258(sd); int ret; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel