From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7150AC433E0 for ; Wed, 27 Jan 2021 18:03:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06A0464DA0 for ; Wed, 27 Jan 2021 18:03:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06A0464DA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OBC1s/pMciys3yInUP5DSQ5vTmIpd2OXWGKzSEPr+Bo=; b=S4N+xRQQD9fqiaOxf4kPpuQIb XMpcabBA5/Tu3xLbvJIoQp4V6Aqyavm2qaFOBvyKQt48yMMyPJHb7Z/JKuR2QrVs49hUwc+xrsTzE 56vh2LfM/uPFXUMupSdiQq4JgssqnE0gd48GkaQZdyPFvH3Jt4MqbyKffJWbZh4TDdapk50ivCe2M ishpLvk1huo7w4/7IayUDIV0ePS9ZJbgZdYuPTcxBPxhxjxpP+yaYu6DigZOuAZNtlRyIuoji+YOr jJQOssqFJbl8hEIvIp8Iw8CROuYYuzg7YX6r/fmnAGbTzyRtAbv48dDY1++NhXvGawVFAt9fPRjMY H/2KG1S4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4p9P-0007S5-4T; Wed, 27 Jan 2021 18:02:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4p9N-0007Rf-5E for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 18:02:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D404664DAB; Wed, 27 Jan 2021 18:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611770560; bh=/DgxQRCaQ+bjOKRCBN5t16Filx/2Xbp2TwXvChsBqCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qSG9vSF3mDlNwCCULEl6l24OPcV44Jmusij7YRPP1IC5bdAh7ceBgqKWM0xuAOewn NVHyVRKDbbYRehmj2RGQ5BtIopm9rf+shq+6+R77lDYxwuKOvU7jYvtiQ8hjF4U4ro eTJIQw8PxFZr1SRr+dFs6CglAsDv7dSS9CflXFYv8CLnw/k809/kWy5K5L4Eg7g/Bh +PPnE3LazntbQjf9i14fz+0P48+8LWQ7Nv2FA/qvIDqt7Wd0pijK2k8F5M2R2f4GSi KsncqGDHnG1EZwHY1IkZUASFGR6P03jG3HIiV1CC9i3Z/VOy5WaFGFlnG1hKn4Zzxf w0WRGvIEhS7cQ== Date: Wed, 27 Jan 2021 18:02:30 +0000 From: Will Deacon To: Lakshmi Ramasubramanian Subject: Re: [PATCH v15 10/10] arm64: Add IMA log information in kimage used for kexec Message-ID: <20210127180230.GA593@willie-the-truck> References: <20210115173017.30617-1-nramas@linux.microsoft.com> <20210115173017.30617-11-nramas@linux.microsoft.com> <20210127165424.GB358@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_130241_355540_781C90C4 X-CRM114-Status: GOOD ( 26.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, frowand.list@gmail.com, sashal@kernel.org, mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, prsriva@linux.microsoft.com, hsinyi@chromium.org, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, james.morse@arm.com, gregkh@linuxfoundation.org, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 27, 2021 at 09:56:53AM -0800, Lakshmi Ramasubramanian wrote: > On 1/27/21 8:54 AM, Will Deacon wrote: > > On Fri, Jan 15, 2021 at 09:30:17AM -0800, Lakshmi Ramasubramanian wrote: > > > Address and size of the buffer containing the IMA measurement log need > > > to be passed from the current kernel to the next kernel on kexec. > > > > > > Add address and size fields to "struct kimage_arch" for ARM64 platform > > > to hold the address and size of the IMA measurement log buffer. > > > > > > Update CONFIG_KEXEC_FILE to select CONFIG_HAVE_IMA_KEXEC, if CONFIG_IMA > > > is enabled, to indicate that the IMA measurement log information is > > > present in the device tree for ARM64. > > > > > > Co-developed-by: Prakhar Srivastava > > > Signed-off-by: Prakhar Srivastava > > > Signed-off-by: Lakshmi Ramasubramanian > > > Reviewed-by: Thiago Jung Bauermann > > > --- > > > arch/arm64/Kconfig | 1 + > > > arch/arm64/include/asm/kexec.h | 5 +++++ > > > 2 files changed, 6 insertions(+) > > > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > > index 1d466addb078..ea7f7fe3dccd 100644 > > > --- a/arch/arm64/Kconfig > > > +++ b/arch/arm64/Kconfig > > > @@ -1094,6 +1094,7 @@ config KEXEC > > > config KEXEC_FILE > > > bool "kexec file based system call" > > > select KEXEC_CORE > > > + select HAVE_IMA_KEXEC if IMA > > > help > > > This is new version of kexec system call. This system call is > > > file based and takes file descriptors as system call argument > > > diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h > > > index d24b527e8c00..2bd19ccb6c43 100644 > > > --- a/arch/arm64/include/asm/kexec.h > > > +++ b/arch/arm64/include/asm/kexec.h > > > @@ -100,6 +100,11 @@ struct kimage_arch { > > > void *elf_headers; > > > unsigned long elf_headers_mem; > > > unsigned long elf_headers_sz; > > > + > > > +#ifdef CONFIG_IMA_KEXEC > > > + phys_addr_t ima_buffer_addr; > > > + size_t ima_buffer_size; > > > +#endif > > > > Why do these need to be in the arch structure instead of 'struct kimage'? > > > > Currently, only powerpc and, with this patch set, arm64 have support for > carrying forward IMA measurement list across kexec system call. The above > fields are used for tracking IMA measurement list. > > Do you see a reason to move these fields to "struct kimage"? If they're gated on CONFIG_IMA_KEXEC, then it seems harmless for them to be added to the shared structure. Or are you saying that there are architectures which have CONFIG_IMA_KEXEC but do not want these fields? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel