From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F03C433DB for ; Wed, 27 Jan 2021 18:44:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5E3364DA9 for ; Wed, 27 Jan 2021 18:44:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5E3364DA9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z4OXHPt5mskJJlM1sFBSkCHMED5Sv43mDKsR5x44riM=; b=p6ecDrPiNeCrm2s8koJmHhbPM pltmD1bV2XAdyTMtTqYYSGMr2LA62rF4KC22CHXNCeBeV6h5Oy09tkPuAnBuWgHIbJD6WsYILazls csqzHyfcb949SybyZFm8bTX4l8pzZKyUyFUJjlsl4O7tyU9A3nwvTEfHkFakp8abooszp1JOQ4ZdK kTymJIQJnPuijqwqdPdq1/NnscoXfRYeJl2F/7C/XLvQpMsmnIo2GwQcae29axEmFtdjdH17roMWw NsVhvB/rFoN2Dc9bL6ijyo1Q3xyr5wxUPyg/fWDbDNUkjqVcU3dWYgXllo1rcSwxySfng+jo9GnQ+ lH+/OjZ/g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4pmv-0004I9-6h; Wed, 27 Jan 2021 18:43:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4pmr-0004HW-Lx for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 18:43:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B141601FB; Wed, 27 Jan 2021 18:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611773008; bh=GZ0Dc/tE/vX/hQMmkRpmanBmWtj6NrDessKfg0CzNQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hq9cayECysR7wC0JyvXib4KeHkGCaDldIGwVp3rDHBgGkQ1LymJfYzNCHYTWnOteh D/a4R7QdG6BOOOf3X8N/DYX4m5Ylj8hR8GIRpKFTInswxgi9aim5djfTEopswbiYBh 5cA3sd60j8+bOtwsXdyKysCNG6+ZDeOICgWE8vnTanfwhOSE9JVUDFtyd3gYWECdt5 uJ23zMZoj7kUW4bL5vIrmLcZeFPgxo+vAXyEmEU1WFwVLyjQQDigv+6af5vmTVauJf vhk8QGF8ckom1KSdAuAF9nbs/lM+XOOP1TzBNrf9cDTNKAeVMosfDtKRDoEL8tGPUi Tv/6eJXRVeqfg== Date: Wed, 27 Jan 2021 18:43:20 +0000 From: Will Deacon To: Lakshmi Ramasubramanian Subject: Re: [PATCH v15 09/10] arm64: Call kmalloc() to allocate DTB buffer Message-ID: <20210127184319.GA676@willie-the-truck> References: <20210115173017.30617-1-nramas@linux.microsoft.com> <20210115173017.30617-10-nramas@linux.microsoft.com> <20210127165208.GA358@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_134329_915207_EFB5FF01 X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, frowand.list@gmail.com, sashal@kernel.org, mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, prsriva@linux.microsoft.com, hsinyi@chromium.org, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, james.morse@arm.com, gregkh@linuxfoundation.org, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 27, 2021 at 09:59:38AM -0800, Lakshmi Ramasubramanian wrote: > On 1/27/21 8:52 AM, Will Deacon wrote: > > Hi Will, > > > On Fri, Jan 15, 2021 at 09:30:16AM -0800, Lakshmi Ramasubramanian wrote: > > > create_dtb() function allocates kernel virtual memory for > > > the device tree blob (DTB). This is not consistent with other > > > architectures, such as powerpc, which calls kmalloc() for allocating > > > memory for the DTB. > > > > > > Call kmalloc() to allocate memory for the DTB, and kfree() to free > > > the allocated memory. > > > > > > Co-developed-by: Prakhar Srivastava > > > Signed-off-by: Prakhar Srivastava > > > Signed-off-by: Lakshmi Ramasubramanian > > > --- > > > arch/arm64/kernel/machine_kexec_file.c | 12 +++++++----- > > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > > > diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c > > > index 7de9c47dee7c..51c40143d6fa 100644 > > > --- a/arch/arm64/kernel/machine_kexec_file.c > > > +++ b/arch/arm64/kernel/machine_kexec_file.c > > > @@ -29,7 +29,7 @@ const struct kexec_file_ops * const kexec_file_loaders[] = { > > > int arch_kimage_file_post_load_cleanup(struct kimage *image) > > > { > > > - vfree(image->arch.dtb); > > > + kfree(image->arch.dtb); > > > image->arch.dtb = NULL; > > > vfree(image->arch.elf_headers); > > > @@ -59,19 +59,21 @@ static int create_dtb(struct kimage *image, > > > + cmdline_len + DTB_EXTRA_SPACE; > > > for (;;) { > > > - buf = vmalloc(buf_size); > > > + buf = kmalloc(buf_size, GFP_KERNEL); > > > > Is there a functional need for this patch? I build the 'dtbs' target just > > now and sdm845-db845c.dtb is approaching 100K, which feels quite large > > for kmalloc(). > > Changing the allocation from vmalloc() to kmalloc() would help us further > consolidate the DTB setup code for powerpc and arm64. Ok, but at the risk of allocation failure. Can powerpc use vmalloc() instead? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel