From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC8BC433DB for ; Wed, 27 Jan 2021 20:02:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5DF064DA5 for ; Wed, 27 Jan 2021 20:02:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5DF064DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u8uXOpIoPyS4iSniY4QzoNebF9Yt0Kjzu0pdJZc4G/o=; b=sHsQRWHaeLd36nSUtYHfUrh30 TfJNbRL2wMxeIEcdgeUGcn20Xw7FnhYF663qCxqVh/dnyEWx/pC1WdgHLIrETyg+99GOACxwrHwgc bOV1gQ8lRPjg5XUfB39t0oPbrax4eXaoQ/fusf06jFcqlYCnlSN7pS+PzA+FVS/SXyJ6rN564Lf3d GRe2YSqvtjcMREOXbgp+pfl3SqQx5ng+n9sABrLVFN319ZtEBHejJiwnVSTjTehy79LmugkMn579G ZCzFf0+2yUDHoPXnFis5e7HCWrqMnsJ7dUwvbdARXmHrjKgmmKSRjHleuIgEztpMilGHEm8DWEydC hi+3JI6SA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qzm-0006hd-Rg; Wed, 27 Jan 2021 20:00:54 +0000 Received: from mail-oi1-f172.google.com ([209.85.167.172]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qzk-0006fr-5A; Wed, 27 Jan 2021 20:00:53 +0000 Received: by mail-oi1-f172.google.com with SMTP id k25so3478216oik.13; Wed, 27 Jan 2021 12:00:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rvRcBguN/96Hnzr6bI5Ag8OoiWzcrVtrxH3mL5ZfZ1o=; b=SxircyTDGQ3Ho2ItfZ8BDGqxylH9qvfpKmI4GKHdYL1vMVOulHa2aWZeldCUPvUHSZ c3PYKo1SatfTH3zEuIPfWCLBbSx8rBy7IlN4WqPXf9/oUyufhYJbRLST/8lZbLuKhGys dospl+qP8UFVubQbU9AShBDaHJ6Wv7xpdt8o1dzyMWhHGVzrsOY2lOfOOl+SuLCdMKRI vf4wvUP3s4JaOLvtgCotF4QaGEGb29iCkMUq7oi0Wg3BegzOyY1/AUbDv4bHsgJ5rmWg WCHmv/z9rrmpFVc5O954/IKhF1EdwSudFQyTfgfKbvHdaNI0CMagdrK4m+YxtLs5FVw2 eCVw== X-Gm-Message-State: AOAM531pJqe+zbfq8Q4Ns2K0LvOP0hjS4bwksNdGvD7/HpZbX7yO6Cpj 6FEoyBEWQNB8uCmxbnuKHw== X-Google-Smtp-Source: ABdhPJwMBL6J6h0Mdgp/mb0/qiCzzg22X3N+4Non2UUG6xKNUgZwnVj+ExesrC+lIcTiArkT8riPBA== X-Received: by 2002:aca:fcc5:: with SMTP id a188mr4342745oii.169.1611777649178; Wed, 27 Jan 2021 12:00:49 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id z4sm625941ooz.5.2021.01.27.12.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 12:00:47 -0800 (PST) Received: (nullmailer pid 2143114 invoked by uid 1000); Wed, 27 Jan 2021 20:00:46 -0000 Date: Wed, 27 Jan 2021 14:00:46 -0600 From: Rob Herring To: Yong Wu Subject: Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges Message-ID: <20210127200046.GA2142347@robh.at.kernel.org> References: <20210119105203.15530-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210119105203.15530-1-yong.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_150052_209499_85953F2A X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, Will Deacon , Frank Rowand , Joerg Roedel , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Paul Kocialkowski , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Jan 2021 18:52:03 +0800, Yong Wu wrote: > The commit e0d072782c73 ("dma-mapping: introduce DMA range map, > supplanting dma_pfn_offset") always update dma_range_map even though it was > already set, like in the sunxi_mbus driver. the issue is reported at [1]. > This patch avoid this(Updating it only when dev has valid dma-ranges). > > Meanwhile, dma_range_map contains the devices' dma_ranges information, > This patch moves dma_range_map before of_iommu_configure. The iommu > driver may need to know the dma_address requirements of its iommu > consumer devices. > > [1] https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ceb32@arm.com/ > > CC: Rob Herring > CC: Frank Rowand > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset"), > Suggested-by: Robin Murphy > Signed-off-by: Yong Wu > Signed-off-by: Paul Kocialkowski > Reviewed-by: Rob Herring > --- > drivers/of/device.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel