From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91ACC433E0 for ; Fri, 29 Jan 2021 09:39:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 653AA64DFA for ; Fri, 29 Jan 2021 09:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 653AA64DFA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=v3.sk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QzQriEP2pbggzvkdKZ5fhd2OWft2LFhLbT23+v5ZAKI=; b=Vkyt+nO4n2yDOid3WOQblzMKb dztQmQWLZYToi4Vp+ie8XtGtPC7sG6kKd3DBovofw8Oh57slim1+4xQ5MhzU481aFa9EQK19X5n7p TsmzZjgoz+h+aSBGsb8/ube6vvIG5V37nIGbw223vUkWXHYDChkG5NEouUiu+6VGLG2EHzl2CazZ4 jkmWpbep0xWI3xyKBV2xtINn9T3BEQerOUcCX1gkeHxzTk2UwNOTOvIVOcrw6vlZqGZRVIl+hCLu1 a/TenRMeBixBonfrmrpvtSLBZFKdI6oDXKtNQc/BPnouzkvNHPRxTuNd1YNVGoVNSLjb/gp3n2R6a 2GZT4P7Qg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5QEi-0008Tw-1o; Fri, 29 Jan 2021 09:38:40 +0000 Received: from mail.v3.sk ([167.172.186.51] helo=shell.v3.sk) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5QEV-0008QZ-Lc for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 09:38:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 979C7E0AE3; Fri, 29 Jan 2021 09:34:20 +0000 (UTC) Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id O4TowJ4J_LFE; Fri, 29 Jan 2021 09:34:19 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 34E24E0B27; Fri, 29 Jan 2021 09:34:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at zimbra.v3.sk Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ur3IfwRK14AQ; Fri, 29 Jan 2021 09:34:18 +0000 (UTC) Received: from localhost (unknown [109.183.109.54]) by zimbra.v3.sk (Postfix) with ESMTPSA id F1589E0AE3; Fri, 29 Jan 2021 09:34:17 +0000 (UTC) Date: Fri, 29 Jan 2021 10:38:23 +0100 From: Lubomir Rintel To: kostap@marvell.com Subject: Re: [PATCH 2/4] devicetree/bindings: add support for CP110 UTMI driver Message-ID: <20210129093823.GB68955@demiurge.local> References: <20210127112719.30632-1-kostap@marvell.com> <20210127112719.30632-3-kostap@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210127112719.30632-3-kostap@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_043827_952384_9624C6E4 X-CRM114-Status: GOOD ( 27.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mw@semihalf.com, andrew@lunn.ch, jaz@semihalf.com, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, nadavh@marvell.com, vkoul@kernel.org, robh+dt@kernel.org, miquel.raynal@bootlin.com, stefanc@marvell.com, kishon@ti.com, bpeled@marvell.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jan 27, 2021 at 01:27:17PM +0200, kostap@marvell.com wrote: > From: Konstantin Porotchkin > > Add DTS binding for Marvell CP110 UTMI driver > > Signed-off-by: Konstantin Porotchkin Any chance you could convert the document to YAML so that it could be used for automatic validation? > --- > Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt | 69 ++++++++++++++++++-- > 1 file changed, 63 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt > index aa99ceec73b0..109888ba9d2d 100644 > --- a/Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt > +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-utmi.txt > @@ -1,30 +1,61 @@ > -MVEBU A3700 UTMI PHY > --------------------- > +MVEBU UTMI PHY > +--------------- > > USB2 UTMI+ PHY controllers can be found on the following Marvell MVEBU SoCs: > * Armada 3700 > +* Armada 7k/8k (on the CP110) > +* Armada CN913x (on the CP115) > > On Armada 3700, there are two USB controllers, one is compatible with the USB2 > and USB3 specifications and supports OTG. The other one is USB2 compliant and > only supports host mode. Both of these controllers come with a slightly > different UTMI PHY. > > +On Armada 7k/8k and CN913x, there are two host and one device USB controllers. > +Each of two exiting UTMI PHYs could be connected to either USB host or USB device > +controller. > +The USB device controller can only be connected to a single UTMI PHY port: > + 0.H----- USB HOST0 > +UTMI PHY0 --------/ > + 0.D-----0 > + \------ USB DEVICE > + 1.D-----1 > +UTMI PHY1 --------\ > + 1.H----- USB HOST1 > + > + > Required Properties: > > - compatible: Should be one of: > * "marvell,a3700-utmi-host-phy" for the PHY connected to > - the USB2 host-only controller. > + the USB2 host-only controller (for Armada3700 only). > * "marvell,a3700-utmi-otg-phy" for the PHY connected to > - the USB3 and USB2 OTG capable controller. > + the USB3 and USB2 OTG capable controller (for Armada3700 only. > + * "marvell,cp110-utmi-phy" (for Armada 7k/8k or CN913x only). > - reg: PHY IP register range. > - marvell,usb-misc-reg: handle on the "USB miscellaneous registers" shared > region covering registers related to both the host > - controller and the PHY. > -- #phy-cells: Standard property (Documentation: phy-bindings.txt) Should be 0. > + controller and the PHY (for Armada3700 only). > +- marvell,system-controller: should contain a phandle to the system > + controller node (for Armada 7k/8k or CN913x only) I guess this is okay, but referring to a syscon is done in a multitude ways across various other bindings; with the most popular being just: syscon = <&syscon>; Perhaps consider doing that? > +- #phy-cells: Standard property (Documentation: phy-bindings.txt. > + Should be 0 (for Armada3700 only). > + > + > +Required properties (child nodes, for Armada 7k/8k/CN913x only): > + > +- reg: UTMI PHY port ID (0 or 1). > +- #phy-cells : Should be 0. > + > + > +Optional Properties (child nodes, for Armada 7k/8k/CN913x only):: > > +- marvell,cp110-utmi-device-mode: request the driver to connect the UTMI PHY > + port to USB device controller. Do you need a separate property for this? Could the driver look at "dr_mode" property of the USB controller node to see if it's supposed to be in device/peripheral mode? > Example: > > +Armada3700 > usb2_utmi_host_phy: phy@5f000 { > compatible = "marvell,armada-3700-utmi-host-phy"; > reg = <0x5f000 0x800>; > @@ -36,3 +67,29 @@ Example: > compatible = "marvell,armada-3700-usb2-host-misc", "syscon"; > reg = <0x5f800 0x800>; > }; > + > +Armada 7k/8k/CN913x > + > + CP11X_LABEL(utmi): utmi@580000 { > + compatible = "marvell,cp110-utmi-phy"; > + reg = <0x580000 0x2000>; > + marvell,system-controller = <&CP11X_LABEL(syscon0)>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + > + CP11X_LABEL(utmi0): phy@0 { > + /* UTMI PHY port-0 is connected to USB Host controller-0 */ > + reg = <0>; > + #phy-cells = <0>; > + }; > + > + CP11X_LABEL(utmi1): phy@1 { > + /* UTMI PHY port-1 is connected to USB device controller */ > + reg = <1>; > + #phy-cells = <0>; > + marvell,cp110-utmi-device-mode; > + }; > + }; > + > + > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel