From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0673BC433E0 for ; Sun, 31 Jan 2021 17:04:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE3F264E0E for ; Sun, 31 Jan 2021 17:04:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE3F264E0E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/0H4Mpnu/nyic1F3CLqub/AhMFoXJNoMmimhoTwuY98=; b=Ak1qsVw3iRWEBjw86Xsj99fa0 74SCC/+x9GHqYm3oRPj8zIKd2FRiElvENB7o528S92ebz6Ql+fPC3uydrEtHNE/BfSzHpc2oujDp3 Me8WUGp3xhE5LfqGKCckanIiHoSBOr9k2XGgoxn/IN0i8aiFcPHHr7ceAb5Z8FsGxWh4lGHXe6SSi yNYeQVd7MKy/URS3LaITA4Jmqom7jadYxgCM48byjkA6ORUa3Gmg5F2Xpl5KWfNeeIafpqt80j4Iz uTAO/lhMjOTKMaBKH0SDQok6/QQvsez6NW+lnDwGv4cdyfHF75ByDfmom4syiMyz4sB+ReMHxLuOk tvKsuYgDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6G7x-0000z0-AB; Sun, 31 Jan 2021 17:03:09 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6G7u-0000yR-MQ for linux-arm-kernel@lists.infradead.org; Sun, 31 Jan 2021 17:03:07 +0000 Received: by mail-wm1-x330.google.com with SMTP id o5so1013217wmq.2 for ; Sun, 31 Jan 2021 09:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundries.io; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wUPCyAifWqL5Vj5Jk9bmBrxxmegSXhxcn8hAMEZLfqw=; b=N25VRBuHMI8fFL/5LKzMtHmfohdVFjZVq+DxT2RrcRSMwJZX1MchkNJFUKPhyax7JE A5NPhsqc3aEvIEkzoavO1slimwjEyeD7EauQshL1IoR7PX0Zp35M91+YzAIHZoYXYz9F qX/h+jSTkS/nU//CPSDHta1ZGpG4yO6rpxGGu8ySHGzgLAet83drix0wwB+0w/qsEbXo kgWphHcJB/EQkC7Y+RCud9y2OmKY5XdLc2/kEUv83RfbwefnqQZCDzO8YIL2oM43aJVL CvJjDKEVlecrLWGBSRZT2sEgGR7gqhvOyaxtv5Mnmdi6l4Shz+9PGwfaNmH8KsAx3TQq m6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wUPCyAifWqL5Vj5Jk9bmBrxxmegSXhxcn8hAMEZLfqw=; b=gEYB7sqx1OcQM/ugMyXm7aYnHuyBpBWPVdQ/Ogj+0xAUholRaS4SCxq/6uI7uIw3cA KzymDQJFfxxLeQzeIIISMwPzUK+hhEwpke8gjFjrGZD7N8M9EPX80O39a/1rwuyXC/2U rcYQ3ByoXGE2g2oKgaLNWTu4/8qfD2pjG+UZUrZiUhrgG9A4mR9zV1ImQuV3eWA8YXd/ N2+K7i9QLOi1Qz1MZAKMOHULejiPObkg2CoKhhvx199i+pQ9abexKYjqnRP7awFnGhO7 Rzb2ShNYZS1vAD8nlx5+i3+iLKAVRKkH8i5/7l+6JJ1hZFoOvbhWo3v0rwX9AIXlVLRT eWjA== X-Gm-Message-State: AOAM533sXYvywEioCPPsjuYwG4zmfBaQCdFWiv8ldjwnEAxUZhVWzUqn nE03bFoEYExUW5J01gb5yJwkaA== X-Google-Smtp-Source: ABdhPJxCXNrX6YwX/3LNyx/iFe5oSA9vYklvPx3z3amqyxozA3ASd4MMJ4/tFP5n6+LVQOoqoCz8+A== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr11808714wmb.180.1612112583753; Sun, 31 Jan 2021 09:03:03 -0800 (PST) Received: from trex (182.red-79-146-86.dynamicip.rima-tde.net. [79.146.86.182]) by smtp.gmail.com with ESMTPSA id q6sm22296511wrw.43.2021.01.31.09.03.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 31 Jan 2021 09:03:03 -0800 (PST) From: "Jorge Ramirez-Ortiz, Foundries" X-Google-Original-From: "Jorge Ramirez-Ortiz, Foundries" Date: Sun, 31 Jan 2021 18:03:01 +0100 To: Sai Prakash Ranjan Subject: Re: [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ Message-ID: <20210131170301.GA25412@trex> References: <20210126150241.10009-1-saiprakash.ranjan@codeaurora.org> <20210128081924.GA30289@trex> <72cdf644c431b7b605f9d15a4a7fb7b8@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <72cdf644c431b7b605f9d15a4a7fb7b8@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210131_120307_051073_DD9D4D68 X-CRM114-Status: GOOD ( 26.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bjorn Andersson , Andy Gross , linux-arm-kernel@lists.infradead.org, "Jorge Ramirez-Ortiz, Foundries" , Jorge Ramirez-Ortiz , Wim Van Sebroeck , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/01/21, Sai Prakash Ranjan wrote: > On 2021-01-28 13:49, Jorge Ramirez-Ortiz, Foundries wrote: > > On 26/01/21, Sai Prakash Ranjan wrote: > > > As per register documentation, QCOM_WDT_ENABLE_IRQ which is BIT(1) > > > of watchdog control register is wakeup interrupt enable bit and > > > not related to bark interrupt at all, BIT(0) is used for that. > > > So remove incorrect usage of this bit when supporting bark irq for > > > pre-timeout notification. Currently with this bit set and bark > > > interrupt specified, pre-timeout notification and/or watchdog > > > reset/bite does not occur. > > > > > > Fixes: 36375491a439 ("watchdog: qcom: support pre-timeout when the > > > bark irq is available") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Sai Prakash Ranjan > > > --- > > > > > > Reading the conversations from when qcom pre-timeout support was > > > added [1], Bjorn already had mentioned it was not right to touch this > > > bit, not sure which SoC the pre-timeout was tested on at that time, > > > but I have tested this on SDM845, SM8150, SC7180 and watchdog bark > > > and bite does not occur with enabling this bit with the bark irq > > > specified in DT. > > > > this was tested on QCS404. have you validated there? unfortunately I > > no longer have access to that hardware or the documentation > > > > I didn't validate on qcs404 yet since I didn't have access to it. > But now that you mention it, let me arrange for a setup and test it > there as well. Note: I did not see bark irq entry in upstream qcs404 > dtsi, so you must have had some local change when you tested? TBH I dont quite remember. I suppose that if those with access to the documents and hardware are OK with this change then it shouldnt cause regressions (I just cant check from my end) > > Thanks, > Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel