From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2803EC433E0 for ; Mon, 1 Feb 2021 09:28:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 725BA64E30 for ; Mon, 1 Feb 2021 09:28:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 725BA64E30 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:From:To:Date:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F4vybZl9H795Xp0eo499ahxWdDW7wAuaYa8/5+4gUzE=; b=CwConH2PMTnyUHoYxYEf9kPxmV ogq1cX/bqJygLL/W3B+FCRtFxywTYapTgZdwOra983uliLZ5SlHt2RgtCQ+ZF1KgHizOVAAretXb0 Lnh68tYCW7cF5Eo18hDZFMh0St6ohI1RqVM3Z9bz+WZnOJ5YWznG1VWdcdCm+xxJ6G9awhh7T86Gx Ytl950Uwtw+j+DSE6LOQMTKxxw4gU7H4zdRO11gwoI//r8lMzWhmjUd6am3UeXvMTuu0H4rPiNPy0 LovabbVTLf4IY86n2WdONrnoiElkfq5tzmIyrDZ/WP34HQxSp9FsKTgiRb2vksXrytUuwQUv+FnKI NvCbH0Kg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6VU0-0006vw-VT; Mon, 01 Feb 2021 09:26:57 +0000 Received: from mail-40133.protonmail.ch ([185.70.40.133]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6VTx-0006vG-Mt for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 09:26:54 +0000 Date: Mon, 01 Feb 2021 09:26:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1612171608; bh=l4VqyLGfHDzFtVncVKqnkbusTB+SkuizzKV916LTdLQ=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Eq3LlrxFIyggLVlgKjM+6pmPSOvgf/6JoqN06oTF/IGXtrdNx5lTX6OYWtQuZ8tG7 +R+8c9N29FdjRtcYY0eSEE9gekGgGp0grq0craZybbcDWcS2BemwZbRhOyeEb2no0/ w3dPs5/APhL5JDK6tvvDFi7q9t5/9k/Mnon9Gdxo= To: Krzysztof Kozlowski From: Timon Baetz Subject: Re: [PATCH 3/3] power: supply: max8997_charger: Switch to new binding Message-ID: <20210201083128.18499ffd.timon.baetz@protonmail.com> In-Reply-To: <20210131172840.fxaadhhsafa4aeex@kozik-lap> References: <20210130172747.2022977-1-timon.baetz@protonmail.com> <20210130172747.2022977-4-timon.baetz@protonmail.com> <20210131172840.fxaadhhsafa4aeex@kozik-lap> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_042653_974143_6EA8720B X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Timon Baetz Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Liam Girdwood , Mark Brown , Sebastian Reichel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 31 Jan 2021 18:28:40 +0100, Krzysztof Kozlowski wrote: > On Sat, Jan 30, 2021 at 05:30:14PM +0000, Timon Baetz wrote: > > Get regulator from parent device's node and extcon by name. > > > > Signed-off-by: Timon Baetz > > --- > > drivers/power/supply/max8997_charger.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/power/supply/max8997_charger.c b/drivers/power/supply/max8997_charger.c > > index 321bd6b8ee41..625d8cc4312a 100644 > > --- a/drivers/power/supply/max8997_charger.c > > +++ b/drivers/power/supply/max8997_charger.c > > @@ -168,6 +168,7 @@ static int max8997_battery_probe(struct platform_device *pdev) > > int ret = 0; > > struct charger_data *charger; > > struct max8997_dev *iodev = dev_get_drvdata(pdev->dev.parent); > > + struct device_node *np = pdev->dev.of_node; > > struct i2c_client *i2c = iodev->i2c; > > struct max8997_platform_data *pdata = iodev->pdata; > > struct power_supply_config psy_cfg = {}; > > @@ -237,20 +238,23 @@ static int max8997_battery_probe(struct platform_device *pdev) > > return PTR_ERR(charger->battery); > > } > > > > + // grab regulator from parent device's node > > + pdev->dev.of_node = iodev->dev->of_node; > > charger->reg = devm_regulator_get_optional(&pdev->dev, "charger"); > > + pdev->dev.of_node = np; > > I think the device does not have its own node anymore. Or did I miss > something? The idea is to reset of_node to whatever it was before (NULL) and basically leave the device unchanged. Probe might run again because of deferral. > > if (IS_ERR(charger->reg)) { > > if (PTR_ERR(charger->reg) == -EPROBE_DEFER) > > return -EPROBE_DEFER; > > dev_info(&pdev->dev, "couldn't get charger regulator\n"); > > } > > - charger->edev = extcon_get_edev_by_phandle(&pdev->dev, 0); > > - if (IS_ERR(charger->edev)) { > > - if (PTR_ERR(charger->edev) == -EPROBE_DEFER) > > + charger->edev = extcon_get_extcon_dev("max8997-muic"); > > + if (IS_ERR_OR_NULL(charger->edev)) { > > + if (!charger->edev) > > Isn't NULL returned when there is simply no extcon? It's different than > deferred probe. Returning here EPROBE_DEFER might lead to infinite probe > tries (on every new device probe) instead of just failing it. extcon_get_extcon_dev() just loops through all registered extcon devices and compared names. It will return NULL when "max8997-muic" isn't registered yet. extcon_get_extcon_dev() never returns EPROBE_DEFER so checking for NULL seems to be the only way. Other drivers using that function also do NULL check and return EPROBE_DEFER. Thanks for reviewing, Timon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel