From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D68C433E0 for ; Mon, 1 Feb 2021 17:07:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1F6D64EA2 for ; Mon, 1 Feb 2021 17:07:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1F6D64EA2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YEbTtJrzlD+8BZkcuq3Ta0lsSXTQc4DCvApqIeWYx1w=; b=bfOSys0nDNMIzv44e4w6YZN+0 O7rVXnN4MiTE9nUSAS7tq0dDkkW56M0Z9s2Eqcnw4/CT85Os8zRCQfbabzjpoUJqPDxF7EmArs0Gy QoF21hUZrCYHeMnKDSMnM179U9XtGBiZuVhwbgTIbJ9TeuNAbPCIZ35fI5QsMZ7AJXuxXLSZqjIU1 No3rwhiVwD4oDVWHRBgFj2oQfLjrKjb4Y1/CT2e1TIrCdw/O/s2E4Vuqsevc/vtuat55OlFHFWwYY iJZUpaPeAvE4evVWmsIBOW3jPMo8a/3saMOa7k7+ZATEcPwqUisz/cEGZPuXuhWShvOx+hKgca/bp iuxy4hbEA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6ce3-0004E6-6R; Mon, 01 Feb 2021 17:05:47 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6ce0-0004DT-3p for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 17:05:45 +0000 Received: by mail-pg1-x533.google.com with SMTP id r38so12455308pgk.13 for ; Mon, 01 Feb 2021 09:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rV0K3F4zmeFdrVc02lSWJwOMPX58ML+v7RlA79PMicU=; b=jJ0VbsO9t5DSWgyjy9Zb5XMirkM538/h0z7vYekgbJ8VlWdqeZod2gMdQ3QMxRPHl6 ygozOMFrOcOukUqgY50TWQWWL+JHiDtB3fgFN6bnBU0eRFYxCMNM6CxbhOVgXYTEm0YB GZ0dLFspeAGIXaZ1qhcVxW8VoAvjHOXLfO9jKMS6/P9O/hdoqSqnlhSDDleO3FXavl3K q4sFyAI678eZ5SzBFKb6N3hkzRjyIVszFsB6nmnzk7y6QOSGh6sU89b3k9G7XDVxR5uI rkgKoN7TWGUU8ze+8YxFQi7Agv2KIurgquVNzY+RFDsO20cMqBtIEofyFUWfAHuhx4OA MHjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rV0K3F4zmeFdrVc02lSWJwOMPX58ML+v7RlA79PMicU=; b=CDwvgeca4v9fE9OwqtB8S681Se2vut20CmVTToe1I9qvvzE2P78odHKBBF14XJE4Ey yTvo/psXuJlya8qqofRmDupiV33LVq/t4AjgIuueY2K7KxJuH24iZfab+v9QcmdWpI0k 7GR9y+dYZGHbE+GuiKLP4XJtS7gaphTQzVFAeZqT7q2FxjPF9BsI2n3gcLDhQ4tY6Do9 TkNAA5UWE9qWZQPUbZ1xfY44k5aN4djof/YoI7GKlqGWUyl0Rz8lQbVtd8krlmdOiNOP D1r5LUtpfGSQXG8/AJlOzTQMJVEKSCwFvj69ejHVKSjwQEGuvxzneoIeQfUzcEoR6Gzf J84w== X-Gm-Message-State: AOAM531B/sQmviHE6XzXkiE2GX5OzVFpiAS8MTbL9DPbSX8JpVA4j4JQ JnDyVe9CpdN2y+52PO8AsT/6iw== X-Google-Smtp-Source: ABdhPJz6dnxvU47KSjmsC0//Ahz4yMlX3PAzHgWbP7GrUCLItx4zzF7U7B/Tt8UP1HO+8ysyXMfnDw== X-Received: by 2002:a63:1f21:: with SMTP id f33mr18240572pgf.31.1612199140061; Mon, 01 Feb 2021 09:05:40 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id i9sm18878851pfo.146.2021.02.01.09.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 09:05:39 -0800 (PST) Date: Mon, 1 Feb 2021 10:05:37 -0700 From: Mathieu Poirier To: Qi Liu Subject: Re: [PATCH] coresight: Remove duplicate header files of coresight drivers Message-ID: <20210201170537.GA1399621@xps15> References: <1612184564-26613-1-git-send-email-liuqi115@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1612184564-26613-1-git-send-email-liuqi115@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_120544_478331_06DD46C3 X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, linuxarm@openeuler.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Good day, On Mon, Feb 01, 2021 at 09:02:44PM +0800, Qi Liu wrote: > Remove duplicate included header files, as coresight-priv.h is included in > these coresight drivers. > > Signed-off-by: Qi Liu > --- > drivers/hwtracing/coresight/coresight-catu.c | 2 -- > drivers/hwtracing/coresight/coresight-core.c | 3 --- > drivers/hwtracing/coresight/coresight-cpu-debug.c | 3 --- > drivers/hwtracing/coresight/coresight-cti-core.c | 3 --- > drivers/hwtracing/coresight/coresight-cti-platform.c | 1 - > drivers/hwtracing/coresight/coresight-cti.h | 1 - > drivers/hwtracing/coresight/coresight-etb10.c | 4 ---- > drivers/hwtracing/coresight/coresight-etm-perf.c | 1 - > drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 1 - > drivers/hwtracing/coresight/coresight-etm4x-core.c | 5 ----- > drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 1 - > drivers/hwtracing/coresight/coresight-funnel.c | 3 --- > drivers/hwtracing/coresight/coresight-platform.c | 2 -- > drivers/hwtracing/coresight/coresight-replicator.c | 3 --- > drivers/hwtracing/coresight/coresight-stm.c | 3 --- > drivers/hwtracing/coresight/coresight-tmc-core.c | 3 --- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 1 - > drivers/hwtracing/coresight/coresight-tmc-etr.c | 1 - > drivers/hwtracing/coresight/coresight-tpiu.c | 4 ---- > 19 files changed, 45 deletions(-) The idea is to make sure every file stands on its own without dependencies on other header files. Otherwise it is difficult and expensive to move files around or make changes to any header file. As such I will not move forward with this set. Thanks, Mathieu > > diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c > index a61313f..fcc0367 100644 > --- a/drivers/hwtracing/coresight/coresight-catu.c > +++ b/drivers/hwtracing/coresight/coresight-catu.c > @@ -7,10 +7,8 @@ > * Author: Suzuki K Poulose > */ > > -#include > #include > #include > -#include > #include > #include > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 4ba801d..5fb8b12 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -7,17 +7,14 @@ > #include > #include > #include > -#include > #include > #include > #include > #include > #include > #include > -#include > #include > #include > -#include > > #include "coresight-etm-perf.h" > #include "coresight-priv.h" > diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c > index e1d2324..f8df512 100644 > --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c > +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c > @@ -4,15 +4,12 @@ > * > * Author: Leo Yan > */ > -#include > -#include > #include > #include > #include > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c > index 61dbc1a..ed7ab82 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-core.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -4,18 +4,15 @@ > * Author: Mike Leach > */ > > -#include > #include > #include > #include > #include > #include > #include > -#include > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c > index ccef04f..60b0580 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-platform.c > +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c > @@ -2,7 +2,6 @@ > /* > * Copyright (c) 2019, The Linaro Limited. All rights reserved. > */ > -#include > #include > #include > #include > diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h > index acf7b54..0a3b313 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.h > +++ b/drivers/hwtracing/coresight/coresight-cti.h > @@ -7,7 +7,6 @@ > #ifndef _CORESIGHT_CORESIGHT_CTI_H > #define _CORESIGHT_CORESIGHT_CTI_H > > -#include > #include > #include > #include > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index 0cf6f0b..8d5bc04 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -10,17 +10,13 @@ > #include > #include > #include > -#include > #include > #include > #include > #include > #include > #include > -#include > #include > -#include > -#include > #include > #include > #include > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index bdc34ca..01aba63 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -4,7 +4,6 @@ > * Author: Mathieu Poirier > */ > > -#include > #include > #include > #include > diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > index e8c7649..5cf6660 100644 > --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > @@ -5,7 +5,6 @@ > */ > > #include > -#include > #include > #include "coresight-etm.h" > #include "coresight-priv.h" > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index b20b6ff..0438ef7 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -3,13 +3,11 @@ > * Copyright (c) 2014, The Linux Foundation. All rights reserved. > */ > > -#include > #include > #include > #include > #include > #include > -#include > #include > #include > #include > @@ -20,14 +18,11 @@ > #include > #include > #include > -#include > #include > #include > -#include > #include > #include > #include > -#include > #include > > #include > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > index 989ce7b..347ccb7 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > @@ -5,7 +5,6 @@ > */ > > #include > -#include > #include > #include "coresight-etm4x.h" > #include "coresight-priv.h" > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index 071c723..c79ded9 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -15,9 +15,6 @@ > #include > #include > #include > -#include > -#include > -#include > #include > > #include "coresight-priv.h" > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index 3629b78..ca22409 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -13,8 +13,6 @@ > #include > #include > #include > -#include > -#include > #include > #include > > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index 7e2a2b7..36788de 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -6,14 +6,11 @@ > */ > > #include > -#include > #include > #include > #include > -#include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index 9979177..75f0bd8 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -17,17 +17,14 @@ > */ > #include > #include > -#include > #include > #include > -#include > #include > #include > #include > #include > #include > #include > -#include > #include > > #include "coresight-priv.h" > diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c > index 8169dff..4fff281 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-core.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -21,8 +20,6 @@ > #include > #include > #include > -#include > -#include > > #include "coresight-priv.h" > #include "coresight-tmc.h" > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c > index 989d965..b263f75 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c > @@ -6,7 +6,6 @@ > > #include > #include > -#include > #include > #include > #include "coresight-priv.h" > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index bf5230e..1ab0b28 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -5,7 +5,6 @@ > */ > > #include > -#include > #include > #include > #include > diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c > index d5dfee9..c5675f9 100644 > --- a/drivers/hwtracing/coresight/coresight-tpiu.c > +++ b/drivers/hwtracing/coresight/coresight-tpiu.c > @@ -9,12 +9,8 @@ > #include > #include > #include > -#include > #include > #include > -#include > -#include > -#include > #include > > #include "coresight-priv.h" > -- > 2.8.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel