From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B19C433E0 for ; Mon, 1 Feb 2021 18:05:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70FAC64E9C for ; Mon, 1 Feb 2021 18:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70FAC64E9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xQxfabyFw8sieVnSq3liBak5cZWCdfU4O3vW9kB/EeU=; b=H9+gGg9jPgXgPiC1PegGfQtru DVxoS20cdBoTysQkR5OTIMK+AyWGpaHupIWIiguDFtBoT1dcabvBR0/yJg6zZGaz4btrDJg1lYmnD 4/EIWRC7lQVsckWd0HC2AQpoEUcXn89GPalzG5hFAqt2ShNiAnmCP6CtDj06o2c4fSEMsKTUFJzOG bwIK2bxJcrrqG036ko8GcZ1mASjYNc94DH1flxAGSK5upRl30vvqoLzCLVFDNWiMuFsO3P2uRSjvw a9MSXAt1qv37I3O0PYqmGFXjNRtqZFfYi1i2gX7LMUkQJvRU7+JXZR2Seyi0lXKf89tCGOgZJeknn qeFr248Ig==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6dYA-0001n5-7s; Mon, 01 Feb 2021 18:03:46 +0000 Received: from mail-wr1-f48.google.com ([209.85.221.48]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6dY7-0001mJ-3P for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2021 18:03:44 +0000 Received: by mail-wr1-f48.google.com with SMTP id v15so17661951wrx.4 for ; Mon, 01 Feb 2021 10:03:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fKxZfOhT/DW7ng3x2hQg+/AugT9c3F61tbpfJY+S9fg=; b=ocpn/A1FDPx102/icKqxAAmqDne7684s2W4LO2XV/8XM+JYVxpeIZiw4sX2958h4oG gBhNnv5I3oaSLrjEGSRvK0usa2tPxjefUL3FnKPk2qJx2br8ek+Tcz60Qq6s2tI9JDfj BS3Pe8uKXt51c1zRGdo9Y5m/J1orc2jG3Oq2lb3OxwAq3WtTuCJlyoyE8v8JCqPnJYaC 0MRsafpg9JMmF462bdodzjOMnwmwlVhG6h7L1oNZZMCZhyTgblitVSkio0S9gm1Pu1Sj kGlOaO5kaSkZJMs7Y/rHyWCt6qx7nejIxAtSk0J+adU0IyUmYBtrym05R3BiTvHcOES6 4z5Q== X-Gm-Message-State: AOAM530iWyagExN9aUc1+H5S/yFob5sTZRKjP0fm1SNQTu4nKumkJXlJ 8sNVeBoUEH6YwoY6c415UwU= X-Google-Smtp-Source: ABdhPJwL6YHDCvYoDuQCnzLFd63X1o28rVOo0eX5DFDlJKIewDByM/euMbQI7hRpkiGev2a9nEBpbg== X-Received: by 2002:adf:d4ce:: with SMTP id w14mr18936280wrk.89.1612202619004; Mon, 01 Feb 2021 10:03:39 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t17sm42062wmi.46.2021.02.01.10.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 10:03:37 -0800 (PST) Date: Mon, 1 Feb 2021 19:03:35 +0100 From: Krzysztof Kozlowski To: Timon Baetz Subject: Re: [PATCH 3/3] power: supply: max8997_charger: Switch to new binding Message-ID: <20210201180335.rrsqfvbcmxvx64gf@kozik-lap> References: <20210130172747.2022977-1-timon.baetz@protonmail.com> <20210130172747.2022977-4-timon.baetz@protonmail.com> <20210131172840.fxaadhhsafa4aeex@kozik-lap> <20210201083128.18499ffd.timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210201083128.18499ffd.timon.baetz@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_130343_158737_637CD666 X-CRM114-Status: GOOD ( 24.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Liam Girdwood , Mark Brown , Sebastian Reichel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 01, 2021 at 09:26:42AM +0000, Timon Baetz wrote: > On Sun, 31 Jan 2021 18:28:40 +0100, Krzysztof Kozlowski wrote: > > On Sat, Jan 30, 2021 at 05:30:14PM +0000, Timon Baetz wrote: > > > Get regulator from parent device's node and extcon by name. > > > > > > Signed-off-by: Timon Baetz > > > --- > > > drivers/power/supply/max8997_charger.c | 12 ++++++++---- > > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/power/supply/max8997_charger.c b/drivers/power/supply/max8997_charger.c > > > index 321bd6b8ee41..625d8cc4312a 100644 > > > --- a/drivers/power/supply/max8997_charger.c > > > +++ b/drivers/power/supply/max8997_charger.c > > > @@ -168,6 +168,7 @@ static int max8997_battery_probe(struct platform_device *pdev) > > > int ret = 0; > > > struct charger_data *charger; > > > struct max8997_dev *iodev = dev_get_drvdata(pdev->dev.parent); > > > + struct device_node *np = pdev->dev.of_node; > > > struct i2c_client *i2c = iodev->i2c; > > > struct max8997_platform_data *pdata = iodev->pdata; > > > struct power_supply_config psy_cfg = {}; > > > @@ -237,20 +238,23 @@ static int max8997_battery_probe(struct platform_device *pdev) > > > return PTR_ERR(charger->battery); > > > } > > > > > > + // grab regulator from parent device's node > > > + pdev->dev.of_node = iodev->dev->of_node; > > > charger->reg = devm_regulator_get_optional(&pdev->dev, "charger"); > > > + pdev->dev.of_node = np; > > > > I think the device does not have its own node anymore. Or did I miss > > something? > > The idea is to reset of_node to whatever it was before (NULL) and basically > leave the device unchanged. Probe might run again because of deferral. Good point. > > > > if (IS_ERR(charger->reg)) { > > > if (PTR_ERR(charger->reg) == -EPROBE_DEFER) > > > return -EPROBE_DEFER; > > > dev_info(&pdev->dev, "couldn't get charger regulator\n"); > > > } > > > - charger->edev = extcon_get_edev_by_phandle(&pdev->dev, 0); > > > - if (IS_ERR(charger->edev)) { > > > - if (PTR_ERR(charger->edev) == -EPROBE_DEFER) > > > + charger->edev = extcon_get_extcon_dev("max8997-muic"); > > > + if (IS_ERR_OR_NULL(charger->edev)) { > > > + if (!charger->edev) > > > > Isn't NULL returned when there is simply no extcon? It's different than > > deferred probe. Returning here EPROBE_DEFER might lead to infinite probe > > tries (on every new device probe) instead of just failing it. > > extcon_get_extcon_dev() just loops through all registered extcon devices > and compared names. It will return NULL when "max8997-muic" isn't > registered yet. extcon_get_extcon_dev() never returns EPROBE_DEFER so > checking for NULL seems to be the only way. Other drivers using that > function also do NULL check and return EPROBE_DEFER. Indeed, thanks for clarification. Looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel