From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30025C433E0 for ; Wed, 3 Feb 2021 09:57:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC6BA64E2A for ; Wed, 3 Feb 2021 09:57:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC6BA64E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yuHIYIFaNTnB3Hu2n7lBmKpSc2RLhc6EM8uiXPZk0yA=; b=wOHQF2qqcoPqAnDV4dipnIonR mdXzbqUiwabtnkDxu0e/0kylAnpRKd58WiGoeAfU99WINZjqe/4m5rijshMN9Wqb7+rLnhJf8hVIb +mBuaDBGlB4wAiaLIAjyV+Sn9UD5Qf34WSYP2r80E8KCFvIPIFQyjdUVIqKvL+fUSxOUqlnrXLaEI JmB0HhZ+5+43VOrs1cmdD8kevyVhDStd5Zb3up8+wmc+u8T6tOYsXxQ7A306IBlMYST2yluNseaBe SCxG57LxRVZDoU8636QZhgFYAR5ZE1zX0b/enBbWLjpSe3KwUfJTs7vRcn8SrXjqs5eaXIq505tz7 I+1tu6IBA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Etn-0007Vc-On; Wed, 03 Feb 2021 09:56:35 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Etl-0007VF-RC for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 09:56:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LiJKg6LMkdW0YhKsRsXBXwuS2q8By1oCeCz1N8/lnaA=; b=R0/SuHHhLG5oYgPYldlEYNUWy W3qWm0WhZDI3lIDjoPBtmhnLG6cH+hmYy59XqzyJ4yeYQ1f/bOgb+b41I0ihBqxuWyN0sR4pqhGt8 WmlreWXRyNq2kkcEO1qTG11SOUPS6Wd9FBHzI4LMHbTwwjds504rrKQNKrpK/2MT6TlTMgDAkQVew J9vIZr6qIkV2KhUcGQU9FsalD1UpI4ICvi+/Gz1MJ6jc1j7DeIX3ahiJF9oh4ZIQ94iCdxwajMjHp VJ9dWbs4fmxgPBHfhMVxnTqss+XUeD9kp8gs8JNnPIa20aoyoL/VZUY/RvVjfBg9ukuWbnc+aaYFJ yXphXqEgA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38584) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7Eth-0005RK-8V; Wed, 03 Feb 2021 09:56:29 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l7Etg-0003wo-Eo; Wed, 03 Feb 2021 09:56:28 +0000 Date: Wed, 3 Feb 2021 09:56:28 +0000 From: Russell King - ARM Linux admin To: Oleksij Rempel Subject: Re: [PATCH v1 5/7] ARM i.MX6q: remove Atheros AR8035 SmartEEE fixup Message-ID: <20210203095628.GP1463@shell.armlinux.org.uk> References: <20210203091857.16936-1-o.rempel@pengutronix.de> <20210203091857.16936-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210203091857.16936-6-o.rempel@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_045633_903643_172FAC06 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Fabio Estevam , Philippe Schenker , linux-imx@nxp.com, kernel@pengutronix.de, David Jander , Shawn Guo , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 03, 2021 at 10:18:55AM +0100, Oleksij Rempel wrote: > This fixup removes the Lpi_en bit. > > If this patch breaks functionality of your board, use following device > tree properties: > > ethernet-phy@X { > reg = <0xX>; > eee-broken-1000t; > eee-broken-100tx; > .... > }; That is the historical fix for this problem, but there is a better solution now in net-next - configuring the Tw parameter for gigabit connections. That solves the random link drop issue when EEE is enabled. Support for this configuration has only recently been merged into net-next and other trees for this merge window, so I ask that you hold off at least this patch until the next cycle. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel