From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3025FC433E0 for ; Wed, 3 Feb 2021 12:29:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A593564F84 for ; Wed, 3 Feb 2021 12:29:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A593564F84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g0JyU+Rmu69ZUx2yVsWgV107Nq2ETrCvvp0IqxTFd2g=; b=MFxjI1bG9ePdwNvwySf4D8NUD +TcOXP8Onmh8qQvlz+4GInvk66He/xXGuhksrPiwwfwGmLrq1W5BzEcCgg72GdyD40qm3FBcbBQVv 5DZaW2CO25PmUBGFGkrmqcHojQsVC7Su3DPZKXwo/WRr6ck3m1/wP0Fl3ZhpL8tYEyZktO5uK89XM +de+UbpV1Ks/t/vChfn8LSyHxxvtBkcJb6MowWPS946q9r1MxOsRduLfrMN6iWiTuHPrvMt5rihAM R6xm/vSNRivYqxvmgfKpS8JqwblCI3xc4o02ivLOV3lZcNnscao//3tlV49fq3qYEufG+Nx8Vtsjm IRshgUt5g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7HGx-0001Ww-9f; Wed, 03 Feb 2021 12:28:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7HGu-0001WV-S6 for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 12:28:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A236D6E; Wed, 3 Feb 2021 04:28:34 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.11.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE0CF3F73B; Wed, 3 Feb 2021 04:28:32 -0800 (PST) Date: Wed, 3 Feb 2021 12:28:29 +0000 From: Mark Rutland To: Joey Gouly Subject: Re: [PATCH 0/2] Introduce macros for the offsets to reserved_pg_dir and tramp_pg_dir Message-ID: <20210203122829.GE55896@C02TD0UTHF1T.local> References: <20210202123658.22308-1-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210202123658.22308-1-joey.gouly@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_072836_972054_F7037B83 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , nd@arm.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 02, 2021 at 12:36:56PM +0000, Joey Gouly wrote: > Make the offsets to reserved_pg_dir and tramp_pg_dir less fragile by > introducing macros that contain their offsets. > > Also use these macros to verify the offsets at link time. I like the idea, the implementation appears to be correct, both patches build and boot without issue, and if I mess with the offsets I get the expected warnings. So, for both patches: Reviewed-by: Mark Rutland Tested-by: Mark Rutland Mark. > > Joey Gouly (2): > arm64: vmlinux.ld.S: add assertion for reserved_pg_dir offset > arm64: vmlinux.ld.S: add assertion for tramp_pg_dir offset > > arch/arm64/include/asm/asm-uaccess.h | 4 ++-- > arch/arm64/include/asm/memory.h | 12 ++++++++++++ > arch/arm64/include/asm/uaccess.h | 2 +- > arch/arm64/kernel/entry.S | 4 ++-- > arch/arm64/kernel/vmlinux.lds.S | 8 ++++++++ > 5 files changed, 25 insertions(+), 5 deletions(-) > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel