From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADEEC433E6 for ; Wed, 3 Feb 2021 12:59:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B34F064D9D for ; Wed, 3 Feb 2021 12:59:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B34F064D9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X2fVoSvBk9xbmbTHKjrjD6W9vtdYlpCSfNdIFd2Eiok=; b=naeS4APySFc7GYGz9k78keTsq PAjEJFHAZVxr0xAC9Ckx8m2MzTZwG4w+6hQo4jh8MEp/3Aa8t4ovyoFuIw+uzMS1e8zckfezevpLE ixqle87s9Tf1Su5kDtfqJfG/aJ6DxC6/2oChbQYGBrmhHmdk0Xg0V2hnDx3vNNVEARpYo5cHe0d0R 2vb1McHQqmRX4jClkeP0LPWkg9u+P78pxh8SzV/EE87ZQhmm6gBvBwzSdlm6GxhM7SXJqYvjDw8sA QxG44E8K/8ozibfTzct7E18bEVX0+THSU09Jsgy1Bb1+I+UkeP2koODlliH3IW23jRMN8IE22uXTM b8efaFjOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Hjo-0005Xt-Oe; Wed, 03 Feb 2021 12:58:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7Hjk-0005X1-PR for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 12:58:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F25DD6E; Wed, 3 Feb 2021 04:58:22 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.11.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B32C13F73B; Wed, 3 Feb 2021 04:58:20 -0800 (PST) Date: Wed, 3 Feb 2021 12:58:18 +0000 From: Mark Rutland To: Shaokun Zhang Subject: Re: [PATCH v2 2/8] drivers/perf: hisi: Add PMU version for uncore PMU drivers. Message-ID: <20210203125818.GH55896@C02TD0UTHF1T.local> References: <1612338668-40493-1-git-send-email-zhangshaokun@hisilicon.com> <1612338668-40493-3-git-send-email-zhangshaokun@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1612338668-40493-3-git-send-email-zhangshaokun@hisilicon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_075825_614515_DFFCD7A9 X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qi Liu , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 03, 2021 at 03:51:02PM +0800, Shaokun Zhang wrote: > For HiSilicon uncore PMU, more versions are supported and some variables > shall be added suffix to distinguish the version which are prepared for > the new drivers. > > Cc: Mark Rutland > Cc: Will Deacon > Cc: John Garry > Cc: Jonathan Cameron > Reviewed-by: John Garry > Co-developed-by: Qi Liu > Signed-off-by: Qi Liu > Signed-off-by: Shaokun Zhang > --- > drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 97 ++++++++++++++------------- > drivers/perf/hisilicon/hisi_uncore_hha_pmu.c | 27 ++++---- > drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 24 +++---- > 3 files changed, 75 insertions(+), 73 deletions(-) [...] > diff --git a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c > index 831622e0c445..da56fa16b97e 100644 > --- a/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c > +++ b/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c > @@ -37,7 +37,7 @@ > > #define L3C_PERF_CTRL_EN 0x10000 > #define L3C_EVTYPE_NONE 0xff > - > +#define L3C_V1_NR_EVENTS 0x59 > /* > * Select the counter register offset using the counter index > */ I don't think you meant to remove the line space before the comment here. With that restored: Acked-by: Mark Rutland Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel