From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A325C433DB for ; Wed, 3 Feb 2021 13:11:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A01C664F72 for ; Wed, 3 Feb 2021 13:11:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A01C664F72 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TUWLllTQrmMI6KZ+0lNoUqpXafyqYW90hNpmPE/kp3E=; b=LZTH3Qi7cOEdfULFu7AnEKl7e oSwyRfPcN4P+9CGBKvvonkL4ZbDSCBjRTNANWkpDEpREN9VmYnetTBOhLAymWpB7MJn4vkw84nVS0 aYR0P4qvl+FnSeNmNQVwtDFs+/pzIqM9lCRjK50fQL1JCJsxmnA1j3DO4ONG/uaEZoBuE798UK111 WhNabKExg1hVjhX2tXFg6iEkZwYZ6kLkHuF8St37Ek9qKKphaLfQyLROsNPs7zSZueDiH+xUWpb6q uNfM98INPpsCyosgRGVx8GcJ9MRj98TGuw9EOhYbqokn6bYpoqHLdpuseU74xl2cdACNRGBFlAbUc JE2+VVB6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7HvD-00086f-5u; Wed, 03 Feb 2021 13:10:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7HvA-000865-F0 for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 13:10:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BFB5DD6E; Wed, 3 Feb 2021 05:10:10 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.11.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 436823F73B; Wed, 3 Feb 2021 05:10:09 -0800 (PST) Date: Wed, 3 Feb 2021 13:10:06 +0000 From: Mark Rutland To: Shaokun Zhang Subject: Re: [PATCH v2 3/8] drivers/perf: hisi: Add new functions for L3C PMU Message-ID: <20210203131006.GI55896@C02TD0UTHF1T.local> References: <1612338668-40493-1-git-send-email-zhangshaokun@hisilicon.com> <1612338668-40493-4-git-send-email-zhangshaokun@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1612338668-40493-4-git-send-email-zhangshaokun@hisilicon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_081012_574656_08A66A27 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qi Liu , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 03, 2021 at 03:51:03PM +0800, Shaokun Zhang wrote: > On HiSilicon Hip09 platform, some new functions are enhanced on L3C PMU, > like, tracetag feature that L3C PMU can only count the specified > operations by the user, or L3C PMU can give the desired core's statistics > in the cluster. > $# perf stat -a -e hisi_sccl3_l3c0/config=0x02,tt_core=0xf/ sleep 5 > > $# perf stat -a -e hisi_sccl3_l3c0/config=0x02,tt_req=0x4/ sleep 5 Are these values documented somewhere? [...] > +HISI_PMU_EVENT_ATTR_EXTRACTOR(tt_core, config1, 7, 0); > +HISI_PMU_EVENT_ATTR_EXTRACTOR(tt_req, config1, 10, 8); > +HISI_PMU_EVENT_ATTR_EXTRACTOR(datasrc_cfg, config1, 15, 11); > +HISI_PMU_EVENT_ATTR_EXTRACTOR(datasrc_skt, config1, 16, 16); Could you please mention all of these in the commit message? IIUC tt_core is a mask of physical cores in the cluster, and I guess tt_req is a request type, but I have no idea what the datasrc_cfg or datasrc_skt (socket?) fields represent. A rough description would be very helpful, something like: | We expose the tracetag filters with new fields exposed to userspace: | | * tt_core is a mask of cores within the PMU's cluster | * tt_req is ??? | * datasrc_cfg is ??? | * datasrc_skt is ??? Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel