From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6BEC433DB for ; Wed, 3 Feb 2021 13:19:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E290064E41 for ; Wed, 3 Feb 2021 13:19:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E290064E41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kbjdAcIsUmeak0d9+vK13M1PPzdWSdGy6oDJyN6UN5U=; b=Jdv9ukKijKUbCR4qTiDvzNHak YFXTal1GykUuFT85AQKQBTALtfv9147YUSquTHGuW+qz0RS+ww+EH7iGIBeOYKD3NVAH4nOXqm96x WSR5Ls2SycgtIV9ILVxxKJnbEYNgmJhGx41W0h3Q/NeOzrbn78YxTVix4x8Gj5DijlgJgCGXITnxR sKDjEsaJEwCSTXfWmZwn/dkGfbmPUy9VcCVd8EBwDllG8MSeiPYJjE0bK7c7ofpgHBlsNIvc8FKt5 JJ7HbKhjJdDi2lgc0yzNPKGKnoGyW8XxueQLsqt9ZpgrdQ3va1gTnIQVDEZGXpVdKCF+mTMuz4sHI lfd7rSMaA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7I3O-0000oM-28; Wed, 03 Feb 2021 13:18:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7I3L-0000nt-N8 for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 13:18:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 752DFD6E; Wed, 3 Feb 2021 05:18:37 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.11.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E03143F73B; Wed, 3 Feb 2021 05:18:35 -0800 (PST) Date: Wed, 3 Feb 2021 13:18:33 +0000 From: Mark Rutland To: Shaokun Zhang Subject: Re: [PATCH v2 4/8] drivers/perf: hisi: Add new functions for HHA PMU Message-ID: <20210203131833.GJ55896@C02TD0UTHF1T.local> References: <1612338668-40493-1-git-send-email-zhangshaokun@hisilicon.com> <1612338668-40493-5-git-send-email-zhangshaokun@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1612338668-40493-5-git-send-email-zhangshaokun@hisilicon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_081839_833904_2751A17E X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qi Liu , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 03, 2021 at 03:51:04PM +0800, Shaokun Zhang wrote: > On HiSilicon Hip09 platform, some new functions are also supported on > HHA PMU, it can filter gathered statistics by the Master ID and mask > from the SoC if the user wants to do deep-going profiling. > Tracetag support is also added with L3C PMU in the SoC system. > > $# perf stat -a -e hisi_sccl3_hha0/config=0x02,tracetag_en=0x1/ sleep 5 > > $# perf stat -a -e hisi_sccl3_hha0/config=0x02,srcid_cmd=0x1/ sleep 5 > > Much more introduction is added in documentation: > Documentation/admin-guide/perf/hisi-pmu.rst Could we please enumerate the relevant fields here, with a brief description? From a quick scan these are different to those added fo rthe L3C PMU. I appreciate the last partch in the series adds some documentation, but it'd be nice to have the context where it's needed. [...] > @@ -193,6 +304,22 @@ static int hisi_hha_pmu_init_data(struct platform_device *pdev, > dev_err(&pdev->dev, "Can not read hha sccl-id!\n"); > return -EINVAL; > } > + > + /* > + * Early versions of BIOS support _UID by mistake, so we support > + * both "hisilicon, idx-id" as preference, if availbale. Typo: s/availbale/available/ Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel