From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4227C433E0 for ; Thu, 4 Feb 2021 03:49:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 797BB64F59 for ; Thu, 4 Feb 2021 03:49:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 797BB64F59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GPHhJuQM+cxK1W5LTdkpeWvKz6wUDX4FLis+BNfeap4=; b=1cEfvF4O0v0/dQ+YsI1Qwp1IF 7QDoG28wjwL5Lbqm9XWH7jBQIFNr79MDc9sQUGgw8Fun8HHGcU+DjrQ+OTQdwSoO4yd3Ykaw1uhlf 7vr+/Rr1rEl8HNU3BV1u5MudcBQ3lWNeGiVSc8Rl5XfTYrV79BMrJTp56e1c+bXLbPS33+JsSdLsg 9zVFf1BpsNGSLd5XJgx044OPbRAEl4F6ME3aJHdG3ijsdYWE0P8s/p6LCJ7u71iZk2TjI9wDEL+Gg BvPFDAZ0apfDWkLFnh9I8nuDe+ZnPmBbCvy1mxNO62zzME6h8TDG326dzj6mmbIvZcSNMBe72vIL9 8rwwBfVLA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7VcZ-0008K2-VE; Thu, 04 Feb 2021 03:47:55 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7VcW-0008Jh-Ub for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 03:47:54 +0000 Received: by mail-pj1-x1032.google.com with SMTP id g15so985324pjd.2 for ; Wed, 03 Feb 2021 19:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lxTosy4uHVRCArCakSMPHANjiXYw+5Gg+jpL1TvuwWs=; b=teatPvBvE1gtUas0Geg1VbWrOQ06zF6QQMg2uh4ZkriNN6acOhyACe2qOz43vMV4e9 K/HSsiubH5Oxi+YePkXEQWUR7OS3ohfi2pXoODGQXBJz2A3djNR+6t6lXOcuiCKgyHj9 N2JFkSSteWlA2pMfnELR36j36+16rOf7BhtNCxXLidkUSssq56hKNDsJWe8yU38sdNBM 6Un1G7rRTCozVY3a2+fgiPcyL2Qh+R50i+T1Gh6GMMx+t/eS2lzUUPwkZ5/juX4wfUJF XpUoAZqekd1aSfQeoUqRvck65zSAh+igBDAoBDAYFQY7jlde3uvkdLgeU0QieJf+SMEK Pabw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lxTosy4uHVRCArCakSMPHANjiXYw+5Gg+jpL1TvuwWs=; b=apka6uiONnkqlXHg64pfu0jyimKlN3QnVtsHPTgfkW6pO4hEVTk8uuD3j2tkCWPDH2 hcVaGjL5x1LV0hzD2objLgL4FZgworm2EaLfa33Y6qrJMq6DZu8vdCGmW7y3o29J0XDU n2y1m6iE7gV49tF9jGa6fCpWE1iY0o7qku9i64gb0wnbg0kPDcmRNlPJAs69H8l6t0rh WY6XE/zkIR/htf0ZsRV5Km5zBUzuPIQDYDZivfnDe8T0jpEKxNn3/pI7M/0FiSd3cXwZ Gt86IdaWInc+ITdTGzR8mRMrEazNTFUY1gd40l+tE64vOlOYCgVPIJpD1mTI95uLjXCP KCcQ== X-Gm-Message-State: AOAM532aMV+DMBHV+aDWPxtzGv6cm4/MEGofpLcixkkbYgKVy9Wo6jqQ ey+D5Q9IfGFtoF2v5l1k+d9Oa2BZvHWVn3PG X-Google-Smtp-Source: ABdhPJyYqjq0wXET+c8P9dHdLXiI8pxSnGiuHxBOooXeX+K4VRxecAb6E7Uk30/522c4JNv8AOk4QA== X-Received: by 2002:a17:90a:6407:: with SMTP id g7mr6450168pjj.56.1612410470597; Wed, 03 Feb 2021 19:47:50 -0800 (PST) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id e20sm4357082pgr.48.2021.02.03.19.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 19:47:49 -0800 (PST) Date: Thu, 4 Feb 2021 11:47:43 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH v2 5/7] perf cs-etm: Add helper cs_etm__get_pid_fmt() Message-ID: <20210204034743.GE11059@leoy-ThinkPad-X240s> References: <20210202163842.134734-1-leo.yan@linaro.org> <20210202163842.134734-6-leo.yan@linaro.org> <51a1e845-f9a4-3c6e-88a2-c105f5b5adfe@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51a1e845-f9a4-3c6e-88a2-c105f5b5adfe@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_224753_097505_1A93DEDC X-CRM114-Status: GOOD ( 28.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Denis Nikitin , Mathieu Poirier , Jonathan Corbet , Alexander Shishkin , Jiri Olsa , coresight@lists.linaro.org, John Garry , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Daniel Kiss , Will Deacon , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 02, 2021 at 11:19:22PM +0000, Suzuki Kuruppassery Poulose wrote: > On 2/2/21 4:38 PM, Leo Yan wrote: > > This patch adds helper function cs_etm__get_pid_fmt(), by passing > > parameter "traceID", it returns the PID format. > > > > Signed-off-by: Leo Yan > > --- > > tools/perf/util/cs-etm.c | 43 ++++++++++++++++++++++++++++++++++++++++ > > tools/perf/util/cs-etm.h | 1 + > > 2 files changed, 44 insertions(+) > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > index a2a369e2fbb6..8194ddbd01e5 100644 > > --- a/tools/perf/util/cs-etm.c > > +++ b/tools/perf/util/cs-etm.c > > @@ -7,6 +7,7 @@ > > */ > > #include > > +#include > > #include > > #include > > #include > > @@ -156,6 +157,48 @@ int cs_etm__get_cpu(u8 trace_chan_id, int *cpu) > > return 0; > > } > > +/* > > + * The returned PID format is presented by two bits: > > + * > > + * Bit ETM_OPT_CTXTID: CONTEXTIDR or CONTEXTIDR_EL1 is traced; > > + * Bit ETM_OPT_CTXTID2: CONTEXTIDR_EL2 is traced. > > + * > > + * It's possible that these two bits are set together, this means the tracing > > + * contains PIDs for both CONTEXTIDR_EL1 and CONTEXTIDR_EL2. > > This is a bit confusing. If both the bits are set, the session > was run on an EL2 kernel. Thus, the PID is always in CONTEXTIDR_EL2. Sorry for confusion. I'd like to rephrase as: It's possible that the two bits ETM_OPT_CTXTID and ETM_OPT_CTXTID2 are enabled at the same time when the session runs on an EL2 kernel. This means the CONTEXTIDR_EL1 and CONTEXTIDR_EL2 both will be recorded in the trace data, the tool will selectively use CONTEXTIDR_EL2 as PID. > > + */ > > +int cs_etm__get_pid_fmt(u8 trace_chan_id, u64 *pid_fmt) > > +{ > > + struct int_node *inode; > > + u64 *metadata, val; > > + > > + inode = intlist__find(traceid_list, trace_chan_id); > > + if (!inode) > > + return -EINVAL; > > + > > + metadata = inode->priv; > > + > > + if (metadata[CS_ETM_MAGIC] == __perf_cs_etmv3_magic) { > > + val = metadata[CS_ETM_ETMCR]; > > + /* CONTEXTIDR is traced */ > > + if (val & BIT(ETM_OPT_CTXTID)) > > + *pid_fmt = BIT(ETM_OPT_CTXTID); > > + } else { > > + val = metadata[CS_ETMV4_TRCCONFIGR]; > > + > > + *pid_fmt = 0; > > + > > + /* CONTEXTIDR_EL2 is traced */ > > + if (val & (BIT(ETM4_CFG_BIT_VMID) | BIT(ETM4_CFG_BIT_VMID_OPT))) > > + *pid_fmt = BIT(ETM_OPT_CTXTID2); > > + > > + /* CONTEXTIDR_EL1 is traced */ > > + if (val & BIT(ETM4_CFG_BIT_CTXTID)) > > I haven't looked at how this gets used. But, Shouldn't this be : > > else if (val & BIT(ETM4_CFG_BIT_CTXTID)) ? Actually it's deliberately to set both bits ETM_OPT_CTXTID2 and ETM_OPT_CTXTID if user has enable configs "contextid1" and "contextid2". So this is exactly the reversed flow in the function cs_etmv4_get_config(). Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel