From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADDAC433DB for ; Thu, 4 Feb 2021 15:20:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4111D64F74 for ; Thu, 4 Feb 2021 15:20:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4111D64F74 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E8nMaCn0m7bIdN0jUsJ407W1mMUKZSo7iQIU2FfGia4=; b=LF049M9/TkFzWUl8EW2jSCIDl CKMz4X73goP78MIxkjrcmlX9y6/94Pm/ska3FVvN0TBL+DRaviXQDdFSF4RDXKi4i9H2pVIr4ihFL ZTNHFpd8LBdWv3HR7lloaEsG0x2SEj379IzKwFzJDUD0S/rbMahFooMeZ9t+puLHFn43pQPrie6lp 3jzUHxR8eyEL+MRts5UDADolkfXxL1ZgMHf0hQ47tRCxn0x2XTlh9t5RetuIy5b24uZCJ+pH5fBHO QT8+LRjRTjS8mg+nJdKu8ioSHHtOlkFYYKU9YtVLaB2TmU8bs6ziMcxUZ7PwmLqrp4tXWYz0wClyu wdV3LkEWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7gPB-00084e-0E; Thu, 04 Feb 2021 15:18:49 +0000 Received: from mail-ot1-f41.google.com ([209.85.210.41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7gP9-00083K-5c for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 15:18:48 +0000 Received: by mail-ot1-f41.google.com with SMTP id f6so3711473ots.9 for ; Thu, 04 Feb 2021 07:18:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RhsRUIY4PwSbVtlxeuMCCB1IWHFQpv1uTxQeDPLtde0=; b=tBd6hauvQLzmHYyQmUlCDq+dKFV27RksIzCoAJajEkCofSuv9uUYM5XO2+rWSgqxUI LQDsSamjJQWMgF/j4BnC+0IWsOOnnmXANfsKEYniTUCfEglkQioOf+RCpi5TAwsvQvB4 OVNqHVLDeLLFqBLdc1UMbc4M/Np8MWGdhvkbzF9dZXVxWGVw2/AX4vpBMP2j5wxKv5bk jjyvJ4gL31yxHioMr545JhJr4nN3/vas87shnTWZMH35Y2Up8idi0MBGYO3Vt7crbkVg LdMG4QNWPNpAjpFU//NwlHnV1YmU/YzzbhZErqOrjTMPuZ9zw5KOah1QlqH1K6qgmuw7 xitA== X-Gm-Message-State: AOAM531djY2HMSO81ul9EPoeR3GgxCvqBmaKOF/RanEgsKy9TM6Tj8nJ D/41AuGMHBcCtDp87Dgshg== X-Google-Smtp-Source: ABdhPJyf1i46goE7Fl0eVk0dbbaNifbkwfzIk+WyhbDrVANZ9G8qMNM+ovniEwivEV/H8Jt36ruZDA== X-Received: by 2002:a9d:61d0:: with SMTP id h16mr5897819otk.1.1612451920983; Thu, 04 Feb 2021 07:18:40 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t62sm1141712oif.2.2021.02.04.07.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 07:18:40 -0800 (PST) Received: (nullmailer pid 447920 invoked by uid 1000); Thu, 04 Feb 2021 15:18:38 -0000 Date: Thu, 4 Feb 2021 09:18:38 -0600 From: Rob Herring To: Will Deacon , Catalin Marinas , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , Mark Rutland Subject: Re: [PATCH v5 0/9] libperf and arm64 userspace counter access support Message-ID: <20210204151838.GF3706951@robh.at.kernel.org> References: <20210114020605.3943992-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210114020605.3943992-1-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_101847_225377_CB55BE0D X-CRM114-Status: GOOD ( 35.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ian Rogers , Alexander Shishkin , linux-kernel@vger.kernel.org, honnappa.nagarahalli@arm.com, Raphael Gault , Jonathan Cameron , Namhyung Kim , Itaru Kitayama , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 13, 2021 at 08:05:56PM -0600, Rob Herring wrote: > Hi all, > > Another version of libperf and arm64 userspace counter access support. > This originally resurrected Raphael's series[1] to enable userspace counter > access on arm64. My previous versions are here[2][3][4][5]. A git branch is > here[6]. Ping. Will, Mark, comments on the Arm bits? > > Changes in v5: > - Limit enabling/disabling access to CPUs associated with the PMU > (supported_cpus) and with the mm_struct matching current->active_mm. > The x86 method of using mm_cpumask doesn't work for arm64 as it is not > updated. > - Only set cap_user_rdpmc if event is on current cpu. See patch 2. > - Create an mmap for every event in an evsel. This results in some changes > to the libperf mmap API from the last version. > - Rebase to v5.11-rc2 > > Changes in v4: > - Dropped 'arm64: pmu: Add hook to handle pmu-related undefined instructions'. > The onus is on userspace to pin itself to a homogeneous subset of CPUs > and avoid any aborts on heterogeneous systems, so the hook is not needed. > - Make perf_evsel__mmap() take pages rather than bytes for size > - Fix building arm64 heterogeneous test. > > Changes in v3: > - Dropped removing x86 rdpmc test until libperf tests can run via 'perf test' > - Added verbose prints for tests > - Split adding perf_evsel__mmap() to separate patch > > > The following changes to the arm64 support have been made compared to > Raphael's last version: > > The major change is support for heterogeneous systems with some > restrictions. Specifically, userspace must pin itself to like CPUs, open > a specific PMU by type, and use h/w specific events. The tests have been > reworked to demonstrate this. > > Chained events are not supported. The problem with supporting chained > events was there's no way to distinguish between a chained event and a > native 64-bit counter. We could add some flag, but do self monitoring > processes really need that? Native 64-bit counters are supported if the > PMU h/w has support. As there's already an explicit ABI to request 64-bit > counters, userspace can request 64-bit counters and if user > access is not enabled, then it must retry with 32-bit counters. > > Prior versions broke the build on arm32 (surprisingly never caught by > 0-day). As a result, event_mapped and event_unmapped implementations have > been moved into the arm64 code. > > There was a bug in that pmc_width was not set in the user page. The tests > now check for this. > > The documentation has been converted to rST. I've added sections on > chained events and heterogeneous. > > The tests have been expanded to test the cycle counter access. > > Rob > > [1] https://lore.kernel.org/r/20190822144220.27860-1-raphael.gault@arm.com/ > [2] https://lore.kernel.org/r/20200707205333.624938-1-robh@kernel.org/ > [3] https://lore.kernel.org/r/20200828205614.3391252-1-robh@kernel.org/ > [4] https://lore.kernel.org/r/20200911215118.2887710-1-robh@kernel.org/ > [5] https://lore.kernel.org/r/20201001140116.651970-1-robh@kernel.org/ > [6] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git user-perf-event-v5 > > > Raphael Gault (3): > arm64: pmu: Add function implementation to update event index in > userpage > arm64: perf: Enable PMU counter direct access for perf event > Documentation: arm64: Document PMU counters access from userspace > > Rob Herring (6): > tools/include: Add an initial math64.h > libperf: Add evsel mmap support > libperf: tests: Add support for verbose printing > libperf: Add support for user space counter access > libperf: Add arm64 support to perf_mmap__read_self() > perf: arm64: Add test for userspace counter access on heterogeneous > systems > > Documentation/arm64/index.rst | 1 + > .../arm64/perf_counter_user_access.rst | 56 ++++++ > arch/arm64/include/asm/mmu.h | 5 + > arch/arm64/include/asm/mmu_context.h | 2 + > arch/arm64/include/asm/perf_event.h | 14 ++ > arch/arm64/kernel/perf_event.c | 68 +++++++ > include/linux/perf/arm_pmu.h | 2 + > tools/include/linux/math64.h | 75 +++++++ > tools/lib/perf/Documentation/libperf.txt | 2 + > tools/lib/perf/evsel.c | 50 ++++- > tools/lib/perf/include/internal/evsel.h | 2 + > tools/lib/perf/include/internal/mmap.h | 3 + > tools/lib/perf/include/internal/tests.h | 32 +++ > tools/lib/perf/include/perf/evsel.h | 2 + > tools/lib/perf/libperf.map | 2 + > tools/lib/perf/mmap.c | 186 ++++++++++++++++++ > tools/lib/perf/tests/Makefile | 6 +- > tools/lib/perf/tests/test-evsel.c | 65 ++++++ > tools/perf/arch/arm64/include/arch-tests.h | 7 + > tools/perf/arch/arm64/tests/Build | 1 + > tools/perf/arch/arm64/tests/arch-tests.c | 4 + > tools/perf/arch/arm64/tests/user-events.c | 170 ++++++++++++++++ > 22 files changed, 751 insertions(+), 4 deletions(-) > create mode 100644 Documentation/arm64/perf_counter_user_access.rst > create mode 100644 tools/include/linux/math64.h > create mode 100644 tools/perf/arch/arm64/tests/user-events.c > > -- > 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel