From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861ADC433E0 for ; Fri, 5 Feb 2021 01:10:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 169BA64F95 for ; Fri, 5 Feb 2021 01:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 169BA64F95 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n9ej5CdPsod4kEb+tL6l/P+xgYLOxFMTKlYLCS272Ag=; b=AUP7CXlwE+eW/EvKiowQWTlTM HZXFPo7rHY0LHnyO4xBW9l4jlftHZEZroIFAC56bzO+2kTrKalBDIeXGaJqLNy7fDrilmltfhL++x wl/Yz9Pet269EDFyvvgEvmhzlvunANZFgvatgFOIInEyggSnUsWnDqO8YfhQvIT9MAGte4rNX6hQe 4VhNydUOEot5MAAVqo/lLo/YfkGt/m3HTJdh6W2MjIxLOJuqtosmKP3bujRBWEnqZ40AZVWZiPmW1 29cau8oyB693JEG6JBhhzw4OKJC0axslNHSiEpYDC3raJRXT93+q8pkdV5fSEl/ycBPR+LaKha1Du DSKl9vJMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7pcH-0003HN-Ie; Fri, 05 Feb 2021 01:08:57 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7pcF-0003H3-1K for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 01:08:56 +0000 IronPort-SDR: efat4+DS1Wn6u2Chsulpi9kNr4F4pFhZAxEhbxqPbbk8uta8quqeGk5/OWmjOLsl7Gxmt7KFk8 v2S8XVmOvEXw== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="200356146" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="200356146" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 17:08:49 -0800 IronPort-SDR: rSfRk5qnf8S7RAXfEShK9dRTrJv8e2F2Uvfi8eVy379xAp/EEV6qVAXAJ39lCYB+uOohpQ5kLa 1y52B6iOCZvg== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="393623628" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.188.246]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 17:08:49 -0800 Date: Thu, 4 Feb 2021 17:08:48 -0800 From: Jesse Brandeburg To: Song Yoong Siang Subject: Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS Message-ID: <20210204170848.00000aff@intel.com> In-Reply-To: <1612447396-20351-1-git-send-email-yoong.siang.song@intel.com> References: <1612447396-20351-1-git-send-email-yoong.siang.song@intel.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_200855_230507_49B9ABB6 X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , Voon Wei Feng , Wong Vee Khee , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Gomes Vinicius , Jose Abreu , Maxime Coquelin , Jakub Kicinski , Ong Boon Leong , Giuseppe Cavallaro , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Song Yoong Siang wrote: > From: Mohammad Athari Bin Ismail > > When disable CBS, mode_to_use parameter is not updated even the operation > mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore, > when tc_setup_cbs() function is called to re-enable CBS, the operation > mode of Tx Queue remains at DCB, which causing CBS fails to work. > > This patch updates the value of mode_to_use parameter to MTL_QUEUE_DCB > after operation mode of Tx Queue is changed to DCB in stmmac_dma_qmode() > callback function. > > Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC") > Suggested-by: Gomes, Vinicius > Signed-off-by: Mohammad Athari Bin Ismail > Signed-off-by: Song, Yoong Siang Reviewed-by: Jesse Brandeburg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel