From: Will Deacon <will@kernel.org>
To: Steven Price <steven.price@arm.com>
Cc: Mark.Rutland@arm.com, jianyong.wu@arm.com, justin.he@arm.com,
kvm@vger.kernel.org, suzuki.poulose@arm.com,
Marc Zyngier <maz@kernel.org>,
richardcochran@gmail.com, seanjc@google.com,
linux-kernel@vger.kernel.org, Andre.Przywara@arm.com,
netdev@vger.kernel.org, john.stultz@linaro.org,
yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, Steve.Capper@arm.com
Subject: Re: [PATCH v17 1/7] arm/arm64: Probe for the presence of KVM hypervisor
Date: Fri, 5 Feb 2021 11:19:22 +0000 [thread overview]
Message-ID: <20210205111921.GA22109@willie-the-truck> (raw)
In-Reply-To: <d5765ade-7199-2d1e-6d59-d3de6a52c6ce@arm.com>
On Fri, Feb 05, 2021 at 09:11:00AM +0000, Steven Price wrote:
> On 02/02/2021 14:11, Marc Zyngier wrote:
> > diff --git a/drivers/firmware/smccc/kvm_guest.c b/drivers/firmware/smccc/kvm_guest.c
> > new file mode 100644
> > index 000000000000..23ce1ded88b4
> > --- /dev/null
> > +++ b/drivers/firmware/smccc/kvm_guest.c
> > @@ -0,0 +1,51 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +#define pr_fmt(fmt) "smccc: KVM: " fmt
> > +
> > +#include <linux/init.h>
> > +#include <linux/arm-smccc.h>
> > +#include <linux/kernel.h>
> > +#include <linux/string.h>
> > +
> > +static DECLARE_BITMAP(__kvm_arm_hyp_services, ARM_SMCCC_KVM_NUM_FUNCS) __ro_after_init = { };
> > +
> > +void __init kvm_init_hyp_services(void)
> > +{
> > + int i;
> > + struct arm_smccc_res res;
> > +
> > + if (arm_smccc_1_1_get_conduit() != SMCCC_CONDUIT_HVC)
> > + return;
> > +
> > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_CALL_UID_FUNC_ID, &res);
> > + if (res.a0 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_0 ||
> > + res.a1 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_1 ||
> > + res.a2 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_2 ||
> > + res.a3 != ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_3)
> > + return;
> > +
> > + memset(&res, 0, sizeof(res));
> > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_FEATURES_FUNC_ID, &res);
> > + for (i = 0; i < 32; ++i) {
> > + if (res.a0 & (i))
> > + set_bit(i + (32 * 0), __kvm_arm_hyp_services);
> > + if (res.a1 & (i))
> > + set_bit(i + (32 * 1), __kvm_arm_hyp_services);
> > + if (res.a2 & (i))
> > + set_bit(i + (32 * 2), __kvm_arm_hyp_services);
> > + if (res.a3 & (i))
> > + set_bit(i + (32 * 3), __kvm_arm_hyp_services);
>
> The bit shifts are missing, the tests should be of the form:
>
> if (res.a0 & (1 << i))
>
> Or indeed using a BIT() macro.
Maybe even test_bit()?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-05 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 14:11 [PATCH v17 0/7] KVM: arm64: Add host/guest KVM-PTP support Marc Zyngier
2021-02-02 14:11 ` [PATCH v17 1/7] arm/arm64: Probe for the presence of KVM hypervisor Marc Zyngier
2021-02-05 9:11 ` Steven Price
2021-02-05 11:19 ` Will Deacon [this message]
2021-02-05 11:23 ` Marc Zyngier
2021-02-05 16:50 ` Marc Zyngier
2021-02-05 17:00 ` Will Deacon
2021-02-02 14:11 ` [PATCH v17 2/7] KVM: arm64: Advertise KVM UID to guests via SMCCC Marc Zyngier
2021-02-02 14:12 ` [PATCH v17 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent Marc Zyngier
2021-02-02 14:12 ` [PATCH v17 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot Marc Zyngier
2021-02-02 14:12 ` [PATCH v17 5/7] clocksource: Add clocksource id for arm arch counter Marc Zyngier
2021-02-02 14:12 ` [PATCH v17 6/7] KVM: arm64: Add support for the KVM PTP service Marc Zyngier
2021-02-02 14:12 ` [PATCH v17 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205111921.GA22109@willie-the-truck \
--to=will@kernel.org \
--cc=Andre.Przywara@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Steve.Capper@arm.com \
--cc=jianyong.wu@arm.com \
--cc=john.stultz@linaro.org \
--cc=justin.he@arm.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=richardcochran@gmail.com \
--cc=seanjc@google.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox