From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEEF9C433E0 for ; Fri, 5 Feb 2021 22:36:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7480C64FAE for ; Fri, 5 Feb 2021 22:36:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7480C64FAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1HLWO4FeWSqYrlaakxQAOugqRkyaASe5kBQboGB7Q2I=; b=HU3MX5iwOBkoRV/DZ1xhj9752 fBsKaZxX/itosU1yn2zwWe5YDdRdUPWPRm5ybbMUEAB5YAFEji7RsHLXW7DymrV/ncneo7VNTOD9o D0qDEeRMI0ye4AmsUMn8+461HYeD+9JyNGZJUaKKH+TpixRDkjwJEf9J9aE3h7E3y1kK1zhUamGQw pc4bVv449KZK36djlyLZa9+FRzSWzvGR8QGXEyeMrvYP/BAyP1/3qSsO5vMpUmYkdrJFrmd4b+4T2 QQiwm/0SI1K0UG/IkBmfFQ3mopXLEDJLnDFNq+aYmftBnZZaYpAg7ROZaUp5hYx8lws4CoxjohU5Z dJvM12rWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l89hN-0004wS-Ma; Fri, 05 Feb 2021 22:35:33 +0000 Received: from mail-ot1-f47.google.com ([209.85.210.47]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l89hL-0004w6-6L for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 22:35:32 +0000 Received: by mail-ot1-f47.google.com with SMTP id k25so6334634otb.4 for ; Fri, 05 Feb 2021 14:35:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N/44ej6j4UuVwqBrJ6twQtXNQW2Tr20mLuJV3JZRN5A=; b=oUtQdOU7KhWAukQ0U68aT00ITBx4rhzTKilZBRulmaWOJWNErMWWzTh7V0rwd9HiC1 p0EG09ZW8QvfFXDFot0gFh7+HQ1mUC/fBVbBubEM/2rWA6dyK6StIssqeAR4gQcka+lH 4BKAknO74ehBeafUERZ2hcBfC/pzjTvJbdm96sNuRqrxngcsqHLqeXzIf7l/fCU8xB35 cxG3gnjfNhaq5JMvndJ1+oMDCW3NjSXJ6Abqrz9Si0P8sRtgtwLiJLy1UaKF7tsUzpK8 ITbeZb9ZW381o4WpaXR69us+jQLpAVhWmn9X9FR5TvGE+YpLj8vZOLmaizE1zyiKFE0M b2qg== X-Gm-Message-State: AOAM531PyBnP0HqtLNgZD+o1/cnZeW21nupVgS6KK3CbNTC1dz6Q42uk taX925o2BCR/CSdK8PcPRQ== X-Google-Smtp-Source: ABdhPJziqTqsYFOgzP6jVWyDWaLupnP8jgUARfZkx1WuuMbtUtiadqQGBejvB0Mmet9VWnU9WeJnQg== X-Received: by 2002:a05:6830:1bc9:: with SMTP id v9mr2320019ota.106.1612564528471; Fri, 05 Feb 2021 14:35:28 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y24sm2094268oos.44.2021.02.05.14.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 14:35:27 -0800 (PST) Received: (nullmailer pid 3880904 invoked by uid 1000); Fri, 05 Feb 2021 22:35:26 -0000 Date: Fri, 5 Feb 2021 16:35:26 -0600 From: Rob Herring To: Steen Hegelund Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver Message-ID: <20210205223526.GA3869001@robh.at.kernel.org> References: <20210120081921.3315847-1-steen.hegelund@microchip.com> <20210120081921.3315847-4-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210120081921.3315847-4-steen.hegelund@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210205_173531_295532_F54AE3A8 X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , devicetree@vger.kernel.org, Gregory Clement , linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Philipp Zabel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote: > This provides reset driver support for the Microchip Sparx5 PCB134 and > PCB135 reference boards. This isn't a compatible change. You need an explanation why that's okay if that's intended. > > Signed-off-by: Steen Hegelund > --- > arch/arm64/boot/dts/microchip/sparx5.dtsi | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi > index 380281f312d8..4edbb9fcdce0 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > @@ -132,9 +132,17 @@ mux: mux-controller { > }; > }; > > - reset@611010008 { > - compatible = "microchip,sparx5-chip-reset"; > - reg = <0x6 0x11010008 0x4>; > + gcb_ctrl: syscon@611010000 { > + compatible = "microchip,sparx5-gcb-syscon", "syscon"; > + reg = <0x6 0x11010000 0x10000>; > + }; > + > + reset: reset-controller@0 { > + compatible = "microchip,sparx5-switch-reset"; > + reg = <0x6 0x0 0x0>; Your register length is 0? > + #reset-cells = <1>; > + cpu-syscon = <&cpu_ctrl>; Can't you accomplish the same thing adding these to "microchip,sparx5-chip-reset"? Or possibly as a child node. Define nodes based on h/w blocks, not as containers of things you happen to want for some driver. > + gcb-syscon = <&gcb_ctrl>; > }; > > uart0: serial@600100000 { > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel