From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169FCC433E0 for ; Tue, 9 Feb 2021 02:00:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB8F764EB4 for ; Tue, 9 Feb 2021 02:00:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB8F764EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tOPC9m9OlGFsKVdIj+VKFm0Jxyaq3wks9IhII0yeqME=; b=oeyKeDhaZYpLdwsvCRvQQNbuW nY69oS6B04Hi6vIurJ5SYH+aBRP1//ATgfFynmB1uvQHXEhu6w2k025P6XgWxmWbmo2Q9NLj4In8e k0VTSWZWp4HmW5skzuy2uedgMojV/Qk/daqDkENQntc6Om5O/HDY304nD+qW5ZRCSIywsuAXFzHAx /IAkmct1na33c44U2mR9iN2027U/yYqB+U1Mt8v/cd/ivwG0O9xfCYIuMGX0E7S/idB9sukQxlohh 7abNFhBcxagEsqpz10g4jTBMD/pof+x8yMvRZPv7PnYmSa2+TiGQh0YFzDcDXznXY+kpAWsRj6OtA IXNfeIpUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9IJA-0007VV-Lk; Tue, 09 Feb 2021 01:59:16 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9IJ6-0007Uf-7Q for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 01:59:15 +0000 Received: by mail-pj1-x1030.google.com with SMTP id t2so727565pjq.2 for ; Mon, 08 Feb 2021 17:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IfhGG5EFiF0+GV+cXx/c1hFmnHr7EDLtq1/XLJ8Wrqw=; b=Jb86j9QXa47sQXQPZMFKIS6GO/j/tpp7DNNjLp7FiLlvZfMGz2BF8Y9cWJgnmPGEyf RKPyfFKtylW0GKsgl/J43mzsL9rO4f7WcGzQkFTz6iwMs5kYT4oisj3encefwLZfyl+9 MmFRqGbdc2eyEWr19Le16H1qVZrIC518kjatEDtY0Kplu8XhMzGxrIYEc5DEiAK+gbpn 0FjmJpcbshb55HO403qGIPNSx8iCYU536AabTz+HniBQh7Ju/Pv8m5mSALtV5M6PC+rM hY2Z/vtbWSQHThyOOWRP8S9YwQe1Dsw2DgMjUXXbBw+mYwpVlrhSVuV3qxrNSZr24Rz8 TTEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IfhGG5EFiF0+GV+cXx/c1hFmnHr7EDLtq1/XLJ8Wrqw=; b=C4NrW1rNn1rXU7B6Admg94kWPvaFEzFDsSHhbUgzekOXQJdw3fO/ixbGOVDfiyTq4+ PYBSvqeaYTszy3XmnBUts5FsSzNRPH9XEcu8iPXKaNLD5OzYzwW1veXzGKYeiohy9W6m vNOqYofIuvI0jwrivUpykPfpDpQcu//GGpW8lTdpT9V7lFdxg6DILQuGZTbddDyGuHLS ZXilIJUvf2hwR9Us2HcsxvyjySguNAUmKdhVG93OPI0jLsxdrdb2TCxjPhlv28o7jD24 Czm0U7vmrwG95g00nSPXnA5VKBs91JbBJVGm5RYdAf3s+OcM/1aW6iE7Wy3h3DvPHEd9 3kdA== X-Gm-Message-State: AOAM532norhv9JGTy+nDgsYqiXOulsk8P6Gwt6O2CCyDAm9rzk66VFf0 91ucXAoqh6tPpefyHCDEcxnjZw== X-Google-Smtp-Source: ABdhPJwilBT/p4PwScBoN7sJjtCO4XCBK8l7i0c62IBmgxUh2caNLJYPIxyvl5DOanOztniAJyYOVA== X-Received: by 2002:a17:903:2305:b029:df:c991:8c49 with SMTP id d5-20020a1709032305b02900dfc9918c49mr19696460plh.8.1612835948392; Mon, 08 Feb 2021 17:59:08 -0800 (PST) Received: from leoy-ThinkPad-X240s ([198.44.243.100]) by smtp.gmail.com with ESMTPSA id h10sm19090046pfn.213.2021.02.08.17.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 17:59:07 -0800 (PST) Date: Tue, 9 Feb 2021 09:58:55 +0800 From: Leo Yan To: Mathieu Poirier Subject: Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Message-ID: <20210209015855.GA54680@leoy-ThinkPad-X240s> References: <20210206150833.42120-1-leo.yan@linaro.org> <20210206150833.42120-5-leo.yan@linaro.org> <20210208204641.GE2077938@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208204641.GE2077938@xps15> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_205912_597340_8878061D X-CRM114-Status: GOOD ( 25.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Al Grant , Denis Nikitin , Jonathan Corbet , Peter Zijlstra , Jiri Olsa , coresight@lists.linaro.org, John Garry , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Namhyung Kim , Daniel Kiss , Will Deacon , Suzuki K Poulose , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > From: Suzuki K Poulose > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongly > > takes these two values (14 and 28 prespectively) as bit masks, but > > actually both are the offset for bits. But this doesn't lead to > > further failure due to the AND logic operation will be always true for > > ETM_OPT_CTXTID / ETM_OPT_TS. > > > > This patch defines new independent macros (rather than using the > > "config" bits) for requesting the "contextid" and "timestamp" for > > cs_etm_set_option(). > > > > [leoy: Extract the change as a separate patch for easier review] > > This should go just above your name - see below. > > > Signed-off-by: Suzuki K Poulose > > Signed-off-by: Leo Yan > > Reviewed-by: Mike Leach > > Signed-off-by: Suzuki K Poulose > [Extract the change as a separate patch for easier review] > Signed-off-by: Leo Yan > Reviewed-by: Mike Leach > > > --- > > tools/perf/arch/arm/util/cs-etm.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > > index bd446aba64f7..c25c878fd06c 100644 > > --- a/tools/perf/arch/arm/util/cs-etm.c > > +++ b/tools/perf/arch/arm/util/cs-etm.c > > @@ -156,6 +156,10 @@ static int cs_etm_set_timestamp(struct auxtrace_record *itr, > > return err; > > } > > > > +#define ETM_SET_OPT_CTXTID (1 << 0) > > +#define ETM_SET_OPT_TS (1 << 1) > > +#define ETM_SET_OPT_MASK (ETM_SET_OPT_CTXTID | ETM_SET_OPT_TS) > > + > > I would much rather see this fixed with the BIT() macro as it is done in the > rest of this set than defining new constant. > > With the above: > > Reviewed-by: Mathieu Poirier > > I have picked up the kernel portion of this set. I suggest you fix the above > and send another revision to Arnaldo with my RBs. Will do this. Thanks for suggestion, Mathieu. Leo [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel