From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A0B3C433DB for ; Tue, 9 Feb 2021 16:33:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B30A564EBD for ; Tue, 9 Feb 2021 16:33:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B30A564EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g4UuUpEXm73gv0aU9udO763JZwAIIX4te6PyFpR6+VM=; b=D5+NpSF1z5+tD1UVSS/FSd7LE 3IdiH39o/axgZ3eqfS8axtLubzXU4k7ZlI75gkXhKyboIj5mHBNQXyWaNEGIIUjRU/COu+HQpkpYz Gw84rDzNPODXP/wiSq0UCJx719hANYLHuVeuO0LnBwMoVBsi1xaqJElRl9V3W2Q14kJ8sR1K3HHJy Z4fROyEM2FbYTEATI5aCZ9Ba9N7eQTzwUBHZRXpx3yTwChXWyqLK4M82J/ladDGRDWufrh8qIzs8y mF5xwFh1Ma7DKDHkH1H9zD8MS0NyprxC6we81ILyUZ+4h/v+FNjlHjwkrqwj+IaFmVjToOBWXiUnB 6tmXpa8lA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Vw1-00086L-TA; Tue, 09 Feb 2021 16:32:17 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Vvx-0007QG-Qe for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 16:32:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4Q76uyk/WNLu+okIwMR533vp5djZ2HubZsZ+BU+VNzg=; b=Vq8qRAo+nBrkQ36LQMq0Z3WnL mpwmoMltr9YufXCh0iC19LIpUopu4ukW9Cd16yKRcoKO+xs1toycZuNtDaI37CJW0BEJcF+5rrulK BaHBlPhZeqhhFR7wcmHvxiTGggsibheV9hUq+RSRATx9puYe+qpGsLLRODH8deLrlPvIp3Vdmed+d e0rSDY8Fat5u8s98M4DMHF0Ab3qMQtCJA0YPjMd5yHur7CaI93pK4HAevW58XMoFMpD/U3J3e0+Tm n0MTxRdH75MZ+s8Up6shcY1lc/gKpam0exQ7Q7nue2V0AgKY3NAweHUHuxrUtm8ZhTV4znLpZQBgV dRxenOULA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41248) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Vsp-0003dp-0w; Tue, 09 Feb 2021 16:28:59 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l9Vsm-0004Ct-2h; Tue, 09 Feb 2021 16:28:56 +0000 Date: Tue, 9 Feb 2021 16:28:56 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Subject: Re: [PATCH v11 net-next 15/15] net: mvpp2: add TX FC firmware check Message-ID: <20210209162855.GQ1463@shell.armlinux.org.uk> References: <1612860151-12275-1-git-send-email-stefanc@marvell.com> <1612860151-12275-16-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1612860151-12275-16-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_113213_879320_A46C9D15 X-CRM114-Status: UNSURE ( 9.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, ymarkman@marvell.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, atenart@kernel.org, linux-kernel@vger.kernel.org, nadavh@marvell.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com, davem@davemloft.net, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 09, 2021 at 10:42:31AM +0200, stefanc@marvell.com wrote: > if (priv->global_tx_fc && priv->hw_version != MVPP21) { > - val = mvpp2_cm3_read(priv, MSS_FC_COM_REG); > - val |= FLOW_CONTROL_ENABLE_BIT; > - mvpp2_cm3_write(priv, MSS_FC_COM_REG, val); > + err = mvpp2_enable_global_fc(priv); > + if (err) { > + dev_warn(&pdev->dev, "CM3 firmware not running, version should be higher than 18.09 "); > + dev_warn(&pdev->dev, "and chip revision B0\n"); > + dev_warn(&pdev->dev, "Flow control not supported\n"); I would much rather this was: dev_warn(&pdev->dev, "Minimum of CM3 firmware 18.09 and chip revision B0 required for flow control\n"); rather than trying to split it across several kernel messages. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel