From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF76DC433DB for ; Tue, 9 Feb 2021 17:04:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BCD964E31 for ; Tue, 9 Feb 2021 17:04:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BCD964E31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JIpNUSX/fQvYJEsJvw95V/IRiwYNq0Wd/rvdKB44juw=; b=bW6kh6fWA2Aw7uen6WHzquu65 F4m4tp0MoFCk0u774NcXOyyVp583C24iIyjJ5FxDmNmNZvGPENhnYza6YYQPxEEKnvA2+H16apzT+ /nvrMctY5kxZsjnXyetAnnsSTH3t6QrXOdgGkiIyEhg9si9mmlpqpB5z8EQc2uXI/QGg1yTo+v58O Y7L0BBKgnf0A77YtaTWx7uSy2qIjfryfK/BnHyoraFg/6sQtgyNQa7CCy0Dq8lM0yPCF/ZqjeANFC VMsMsV72iUyyMPUpV6DMcA45zZnGdZcjWPkHnkSrUo4lXgGrYWwr4Of9WrP25ItjZC96FSklQ/hrs 2HkAei79g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9WPp-0003aT-Oq; Tue, 09 Feb 2021 17:03:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9WPm-0003ZS-TL for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 17:03:03 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CAB0764E31; Tue, 9 Feb 2021 17:02:58 +0000 (UTC) Date: Tue, 9 Feb 2021 17:02:56 +0000 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH mm] arm64: kasan: fix MTE symbols exports Message-ID: <20210209170255.GG1435@arm.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_120303_033318_7287A4AD X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 09, 2021 at 04:32:30PM +0100, Andrey Konovalov wrote: > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index a66c2806fc4d..788ef0c3a25e 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -113,13 +113,17 @@ void mte_enable_kernel(void) > sysreg_clear_set(sctlr_el1, SCTLR_ELx_TCF_MASK, SCTLR_ELx_TCF_SYNC); > isb(); > } > +#if IS_ENABLED(CONFIG_KASAN_KUNIT_TEST) > EXPORT_SYMBOL_GPL(mte_enable_kernel); > +#endif > > void mte_set_report_once(bool state) > { > WRITE_ONCE(report_fault_once, state); > } > +#if IS_ENABLED(CONFIG_KASAN_KUNIT_TEST) > EXPORT_SYMBOL_GPL(mte_set_report_once); > +#endif Do we actually care about exporting them when KASAN_KUNIT_TEST=n? It looks weird to have these #ifdefs in the arch code. Either the arch-kasan API requires these symbols to be exported to modules or not. I'm not keen on such kasan internals trickling down into the arch code. If you don't want to export them in the KASAN_KUNIT_TEST=n case, add a wrapper in the kasan built-in code (e.g. kasan_test_enable_tagging, kasan_test_set_report_once) and conditionally compile them based on KASAN_KUNIT_TEST. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel