From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D42DC433E0 for ; Tue, 9 Feb 2021 19:02:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AC0164E56 for ; Tue, 9 Feb 2021 19:02:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AC0164E56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dZ4yt0v95PQJdM/rCj5nkNMMFLeYYoVfLY60h322b44=; b=nld5Ffj49quptdoJcRKcYyROS 8+VxKlkm1h3VhpfbOIdLfyvTla7mEowY82UDp4swDApOHJ9+7xjGzp3GXO1KWCiYXK3G4d38Npipm jZLzOcuzndWyS6morudEyX1DJws+D3g3PSradpZvnPPPxWCpREtSc5yTzzURjZEfnMeSVosZdbxK9 QRT6Ue0LJTEpw/94Rx05cZcCMD/q5H+9LgE4xKUK620ab4zwapmqIYo5qI9COJKi+kfqDhhTXGItr vhnRkS4Cj3lS5LV0CTEK98m3pylNowmGTBAnqXh+ldJCszULMHPgyj6oBik3sQCjDFLeTtnbSdL11 rdPyH+Sdw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9YFY-0002ni-Jj; Tue, 09 Feb 2021 19:00:36 +0000 Received: from mail-oi1-f178.google.com ([209.85.167.178]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9YFW-0002nB-0R for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 19:00:35 +0000 Received: by mail-oi1-f178.google.com with SMTP id d20so20541460oiw.10 for ; Tue, 09 Feb 2021 11:00:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1pFQxRqA7pwwbpDRPrTabjXC5pKxQglsd9mMJ/rVkfA=; b=K1AakqZ+o+t5c0V+tYdLjzm0sXC7yeXyXPfKb4TJNx8531RmmJJpxG+SB2x5zHfnc6 hwY7QsDxi8Ly057ghngIhKtx2upVMIOHhCmJDIMG5UASP1bloWRu9rZe2aGLa9kWa3U+ NyC7dt/EI4xvGcX21p9XMsq9nDdAbX/2JT+c7q+QSy4w8S6pskNyQAhLCSGsQUn7vOAp 3fo+1dAUYEFuuTXgy29xfwaXZMDuOfz2HMlJ764FnljfKsPPEj7zSky8PQ2h0EbcIpdJ mc6jl1nnPAKWPuhO3YtpXNPjo/mbRQb7ZdBQ6Xjb9PBlJlDyahhGWOJKsBlIJAzXymi3 MvdQ== X-Gm-Message-State: AOAM530jB4+DPIiWN9cFO1/nIVsL3xIMTGsDVth+vnty1CL7RCbaWfMY Vk7NDx78uWd4+AGcJqGymA== X-Google-Smtp-Source: ABdhPJzXDZLzbrCk09AaBERqSNisnXCLkNA0Hm1UCP6W7w4JBoDw6xivdV4L/wUJtJTwvoiX6lMWOg== X-Received: by 2002:aca:d14:: with SMTP id 20mr3633257oin.157.1612897233375; Tue, 09 Feb 2021 11:00:33 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y10sm2197802otq.71.2021.02.09.11.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 11:00:32 -0800 (PST) Received: (nullmailer pid 4153442 invoked by uid 1000); Tue, 09 Feb 2021 19:00:31 -0000 Date: Tue, 9 Feb 2021 13:00:31 -0600 From: Rob Herring To: Anshuman Khandual Subject: Re: [PATCH V3 06/14] dts: bindings: Document device tree bindings for ETE Message-ID: <20210209190031.GA4102836@robh.at.kernel.org> References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-7-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1611737738-1493-7-git-send-email-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_140034_130742_7ABD6169 X-CRM114-Status: GOOD ( 24.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lcherian@marvell.com, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 27, 2021 at 02:25:30PM +0530, Anshuman Khandual wrote: > From: Suzuki K Poulose > > Document the device tree bindings for Embedded Trace Extensions. > ETE can be connected to legacy coresight components and thus > could optionally contain a connection graph as described by > the CoreSight bindings. > > Cc: devicetree@vger.kernel.org > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Rob Herring > Signed-off-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual > --- > Changes in V3: > > - Fixed all DT yaml semantics problems > > Documentation/devicetree/bindings/arm/ete.yaml | 74 ++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/ete.yaml > > diff --git a/Documentation/devicetree/bindings/arm/ete.yaml b/Documentation/devicetree/bindings/arm/ete.yaml > new file mode 100644 > index 0000000..edc1fe2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/ete.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +# Copyright 2021, Arm Ltd > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/arm/ete.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: ARM Embedded Trace Extensions > + > +maintainers: > + - Suzuki K Poulose > + - Mathieu Poirier > + > +description: | > + Arm Embedded Trace Extension(ETE) is a per CPU trace component that > + allows tracing the CPU execution. It overlaps with the CoreSight ETMv4 > + architecture and has extended support for future architecture changes. > + The trace generated by the ETE could be stored via legacy CoreSight > + components (e.g, TMC-ETR) or other means (e.g, using a per CPU buffer > + Arm Trace Buffer Extension (TRBE)). Since the ETE can be connected to > + legacy CoreSight components, a node must be listed per instance, along > + with any optional connection graph as per the coresight bindings. > + See bindings/arm/coresight.txt. > + > +properties: > + $nodename: > + pattern: "^ete([0-9a-f]+)$" > + compatible: > + items: > + - const: arm,embedded-trace-extension > + > + cpu: We've already established 'cpus' for this purpose. > + description: | > + Handle to the cpu this ETE is bound to. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + out-ports: > + type: object Replace with: $ref: /schemas/graph.yaml#/properties/ports > + description: | > + Output connections from the ETE to legacy CoreSight trace bus. > + properties: > + port: > + $ref: /schemas/graph.yaml#/properties/port Actually, if only 1 port ever, you can drop 'out-ports' and just have 'port'. Not sure though if the coresight stuff depends on 'out-ports'. > + > +required: > + - compatible > + - cpu > + > +additionalProperties: false > + > +examples: > + > +# An ETE node without legacy CoreSight connections > + - | > + ete0 { > + compatible = "arm,embedded-trace-extension"; > + cpu = <&cpu_0>; > + }; > +# An ETE node with legacy CoreSight connections > + - | > + ete1 { > + compatible = "arm,embedded-trace-extension"; > + cpu = <&cpu_1>; > + > + out-ports { /* legacy coresight connection */ > + port { > + ete1_out_port: endpoint { > + remote-endpoint = <&funnel_in_port0>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel