From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 604C3C433E0 for ; Tue, 9 Feb 2021 21:55:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C69C64ED2 for ; Tue, 9 Feb 2021 21:55:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C69C64ED2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k1EtuUwPkAZK6iPYOYqhNHSFMsrepfW0hRuBJMbOkg8=; b=TRK0E2e8JP5+JQzJrtTgoevpY RvI8KolGCy+v/4eCsHF/nxiLmoobEFO5hHG11unzODQB043OoccWXagmzABY3Tmo4B+gLAXs6eb8h 7G7YMnbFulRXoRVAuY1pH0oNl8YVGbUoG3Vd3ucmc1TgGELz8tUFxlppgAO2yBLLGzIqewjUkwNhr gU++15JcZ6mxK3XdSVOwEbboFgm+sFns+uaaxjYQ85sqKL/B8DpiT+u/3QLGBLuuIzLCGvGgTX2Lo JvbMDneMEdClM2K0FekaX1N6vBzBZbx8kzX1m60o61PgRM01H+fSGZbSixA6PiG/VcE7BwEEU5Y3G Om3DxOeLA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9axT-0006Gp-Ly; Tue, 09 Feb 2021 21:54:07 +0000 Received: from mail-oi1-f169.google.com ([209.85.167.169]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9axR-0006FQ-BK for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 21:54:06 +0000 Received: by mail-oi1-f169.google.com with SMTP id i3so10229472oif.1 for ; Tue, 09 Feb 2021 13:54:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bOiEgQJc9F4c/q7bHFCKm4lcHmd+4+4DEwd4LTgy3IY=; b=AsZqcq/hM0Ethc6uh1oJM9wdbnKND8/8JdsfqAQxU12qzyeBAOOJ1ZrOHQYc9xfERa 9abDl6ozz0XkPOzN5pvU8KbobTy+z6FZLtPxKAWYoMf8UdbGMRsjTtghOsLort40iHPo SlGJoJzJhFT0RSOv9Cj5FqNE0k8fnIFt4ORC8wmwmU1EEZ4ekP15PA4EnLzbyj3YbLe9 p4NnFKhFfqUf0OYwndpnEpEORe+hBbazLZ7CLyLizJ3Mfscy2lywsglvkCXa6Rl8OnaI h5KOnsrWAKbLCcUwoBOBHF+cAQXaOD+3zZYFBeTuxBhSwrpk0zHjLq9/hp93aMjQ+ki9 S7/w== X-Gm-Message-State: AOAM530WXw72Faw4o4Ew9unBLUgkAMPco8FB632tiFNESn4GtU2APjfw wdSF7u86lN0QLRDsXT2y0A== X-Google-Smtp-Source: ABdhPJx4uyiqqNf8J2Db0GfnFr86BDYIdEH1ii5Rx3XOwGmxWp5YiGpid9GYa8CRIZoTR6fO/8pZuw== X-Received: by 2002:a05:6808:a01:: with SMTP id n1mr3914674oij.19.1612907644210; Tue, 09 Feb 2021 13:54:04 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a18sm4791oia.0.2021.02.09.13.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 13:54:02 -0800 (PST) Received: (nullmailer pid 268551 invoked by uid 1000); Tue, 09 Feb 2021 21:54:00 -0000 Date: Tue, 9 Feb 2021 15:54:00 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH v2 03/24] dt-bindings: net: dwmac: Fix the TSO property declaration Message-ID: <20210209215400.GA268498@robh.at.kernel.org> References: <20210208135609.7685-1-Sergey.Semin@baikalelectronics.ru> <20210208135609.7685-4-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208135609.7685-4-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_165405_453460_21397279 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vyacheslav Mitrofanov , "David S. Miller" , Joao Pinto , netdev@vger.kernel.org, Lars Persson , Johan Hovold , Rob Herring , Alexey Malahov , Jose Abreu , Pavel Parkhomenko , Maxime Coquelin , Giuseppe Cavallaro , Serge Semin , Jakub Kicinski , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Alexandre Torgue Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 08 Feb 2021 16:55:47 +0300, Serge Semin wrote: > Indeed the STMMAC driver doesn't take the vendor-specific compatible > string into account to parse the "snps,tso" boolean property. It just > makes sure the node is compatible with DW MAC 4.x, 5.x and DW xGMAC > IP-cores. The original allwinner sunXi bindings file also didn't have the > TSO-related property declared. Taking all of that into account fix the > conditional statement so the TSO-property would be evaluated for the > compatibles having the corresponding IP-core version. > > While at it move the whole allOf-block from the tail of the binding file > to the head of it, as it's normally done in the most of the DT schemas. > > Signed-off-by: Serge Semin > > --- > > Note this won't break the bindings description, since the "snps,tso" > property isn't parsed by the Allwinner SunX GMAC glue driver, but only > by the generic platform DT-parser. > > Changelog v2: > - Use correct syntax of the JSON pointers, so the later would begin > with a '/' after the '#'. > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 52 +++++++++---------- > 1 file changed, 24 insertions(+), 28 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel