From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB96C433DB for ; Tue, 9 Feb 2021 23:15:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E92EC64E6F for ; Tue, 9 Feb 2021 23:14:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E92EC64E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JZHIMhbbkapXryzcVxwAA9Tv0glcN+2R3cjujLh1xKM=; b=E9aYk1EamwmpzhN9I/63Cn5n5 KyazjO+D6okECl8NaY6ZsYPxeW9wbmDQ0VnpicbaUpkkxiMfsB8cOgmT4wukyjH4wA1HjE4cPiDYe /vWkVsUDWJPDXUdHvGZG+SioWDtJecssiEQHlpMr1Hfo2MCcKFeegbXjejhBzYoQ2o36wjFTWZyLd wUuclIqB4E37VUBUOniCP96CQtONDSsn+NbG4M5sNhhXPEbcGDW6959QrP6OXqAxjaKk46Rx0mlZR Jy7NScsYuSfqZaun8gug9NUew/0+fvIMPz0v5gRLiRqOx79NYq7SfXNejC24e2GsefmLp7FwZYLq5 5F5yDNW5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9cCo-0001n6-2m; Tue, 09 Feb 2021 23:14:02 +0000 Received: from mail-oi1-f178.google.com ([209.85.167.178]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9cCk-0001lF-T8 for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 23:13:59 +0000 Received: by mail-oi1-f178.google.com with SMTP id d20so21289735oiw.10 for ; Tue, 09 Feb 2021 15:13:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iqog8CsMHZIPOPeN6dyy7RBD2+MWiYCuwU7gMHDgn+E=; b=CgN6lAlBhCAq+NsLfWeVCMFpM6s2Ovj1xIBKxb6enPqjLjTSVCzBZKHOmFGGpnX9vG SqM6UJQmUEu7NAyfz+uioydiy/G0SXVFEmpnVr704GDQjTW9FVwWEVClT9j/UkyQsVDh Rn1o3O9g7xbMMQ3+oW6lMYBGGAQ78RdNO8IkvkeIbnRWDLW1R/Wb7vud1aS1evGG70X9 NLZ96I9WJrdu95dxdnGbDj3WEP4ouWX24910zTvEjZZrVl0osMS3ewBv7ZNALltOV1eA 0aDIzsc1E1eXdIZE2lnmviOuSCNNQ7bpEMty6w81XNG9jy2drEC4TCrjY/UhjRfUNmQ2 /PXA== X-Gm-Message-State: AOAM531EDkH6o7qtNwmkzZu5F/txHbBnnY2b8wNqqODZvdLgQuoPiWsi mnMYvH3miFyA3tQVhC/hrbiyb7fGJA== X-Google-Smtp-Source: ABdhPJzM6bjqNck+607mXDy9PNLPvWoFJltI+hjArBy4hP5rzbxs58R6CIAoKNThG27jqmChAp+4ng== X-Received: by 2002:aca:4b43:: with SMTP id y64mr86780oia.156.1612912434949; Tue, 09 Feb 2021 15:13:54 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i16sm7022oto.45.2021.02.09.15.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 15:13:53 -0800 (PST) Received: (nullmailer pid 410105 invoked by uid 1000); Tue, 09 Feb 2021 23:13:52 -0000 Date: Tue, 9 Feb 2021 17:13:52 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH 01/16] dt-bindings: net: dwmac: Add DW GMAC GPIOs properties Message-ID: <20210209231352.GA402351@robh.at.kernel.org> References: <20210208140820.10410-1-Sergey.Semin@baikalelectronics.ru> <20210208140820.10410-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208140820.10410-2-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_181358_971589_8A6B08A1 X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Torgue , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Vyacheslav Mitrofanov , Serge Semin , Alexey Malahov , Jose Abreu , Pavel Parkhomenko , Maxime Coquelin , Jakub Kicinski , Giuseppe Cavallaro , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 05:08:05PM +0300, Serge Semin wrote: > Synopsys DesignWare Ethernet controllers can be synthesized with > General-Purpose IOs support. GPIOs can work either as inputs or as outputs > thus belong to the gpi_i and gpo_o ports respectively. The ports width > (number of possible inputs/outputs) and the configuration registers layout > depend on the IP-core version. For instance, DW GMAC can have from 0 to 4 > GPIs and from 0 to 4 GPOs, while DW xGMAC have a wider ports width up to > 16 pins of each one. > > So the DW MAC DT-node can be equipped with "ngpios" property, which can't > have a value greater than 32, standard GPIO-related properties like > "gpio-controller" and "#gpio-cells", and, if GPIs are supposed to be > detected, IRQ-controller related properties. > > Signed-off-by: Serge Semin > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index bdc437b14878..fcca23d3727e 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -110,6 +110,23 @@ properties: > reset-names: > const: stmmaceth > > + ngpios: > + description: > + Total number of GPIOs the MAC supports. The property shall include both > + the GPI and GPO ports width. > + minimum: 1 > + maximum: 32 Does the driver actually need this? I'd omit it if just to validate consumers are in range. Are GPI and GPO counts independent? If so, this isn't really sufficient. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel