From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469BCC433E0 for ; Tue, 9 Feb 2021 23:25:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFA0C64E4B for ; Tue, 9 Feb 2021 23:25:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFA0C64E4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g3htDu/loa1s7qVnXO91nJZ+eij2s0j9j1wDJ79p/WA=; b=O7PCCGI4fFKKDPLEa6g9bGnUs leULsGj/+U0RHTNabTSD3RDeoocixRgKQ/jWrcEp/Meeik0QldJJ6hPngjfKiAP5J1J+oDwwjV9qK yHw0PLxb2NSRCP+jW1Nn+KYFJ03BsiwQoh5V3kUOAr+yMTKKLKby+Ox4rQx0jvabttENc/obOQJ5I INy60kU95RErnmSaEavWsG53ekjWplLAo50jYxyqK3+tgD3GTm9xGbuYO0eW2tadiENJ4i9zhsQSM ACwJUEaE2Viq3gIJQZf/8sDlaz0UJchqVwknB76H6DQbnlC6bZsBKfqM6epUU/CCgZG6ZI/GOl1Xt 54hItuF1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9cMk-0003n4-20; Tue, 09 Feb 2021 23:24:18 +0000 Received: from mail-oi1-f169.google.com ([209.85.167.169]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9cMg-0003m3-Bw for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 23:24:15 +0000 Received: by mail-oi1-f169.google.com with SMTP id d20so21314992oiw.10 for ; Tue, 09 Feb 2021 15:24:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c0+mQvbUzr0QHjab9b+cDuiuwKG7CNWq4G/aggiV8ko=; b=YqQ0xYGFvJMdlh7z75Z8aIrSEO/3gHzINcXu3T4cHrrFccsI6ToAhTMN/vGrpM9WVU V+LCzChD4lw6VP87jGRt+2tbPIUR5a2HU+HBLSBp4WIyxp/w7VIUGw640xgkFj/UCrBq ZSfEzHgX5J3jFzaqQLwe1OexkJEvke1jvJ5RBFtU0TKXfMGOd+j6nUVrCPAX8AYQ5Der PfnAkQdpfciUToBONiOubpygv7/9l5QUNT/i3vlx0OPSZF9Vm7ec5Ay74/PeHL71RLYL YJYc03yKseaTJO8zLMYNNIW0yQoyTsS/+wNXBmzvHijccB9JVHAZFtnQDSlC4s2raAFa 61mQ== X-Gm-Message-State: AOAM530RkhmtzDkStboQ/0pPaa8kM534FFNUJRC7ylYTgUWXsJE7huEd 3br9676wn820qCGvv1oj+A== X-Google-Smtp-Source: ABdhPJz6qtqiolUfmqOCucOTDw4UZsTDHjUdAxJoYxLAfMasBXNXmWyKEfqfN3viNqLICssfBelF6g== X-Received: by 2002:aca:570d:: with SMTP id l13mr91914oib.159.1612913053378; Tue, 09 Feb 2021 15:24:13 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id q3sm51946oih.35.2021.02.09.15.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 15:24:11 -0800 (PST) Received: (nullmailer pid 428235 invoked by uid 1000); Tue, 09 Feb 2021 23:24:10 -0000 Date: Tue, 9 Feb 2021 17:24:10 -0600 From: Rob Herring To: Serge Semin Subject: Re: [PATCH 02/16] dt-bindings: net: Add Baikal-T1 GMAC bindings Message-ID: <20210209232410.GA410815@robh.at.kernel.org> References: <20210208140820.10410-1-Sergey.Semin@baikalelectronics.ru> <20210208140820.10410-3-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210208140820.10410-3-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_182414_455731_D2114E02 X-CRM114-Status: GOOD ( 21.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Torgue , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Vyacheslav Mitrofanov , Serge Semin , Alexey Malahov , Jose Abreu , Pavel Parkhomenko , Maxime Coquelin , Jakub Kicinski , Giuseppe Cavallaro , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 08, 2021 at 05:08:06PM +0300, Serge Semin wrote: > Baikal-T1 SoC is equipped with two DW GMAC v3.73a-based 1GBE ethernet > interfaces synthesized with: RGMII PHY interface, AXI-DMA and APB3 CSR, > 16KB Tx/Rx FIFOs and PBL up to half of that, PTP, PMT, TCP/IP CoE, up to 4 > outstanding AXI read/write requests, maximum AXI burst length of 16 beats, > up to eight MAC address slots, one GPI and one GPO ports. Generic DW > MAC/STMMAC driver will easily handle the DT-node describing the Baikal-T1 > GMAC network devices, but the bindings still needs to be created to have a > better understanding of what the interface looks like. > > Signed-off-by: Serge Semin > > --- > > Rob, please note I couldn't declare the axi-config object properties constraints > without specifying the properties type and description. If I remove them the > dt_binding_check will curse with the error: > > >> .../baikal,bt1-gmac.yaml: properties:axi-config:properties:snps,blen: 'description' is a required property > >> .../baikal,bt1-gmac.yaml: properties:axi-config:properties:snps,wr_osr_lmt: 'oneOf' conditional failed, one must be fixed: > 'type' is a required property > Additional properties are not allowed ('maximum' was unexpected) > >> ... > > I did't know what to do with these errors, so I just created normal sub-node > properties with stricter constraints than they are specified in the main > snps,dwmac.yaml schema. Any suggestion what is a better way to apply > additional constraints on sub-node properties? Yes, that's known problem which I don't have a solution for. I think the solution is checking all properties have a type defined once and only once. That would also make sure we don't have 2 property names with different types. With that we can loosen the meta-schema checks. In the vast majority of cases though we need a type, so the exceptions like here will need to duplicate the type and description. Reviewed-by: Rob Herring > --- > .../bindings/net/baikal,bt1-gmac.yaml | 150 ++++++++++++++++++ > 1 file changed, 150 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/baikal,bt1-gmac.yaml _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel