From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D508DC433E0 for ; Wed, 10 Feb 2021 20:56:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A14864DE7 for ; Wed, 10 Feb 2021 20:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A14864DE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NqPI9kuVuUqVSyEj7PI3dufRCqGhWJgTYf+lthOpj74=; b=paDPHOB3O3NaU57BS7VMA935T Nb004UFWeG1GYVfGJcnfPWw4IZpaS9kR4N9HdKzKvHL3YIKsWTMsGHDYqrgnOHhNInG/+/pWZGxdb O8dmCgST7uvPxd/yW0duT6/SHSNrq1SxFLFTNRf0vtcNFszs1ZitIPMaZDRNVdig5oXTvPe6K58Dm Afwjoew9LntRNWlRpkdD+8oIr3FQ6qX/SDJn8qyRZTzbkbSdJsZ4opKwwm60xfi3k7oAAIAS/bNCA 6gfJ/xQmFYFPZ9PsoJOfyIcZU5Yb/M6ViWzDYtfPqNLAXAEv+XCiFPRKceToO8nIFvt+++nJ++3j/ UUdl7jCyg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9wVr-0003v0-2U; Wed, 10 Feb 2021 20:55:03 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9wVo-0003uQ-UO for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 20:55:01 +0000 Received: by mail-pg1-x536.google.com with SMTP id t26so2043679pgv.3 for ; Wed, 10 Feb 2021 12:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XK6hpz+PCOsL7W55wJU4s9nIbpn+lmg5rsc0pPcV4bs=; b=DlkD+c2Ccf9no7hwfEx3lqTSksvhp1VVOdzKfCVsqGzVhqLgaFygvQUy7o3VV04mnL fZkDQKqcNswW6+OtqTryQA4lo2GKWgMzeURDgKOBtt4mxHoClQUWVzGw20KEzWg4uiyf XCNzAHV31atpRmRYe10BxajqVS3cJOa3Ep8TI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XK6hpz+PCOsL7W55wJU4s9nIbpn+lmg5rsc0pPcV4bs=; b=posCG6TiC4Txeqb3MgV4GQRo8dLzDU8BhXCdlcX0a1KpAUWBscc+xhRTp6kK4DsnM0 ihdqWRw2GXsZsLmEWrq+szUrtRnsARI6ysR0oZYtWnEHHBc++19+HcSiBCoa0CiiBMgF e6co2O68A9I9/Eg4rK8KfNnqI0ChApEsNsnewY+Hra0iRrvuoyBORNz6kg3BVJoDWTHp 8RRYT0HQtrXQa2mT9M08iFtvApkN1uq6STt4Yqi8m+sNDhAzyY3YEjgQ/8MHZiHgA8+j D2OQPEUIftHYUW5eluvZLF8aMJ7PBNbrOFT1LNYzz99acHweiTF8siWCNUVd4DISSSKM gqSA== X-Gm-Message-State: AOAM5329A7aISXz1yvcMF3XoI+afOjlr1/w2lFq6JrhJNj1eyitTalSI ngiv0josuvveVMGAkuN96QqKKw== X-Google-Smtp-Source: ABdhPJzaxDgY6uHenP6VKy3Z+OUoo1YD/3D6dOTKAoKYExeojilYLpdTH5T0TraQLPoS4LEtG0K5xQ== X-Received: by 2002:a63:a312:: with SMTP id s18mr4698497pge.229.1612990498607; Wed, 10 Feb 2021 12:54:58 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 17sm3167706pgy.53.2021.02.10.12.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 12:54:58 -0800 (PST) Date: Wed, 10 Feb 2021 12:54:57 -0800 From: Kees Cook To: Will Deacon Subject: Re: [PATCH 3/3] selftest/arm64/ptrace: add tests for PTRACE_O_ARM64_RAW_REGS Message-ID: <202102101253.300A11108@keescook> References: <20210201194012.524831-1-avagin@gmail.com> <20210201194012.524831-4-avagin@gmail.com> <20210204154038.GC21058@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210204154038.GC21058@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_155501_049491_E8935760 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anthony Steinhauser , linux-api@vger.kernel.org, Oleg Nesterov , linux-kernel@vger.kernel.org, Keno Fischer , Andrei Vagin , Catalin Marinas , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 04, 2021 at 03:40:39PM +0000, Will Deacon wrote: > [+Kees] > > On Mon, Feb 01, 2021 at 11:40:12AM -0800, Andrei Vagin wrote: > > Test output: > > TAP version 13 > > 1..2 > > # selftests: arm64/ptrace: ptrace_syscall_raw_regs_test > > # 1..2 > > # ok 1 x7: 686920776f726c64 > > # ok 2 The child exited with code 0. > > # # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0 > > ok 1 selftests: arm64/ptrace: ptrace_syscall_raw_regs_test > > # selftests: arm64/ptrace: ptrace_syscall_regs_test > > # 1..3 > > # ok 1 x7: 0 > > # ok 2 x7: 1 > > # ok 3 The child exited with code 0. > > # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0 > > ok 2 selftests: arm64/ptrace: ptrace_syscall_regs_test > > > > Signed-off-by: Andrei Vagin > > --- > > tools/testing/selftests/arm64/Makefile | 2 +- > > tools/testing/selftests/arm64/ptrace/Makefile | 6 + > > .../ptrace/ptrace_syscall_raw_regs_test.c | 142 +++++++++++++++++ > > .../arm64/ptrace/ptrace_syscall_regs_test.c | 150 ++++++++++++++++++ > > 4 files changed, 299 insertions(+), 1 deletion(-) > > create mode 100644 tools/testing/selftests/arm64/ptrace/Makefile > > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_raw_regs_test.c > > create mode 100644 tools/testing/selftests/arm64/ptrace/ptrace_syscall_regs_test.c > > Thanks for the tests! > > We already have a pretty extensive set of syscall entry tests in > tools/testing/selftests/seccomp, so perhaps this would be better off as part > of that? Maybe worth a look. I'm happy with this living in either place -- I can make an argument either way. If it's arm64-specific, maybe better to live outside of seccomp? -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel