From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Paul J. Murphy" <paul.j.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH 03/11] arm64: dts: intel: socfpga: override clocks by label
Date: Wed, 10 Feb 2021 18:18:15 +0100 [thread overview]
Message-ID: <20210210171823.333802-3-krzk@kernel.org> (raw)
In-Reply-To: <20210210171823.333802-1-krzk@kernel.org>
Using full paths to extend or override a device tree node is error
prone. If there was a typo error, a new node will be created instead of
extending the existing node. This will lead to run-time errors that
could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error
(during build time).
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 12 ++++--------
.../boot/dts/intel/socfpga_agilex_socdk_nand.dts | 12 ++++--------
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 12 ++++--------
3 files changed, 12 insertions(+), 24 deletions(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
index a7a83f29f00b..f14a89ca8784 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
@@ -41,14 +41,6 @@ memory {
/* We expect the bootloader to fill in the reg */
reg = <0 0 0 0>;
};
-
- soc {
- clocks {
- osc1 {
- clock-frequency = <25000000>;
- };
- };
- };
};
&gpio1 {
@@ -92,6 +84,10 @@ &mmc {
bus-width = <4>;
};
+&osc1 {
+ clock-frequency = <25000000>;
+};
+
&uart0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dts
index 979aa59a6bd0..58a827a5e83f 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dts
@@ -41,14 +41,6 @@ memory {
/* We expect the bootloader to fill in the reg */
reg = <0 0 0 0>;
};
-
- soc {
- clocks {
- osc1 {
- clock-frequency = <25000000>;
- };
- };
- };
};
&gpio1 {
@@ -121,6 +113,10 @@ partition@4280000 {
};
};
+&osc1 {
+ clock-frequency = <25000000>;
+};
+
&uart0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
index 5f56e2697fee..01f1307ce4ac 100644
--- a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
@@ -23,14 +23,6 @@ memory {
/* We expect the bootloader to fill in the reg */
reg = <0 0 0 0>;
};
-
- soc {
- clocks {
- osc1 {
- clock-frequency = <25000000>;
- };
- };
- };
};
&clkmgr {
@@ -44,6 +36,10 @@ &mmc {
bus-width = <4>;
};
+&osc1 {
+ clock-frequency = <25000000>;
+};
+
&uart0 {
status = "okay";
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-10 17:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 17:18 [PATCH 01/11] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC Krzysztof Kozlowski
2021-02-10 17:18 ` [PATCH 02/11] dt-bindings: arm: intel, keembay: limit the dtschema to root node Krzysztof Kozlowski
2021-02-11 15:03 ` Alessandrelli, Daniele
2021-02-10 17:18 ` Krzysztof Kozlowski [this message]
2021-03-03 18:15 ` [PATCH 03/11] arm64: dts: intel: socfpga: override clocks by label Krzysztof Kozlowski
2021-02-10 17:18 ` [RFT 04/11] arm64: dts: intel: socfpga_agilex: move clocks out of soc node Krzysztof Kozlowski
2021-02-10 17:18 ` [RFT 05/11] arm64: dts: intel: socfpga_agilex: move timer " Krzysztof Kozlowski
2021-02-10 17:18 ` [PATCH 06/11] arm64: dts: intel: socfpga_agilex: remove default status=okay Krzysztof Kozlowski
2021-02-10 17:18 ` [RFT 07/11] arm64: dts: intel: socfpga_agilex: move usbphy out of soc node Krzysztof Kozlowski
2021-02-10 17:18 ` [PATCH 08/11] arm64: dts: intel: socfpga_agilex: use defined for GIC interrupts Krzysztof Kozlowski
2021-02-10 17:18 ` [RFT 09/11] arm64: dts: intel: socfpga_agilex: align node names with dtschema Krzysztof Kozlowski
2021-02-10 17:18 ` [RFT 10/11] arm64: dts: intel: socfpga_agilex_socdk: align LED " Krzysztof Kozlowski
2021-02-10 17:18 ` [RFT 11/11] arm64: dts: intel: socfpga_agilex_socdk_nand: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210171823.333802-3-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=paul.j.murphy@intel.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).