From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 604D4C433E0 for ; Wed, 10 Feb 2021 18:56:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 159CE60C41 for ; Wed, 10 Feb 2021 18:56:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 159CE60C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qMTUMA26S58B87LP/QyJmLh/KzcT+EcZHosBTU8JdVM=; b=F3HbicYvfkQPAKqHNfu2XOgf6 NWOhT6kdQyRViWAMmlJnsZZu/e7nDJ5/DtrNqnBQL5Y0NCRjMwjvBwgVKSJYLkHksgMBl88CzMMz9 fbB3tB6IYNJa0XKNuQsJZlDkKcLXLWiBxcHrzy4YEKoFjeWJV3cEwHC7aMjtn5ikbWKQgoWbpzz3h /s9Y36hi3FfPR+BX59gAu6V6/w1sMijt10QRASrQf354LaU57hEx0tAzEPYRhKR03c/Y+ai24Z+CJ +Yn2f79aDpnxcb0/7Gtldk7GoPc9sHU/r25ZnJ/FXLTLfzHTb7JUjZ8X/JFJathvyGRDchVWDrV2z q36Kbm7jA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9ueV-0001m4-Lk; Wed, 10 Feb 2021 18:55:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9ueR-0001kb-5n for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 18:55:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C57AA64E2E; Wed, 10 Feb 2021 18:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612983346; bh=WPn3FnII9y1zOCkNwPUqBpfLuu67gBwkRyG3OURqgF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Otn+Z9oqTklghtv/HpjyklE5QeNV7DwZOdXcryeCqc5Ho9JOjHwlw+NryN2bC2OiO 6Czvo40IXAv3U+XHwGXo4sNw42VTXQZB34iikf1zuHVF3lveYWxQPsr3yXOEc+prqz EIMIMRjkxiLJSU671ZefwDOXJJT1sa64KIvrJBUzkR7CPwsDiQiYoECKF2GE0llpO1 q9/fL7PiGbhzABpckvWpPOiKe/hIp/U++LC8iBUPDDxz6EcOJFl5SkI5ub8zArZMt5 q3TKnate0qY9fpkQk8oc2wfAd2KY0dZ4RTwJ1B85jKsCzJhc8Bm3WavNjq619W13y/ 2N8dPUOhdNF2A== From: Ard Biesheuvel To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/3] ARM: cache-v7: add missing ISB after cache level selection Date: Wed, 10 Feb 2021 19:55:30 +0100 Message-Id: <20210210185532.8425-2-ardb@kernel.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210210185532.8425-1-ardb@kernel.org> References: <20210210185532.8425-1-ardb@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_135547_562144_70AF2FEB X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Pitre , Marc Zyngier , Linus Walleij , Russell King , kernel-team@android.com, Ard Biesheuvel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org A write to CCSELR needs to complete before its results can be observed via CCSIDR. So add a ISB to ensure that this is the case. Acked-by: Nicolas Pitre Signed-off-by: Ard Biesheuvel --- arch/arm/mm/cache-v7.S | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/mm/cache-v7.S b/arch/arm/mm/cache-v7.S index dc8f152f3556..307f381eee71 100644 --- a/arch/arm/mm/cache-v7.S +++ b/arch/arm/mm/cache-v7.S @@ -38,9 +38,10 @@ icache_size: * procedures. */ ENTRY(v7_invalidate_l1) - mov r0, #0 - mcr p15, 2, r0, c0, c0, 0 - mrc p15, 1, r0, c0, c0, 0 + mov r0, #0 + mcr p15, 2, r0, c0, c0, 0 @ select L1 data cache in CSSELR + isb + mrc p15, 1, r0, c0, c0, 0 @ read cache geometry from CCSIDR movw r1, #0x7fff and r2, r1, r0, lsr #13 -- 2.30.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel