From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F7FC433E0 for ; Thu, 11 Feb 2021 11:07:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32E0C64D73 for ; Thu, 11 Feb 2021 11:07:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32E0C64D73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J6+UfRXRTEThzdwdll2s50dNW2BcjbujsTPtYPTGkSI=; b=QxK8qhA3js3TYQsBV4yDXrvNP hZ5LnsNo1UMVC4OsY23fBl2bB7Fpu2ydJJcBopx4dM2xkFX5ONbMriQU2/yLK1bec+FhrCSrt9VYT xBHG3hGHqN8PF4rmJZmO9EmDGrM4EahGLPS0tHZtNnQ05lO+TPhxBNI35UYbuRwAJ8hhYsUhlHK6D limBT7KffNB/M/YBtdZ4g7lB2JBv3od9xmlqNOoeRHMlrpaK2L+Nwi0qPXFBw/rFHAlXywrv+A2Kl YMWlCPZrXuTd1uNtIaPibyihGghpJklfdE/Q27glKELJYvWVu0URl0HLZXTvINffgjKNUraechWk6 VXMt01H8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lA9mp-0003el-Kn; Thu, 11 Feb 2021 11:05:27 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lA9mn-0003eL-Ni for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 11:05:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aUMOhZ/r6K5pZQMb5adTT2R7mflcUd6gQF1EZlt7rh0=; b=PUhPuNsuYsvXpCGX7J7lZklpk ViW2nNfn6viKIQZYO984pDEFwpaRMcRAOu/BHW7/QP1DqSHqfS4bYC9KzUY64vMYLE7kVPR2k7BMQ wI6B8TRv5yvLsnIBQx8VuPd4UGPzwyKIHhRkWzSXD/iU92dcG/Lo4lbdIa1w4SQ8WSD63auxyYbiO oLv7XYB4/dO5NFJXIqEgOD4hf5QhWUIzjaI9XRlfsfyGZL3qYuDjn6RvHf8zPeicL+XER1v9XzySS w3+kpc6VsfuyDdYKpqFzFF3D1G7qPomAEGtL1c2zuKWJne1jQpnqzI9mrY29xnxP0Z20pnPmZAVtc hN9iNht4w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41988) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lA9mi-000613-7N; Thu, 11 Feb 2021 11:05:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lA9mh-00061L-J3; Thu, 11 Feb 2021 11:05:19 +0000 Date: Thu, 11 Feb 2021 11:05:19 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Subject: Re: [PATCH v13 net-next 03/15] net: mvpp2: add CM3 SRAM memory map Message-ID: <20210211110519.GA1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-4-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613040542-16500-4-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_060525_811382_A1C3FADB X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, ymarkman@marvell.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, atenart@kernel.org, linux-kernel@vger.kernel.org, nadavh@marvell.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com, davem@davemloft.net, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 12:48:50PM +0200, stefanc@marvell.com wrote: > +static int mvpp2_get_sram(struct platform_device *pdev, > + struct mvpp2 *priv) > +{ > + struct resource *res; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 2); > + if (!res) { > + if (has_acpi_companion(&pdev->dev)) > + dev_warn(&pdev->dev, "ACPI is too old, Flow control not supported\n"); > + else > + dev_warn(&pdev->dev, "DT is too old, Flow control not supported\n"); > + return 0; > + } > + > + priv->cm3_base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(priv->cm3_base)) > + return PTR_ERR(priv->cm3_base); > + > + return 0; You can clean this up to use: return PTR_ERR_OR_ZERO(priv->cm3_base); > + > + /* Map CM3 SRAM */ > + err = mvpp2_get_sram(pdev, priv); > + if (err) > + dev_warn(&pdev->dev, "Fail to alloc CM3 SRAM\n"); It looks to me like mvpp2_get_sram() only fails if we are unable to _map_ the CM3 SRAM. We are no longer allocating anything from it, so I think this message needs to be updated. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel