From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15EFCC433E0 for ; Thu, 11 Feb 2021 11:09:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A718264D73 for ; Thu, 11 Feb 2021 11:09:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A718264D73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wzhJTK3iC24MX2Uh/kLgxH+hmr0AIPamAvwoH0NUC/w=; b=0dK61ED4MzJsO6X1ZDSrvFSy6 geimMiFBMmaKP0+PVqdDTP2zZ7RRhZcTtsjlbZYrmkF+K3ZbyGwFOR5zHo0RqJApDeIBm7thJYSrW l0DwsmUfkcaWbPKDzBcKYlx4pBck0zPMAkcrgxV2b3QntEWil6Bv5vljFFZcATVIvMJLeKh32pQJN UW05pN07+8FOsmFn5yFxjYRYGVwFman9Y+isF+sXh5HNP37hV4xwX8AZAFvj70SyahVX9z7ytyod3 Ecf/gf6mJJJm5iN7NHufmtSa1wP0QTSA4HbQRGEQTYyVJFFTw/n12Ud5B3UD4GTMhetxuBtmT75od r4YX9pgAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lA9pb-0004As-8I; Thu, 11 Feb 2021 11:08:19 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lA9pY-0004A2-M8 for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 11:08:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=v7B7fHaW3Pp4ZozkuVSMVbnsnAHO8uAyG66cNYc6odE=; b=PoyX2SqGSZloO83H2r4Lv2qQw gUZDFSKrKQaoILac4/+411OM9BpxjKH8U3cvAy8a5aWGKpIAhEFFbrSvbC9yui7iq+7ZZGLV6zCpg 4QU1IlbVa8uL04CB8d9bczbZj8Nex8eBkUjtaGO2FFovXEVNYP/d89MTzvbyIloanQ1lGix19m7Is y20gAPrMtBalJ4tzQLAILBqAxcz9zCguhruaxAZnUo3pWWOqYaUnh0P4aM23WvbEit4PjHDBkQDxZ nxuH2WD9I/KJbjBxjK9CiFNgAwTBstXZYFV7Tx8JH4gF3bzq//RT1m3tzGnxQodgh4b9MCgvYxCUy pgoCGzFaQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41990) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lA9pS-00061k-NH; Thu, 11 Feb 2021 11:08:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lA9pR-00061W-Qj; Thu, 11 Feb 2021 11:08:09 +0000 Date: Thu, 11 Feb 2021 11:08:09 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Subject: Re: [PATCH v13 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21 Message-ID: <20210211110809.GB1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-5-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613040542-16500-5-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_060816_754979_7AAF357B X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, ymarkman@marvell.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, atenart@kernel.org, linux-kernel@vger.kernel.org, nadavh@marvell.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com, davem@davemloft.net, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 12:48:51PM +0200, stefanc@marvell.com wrote: > @@ -1199,7 +1199,7 @@ static bool mvpp2_port_supports_xlg(struct mvpp2_port *port) > > static bool mvpp2_port_supports_rgmii(struct mvpp2_port *port) > { > - return !(port->priv->hw_version == MVPP22 && port->gop_id == 0); > + return !(port->priv->hw_version != MVPP21 && port->gop_id == 0); I'm still very much of the opinion (as raised several revisions back) that using > MVPP21 or >= MVPP22 would be a lot better - especially when we have situations like this. Having negatives within negatives does not help readability. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel