From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396A5C433DB for ; Thu, 11 Feb 2021 12:51:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D53C564E05 for ; Thu, 11 Feb 2021 12:51:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D53C564E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PQdyDYWOgVEBn37kfj1iq6/iT7ihHNE927I6EdR8fQk=; b=yFhmwYUT6uJcnjkjw8I5g9Ali KXoE1ZRVVwqMzwPpmSaLP8GaIV15XO3OLqEM9rbcZ4E89c0eOs9idehG2lWB9hN2kf/W6SfAdtZaP jRUNxOEDFfl1BCj6GWp82/S4MSevqJInbIxFPAg4VuV7VrdevDgjspTLtnKiS1HLR6GjMidutsbyV KFb/3514Yp+W2X7bn3iEh6KtxSv21L75JA4iANwqu+DfdwrvLpFffeNg2FdIFkYqEkU6NAQQZy0Oh 6s3lgQW6USJEIEdMtSxb9sP3pDVv+pcriagewf7x8phKxTG+r6g1ceD4c4VqZWlivIw609GBwqjZM QeTzaQWlQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lABQK-00017x-BW; Thu, 11 Feb 2021 12:50:20 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lABQI-00017H-8C for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 12:50:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wJY1AXNICyiAjWTjHLSdsRyJ5X0w0R4RDqdbhpckHx0=; b=i3rK+jSbve+mC02hmuXLyDrLf YkGNpr/rDfUheRqzahx7PxA8y3HUcCrEn7MMA1zfaKbpYPLFEZP6PmTANTk3fUOFxxDCKIFG3R9aG oXTxEC1yYVr2zMO6AtGtMlLNIPdwrzSbkFbpE4mnK+pbr0af11+XND9Y6l+3yzPI7wbyN2avB0jDx /UvdPxJYv255B0mA140QTjK3uuvDclOxgc/mhbdhlY2kgWm9MuMB3MsJ3J9tubH9vVTABCL+mDEkq kpnK9LWeXchtpr0YvjOBPEBS2fVUQtsGB4EfMioP0LFWGMBeJ8IAnVuHnplHnIzlGu+Z+6RiMEAEU YvYVymw7g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42030) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lABQA-0006A2-RN; Thu, 11 Feb 2021 12:50:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lABQA-00066M-0o; Thu, 11 Feb 2021 12:50:10 +0000 Date: Thu, 11 Feb 2021 12:50:09 +0000 From: Russell King - ARM Linux admin To: stefanc@marvell.com Subject: Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold Message-ID: <20210211125009.GF1463@shell.armlinux.org.uk> References: <1613040542-16500-1-git-send-email-stefanc@marvell.com> <1613040542-16500-9-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613040542-16500-9-git-send-email-stefanc@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_075018_302401_968B232B X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, ymarkman@marvell.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, atenart@kernel.org, linux-kernel@vger.kernel.org, nadavh@marvell.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kuba@kernel.org, mw@semihalf.com, davem@davemloft.net, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 11, 2021 at 12:48:55PM +0200, stefanc@marvell.com wrote: > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 761f745..8b4073c 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -1133,14 +1133,19 @@ static inline void mvpp2_qvec_interrupt_disable(struct mvpp2_queue_vector *qvec) > static void mvpp2_interrupts_mask(void *arg) > { > struct mvpp2_port *port = arg; > + int cpu = smp_processor_id(); > + u32 thread; > > /* If the thread isn't used, don't do anything */ > - if (smp_processor_id() > port->priv->nthreads) > + if (cpu > port->priv->nthreads) > return; What happened to a patch fixing this? Did I miss it? Was it submitted independently to the net tree? > @@ -1150,20 +1155,25 @@ static void mvpp2_interrupts_mask(void *arg) > static void mvpp2_interrupts_unmask(void *arg) > { > struct mvpp2_port *port = arg; > - u32 val; > + int cpu = smp_processor_id(); > + u32 val, thread; > > /* If the thread isn't used, don't do anything */ > - if (smp_processor_id() > port->priv->nthreads) > + if (cpu > port->priv->nthreads) > return; Ditto. I don't think these need to be fixed in the net tree, but it would still be nice to fix the problem. Please do so, as an initial patch in your series - so we can then backport if it turns out to eventually be necessary. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel