From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E5BC433DB for ; Thu, 11 Feb 2021 23:29:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F61664DD8 for ; Thu, 11 Feb 2021 23:29:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F61664DD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DYnzzYzgS9F7fYsg2xkfxcQNFA1Gi7MvnO2GhIc1frE=; b=BTg8Yp3xYEhRfXu0KmV9f1g6E qn/eOOROFeTN8MLzD3iRzMp5XjEVskVowDB4lr81Mb7DVspxOvSxPUCnG4nEp8We7na5ldiQOvD8S yVekofhY4+IDSeI/nPbmXO+YPKNX+uOM1zMRhZSmSBzvPF+ceOsw2iyImyEWsA4xLsxUoJDmP2o4c 1gQkLe0t4JlcfynQk0rG66E8PGhG8K98ixgFb/AMWEL670o5gHuxpEACjrCetP4z9nhG9nHlerG9L IEUdKnjXzICYJZd+6Xq9gEGtl9KXRJAaxbEi2L8D56iqGIyZBkp+AJ5mRk1Sw0HIjw1CoCJLevOGz k9KY6S9QA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lALOD-00024P-Aa; Thu, 11 Feb 2021 23:28:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lALO9-00022s-Tz for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 23:28:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D55F664DD8; Thu, 11 Feb 2021 23:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613086125; bh=MZAWePskn2HEdxy+HD42A1K7WAT50DQT5epDnHayuP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IPLRMqpQbwGDlvlcvKfv3OxlN2Qo6J6OpexYxz2q5SXR7ymCTFQfJnDEzpMyj8DyB vt1zxrKbbmGpcx+JD7gi66kDvzf+UhX0dHaZbcaBaDHO4b3GTcpyIQsLmTHAMpBiO2 a6yH3uLJ7A4BX9vA4G2ZXhCCg8MgU0axjHlKnWPJlAU66bhqJj1Gf4ZamKgWuhyQYp TKc3gFOaYGxNt7AQy85hy00gEhu9cyxEZjORuWOlKOxeNvyQqBUgvP0UjF+pMNp/o/ Hnfdhbz6Kr4D/JSI1TeWQLtfuGbpa6UezwbabYCVAzK+aO5wZDXNCP1Ge7skFOU7L/ QD/GRm3y7+9Bg== Received: by pali.im (Postfix) id 7B912A80; Fri, 12 Feb 2021 00:28:42 +0100 (CET) Date: Fri, 12 Feb 2021 00:28:42 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: kostap@marvell.com Subject: Re: [PATCH v2 06/12] arm64: dts: marvell: armada-3270-espressobin: add comphy references Message-ID: <20210211232842.no4jhvdwh4634cyt@pali> References: <20210210140949.32515-1-kostap@marvell.com> <20210210140949.32515-7-kostap@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210210140949.32515-7-kostap@marvell.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_182846_068036_E6196194 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, andrew@lunn.ch, jaz@semihalf.com, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, nadavh@marvell.com, robh+dt@kernel.org, stefanc@marvell.com, mw@semihalf.com, bpeled@marvell.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 10 February 2021 16:09:43 kostap@marvell.com wrote: > From: Grzegorz Jaszczyk > > Add "phys" entries pointing to COMPHYs to PCIe and USB3 nodes > > Signed-off-by: Grzegorz Jaszczyk > Signed-off-by: Konstantin Porotchkin Hello! This patch is not needed and now does nothing. > --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > index daffe136c523..bbd955909813 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > @@ -59,6 +59,8 @@ > /* J9 */ > &pcie0 { > status = "okay"; > + /* Generic PHY, providing serdes lanes */ > + phys = <&comphy1 0>; In mainline kernel is PCIe PHY already provided in armada-37xx.dtsi: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n497 > pinctrl-names = "default"; > pinctrl-0 = <&pcie_reset_pins &pcie_clkreq_pins>; > reset-gpios = <&gpiosb 3 GPIO_ACTIVE_LOW>; > @@ -139,6 +141,9 @@ > /* J7 */ > &usb3 { > status = "okay"; > + /* Generic PHY, providing serdes lanes */ > + phys = <&comphy0 0>; > + phy-names = "usb"; In mainline kernel is USB 3.0 PHY already provided in armada-37xx.dtsi: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n359 > }; > > /* J8 */ > -- > 2.17.1 > So final binary espressobin DTB files are same with and without this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel