From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69262C433E6 for ; Fri, 12 Feb 2021 10:03:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32BC164E6C for ; Fri, 12 Feb 2021 10:03:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32BC164E6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XyFesdrKB0FqG4iRbvfgpdvgt0gSZFl/6ILWtNpV31E=; b=Oe5o+XqAHM8ICF/ehdbziEcHI vQBwyRHdV0BMsFJ7SbE33ocWTA3qHkMFNnv2MaCXLYv0os2jlXDqQTsijBHeXJJM3FfZ/inRXAeN8 NGKSEieYz2x+43WYRDt5lNTkuZUNzor4sCoEgmGTtzoTHMge1xzP6CU/XiYd6uZDx9HSbAZsIuRCs uUfxBf1rTnkobdTtLtaRFKQRYzoheWV0q2Eu6WiRXZQNHb17DDpWRvTDRBVtSqECIb7qJC7eQVZ6K vvaHQC4LeLsOppSomkGZ9AoVFT/6Fc+DxxfTraN5U+jc7Y89UEToTZ/McOsJey36Gk8QsJ4rilKTI V4i/t4xug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAVH6-0007G0-Sm; Fri, 12 Feb 2021 10:02:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAVH4-0007FM-8M for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 10:02:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0755164DC3; Fri, 12 Feb 2021 10:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613124125; bh=oRrg2tw+cII3z1+BzfqA0zdOIO6to3rhzg5WBBTvas8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Be/0/3UIGmBABWuXi8OTeC3wQ8PjyVh/XZSdC2nkNa7TB3MvXUil7SIYszj608LI/ YqQj1g1aIijHQdQCmoeB9ZqH2svsx9BZiGbPFsTpjQod9IzQuYw8kI22jkv+MkRYdm ftjLoxA/xowUVfTH088nifvDWjsEC5Mg/US7gEwQfVNHAI/fPChA3/fA19KZGcwjlT f/OB734n/HUzP5xaINrxU/NXRjluQFmfHldHFRnJZz3oM3e3ASYfoihVqH2NZFCmM0 ekDiWvE+QkQSI7QrqS0ADCMMRuCh+0L/iLaN1/eZDWb4CLrgBboAfPqwzGBQWHaIpa dOjfsttt/sE/w== Date: Fri, 12 Feb 2021 10:02:00 +0000 From: Will Deacon To: Zhen Lei Subject: Re: [PATCH 1/1] ARM: hw_breakpoint: Do not directly check the event's overflow_handler hook Message-ID: <20210212100159.GA30991@willie-the-truck> References: <20210207105934.2001-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210207105934.2001-1-thunder.leizhen@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_050206_366962_08F8611B X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Wang Nan , Russell King , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 07, 2021 at 06:59:34PM +0800, Zhen Lei wrote: > The commit 1879445dfa7b ("perf/core: Set event's default > ::overflow_handler()") set a default event->overflow_handler in > perf_event_alloc(), and replace the check event->overflow_handler with > is_default_overflow_handler(), but one is missing. > > Currently, the bp->overflow_handler can not be NULL. As a result, > enable_single_step() is always not invoked. > > Fixes: 1879445dfa7b ("perf/core: Set event's default ::overflow_handler()") > Signed-off-by: Zhen Lei > Cc: Wang Nan > --- > arch/arm/kernel/hw_breakpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c > index 08660ae9dcbce1c..b1423fb130ea4a0 100644 > --- a/arch/arm/kernel/hw_breakpoint.c > +++ b/arch/arm/kernel/hw_breakpoint.c > @@ -886,7 +886,7 @@ static void breakpoint_handler(unsigned long unknown, struct pt_regs *regs) > info->trigger = addr; > pr_debug("breakpoint fired: address = 0x%x\n", addr); > perf_bp_event(bp, regs); > - if (!bp->overflow_handler) > + if (is_default_overflow_handler(bp)) > enable_single_step(bp, addr); > goto unlock; > } Acked-by: Will Deacon Please can you put this into the patch tracker? https://www.arm.linux.org.uk/developer/patches/ Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel