* Re: [PATCH] iommu: Add device name to iommu map/unmap trace events [not found] <20210209123620.19993-1-saiprakash.ranjan@codeaurora.org> @ 2021-02-12 10:50 ` Joerg Roedel 2021-04-06 6:56 ` chenxiang (M) 0 siblings, 1 reply; 3+ messages in thread From: Joerg Roedel @ 2021-02-12 10:50 UTC (permalink / raw) To: Sai Prakash Ranjan Cc: Will Deacon, linux-kernel, iommu, linux-arm-msm, Robin Murphy, linux-arm-kernel On Tue, Feb 09, 2021 at 06:06:20PM +0530, Sai Prakash Ranjan wrote: > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 5e7fe519430a..6064187d9bb6 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -87,6 +87,7 @@ struct iommu_domain { > void *handler_token; > struct iommu_domain_geometry geometry; > void *iova_cookie; > + char dev_name[32]; > }; No, definitly not. A domain is a device DMA address space which can be used by more than one device. Just look at IOMMU groups with more than one member device, in this case just one device name would be very misleading. Regards, Joerg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: Add device name to iommu map/unmap trace events 2021-02-12 10:50 ` [PATCH] iommu: Add device name to iommu map/unmap trace events Joerg Roedel @ 2021-04-06 6:56 ` chenxiang (M) 2021-04-06 9:08 ` Joerg Roedel 0 siblings, 1 reply; 3+ messages in thread From: chenxiang (M) @ 2021-04-06 6:56 UTC (permalink / raw) To: Joerg Roedel, Sai Prakash Ranjan Cc: Will Deacon, linux-kernel, iommu, linux-arm-msm, Robin Murphy, linux-arm-kernel, linuxarm Hi, 在 2021/2/12 18:50, Joerg Roedel 写道: > On Tue, Feb 09, 2021 at 06:06:20PM +0530, Sai Prakash Ranjan wrote: >> diff --git a/include/linux/iommu.h b/include/linux/iommu.h >> index 5e7fe519430a..6064187d9bb6 100644 >> --- a/include/linux/iommu.h >> +++ b/include/linux/iommu.h >> @@ -87,6 +87,7 @@ struct iommu_domain { >> void *handler_token; >> struct iommu_domain_geometry geometry; >> void *iova_cookie; >> + char dev_name[32]; >> }; > No, definitly not. A domain is a device DMA address space which can be > used by more than one device. Just look at IOMMU groups with more than > one member device, in this case just one device name would be very > misleading. Is it possible to use group id to identify different domains? > > Regards, > > Joerg > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: Add device name to iommu map/unmap trace events 2021-04-06 6:56 ` chenxiang (M) @ 2021-04-06 9:08 ` Joerg Roedel 0 siblings, 0 replies; 3+ messages in thread From: Joerg Roedel @ 2021-04-06 9:08 UTC (permalink / raw) To: chenxiang (M) Cc: Sai Prakash Ranjan, Will Deacon, linux-kernel, iommu, linux-arm-msm, Robin Murphy, linux-arm-kernel, linuxarm On Tue, Apr 06, 2021 at 02:56:53PM +0800, chenxiang (M) wrote: > Is it possible to use group id to identify different domains? No, the best is to do this during post-processing of your traces by also keeping tack of domain-device attachments/detachments. Regards, Joerg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-06 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210209123620.19993-1-saiprakash.ranjan@codeaurora.org>
2021-02-12 10:50 ` [PATCH] iommu: Add device name to iommu map/unmap trace events Joerg Roedel
2021-04-06 6:56 ` chenxiang (M)
2021-04-06 9:08 ` Joerg Roedel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).