From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A0CC433E0 for ; Fri, 12 Feb 2021 16:59:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AA6664E39 for ; Fri, 12 Feb 2021 16:59:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AA6664E39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nU1G5Mf6hljXbNT7UORFhDFE7YTgH1w4nICgiU0XMuw=; b=tbMQl0hG6lg2aIpI5oVwEUGbE 1x3/khTNyNqYrv0tIXT2B5qZ4fJ6l4EYE5twX4iTaBX/iBuyCFth2L+p4ASP9jHyqm9h3I7vkBwgB 0+BWYgxU4BuDOE5N7puksGFaB00/UdWX07Mw4IDxhtDgPy7G64jPjkRNWYmzmJSjAPAuzggCLQG1P c2yeDIgPjghnqihQ9EVT+lWgMBrl7MSYlKCPMsJZEqHEGqgj+CoAqkF1WXIHNgJReW3vJCcOVHpVd /vV1RfeV2sF+Ng9CJwYev4CG3TB+joTrue+gajsTJVtKBKuTM2fJ6oUnd6AfztV9OikWY116KxBDA xItXczMTw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAblG-0005Jk-Ly; Fri, 12 Feb 2021 16:57:42 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAblD-0005JM-2x for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 16:57:40 +0000 Received: by mail-pg1-x536.google.com with SMTP id t11so14154pgu.8 for ; Fri, 12 Feb 2021 08:57:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j0f03PK7GpTXsoMAjMSZo8qzT7Rprl+gDFpZEiQtFEY=; b=shPRqUeD7cEszA8IFpWRo86aOhjMemihjFV1otzV2J8JXPwqBklBTU4EhTzr/uWjHH z5vphRmF5sg9+UuWzMgmXxwSDexQ+0cjgwjdTkz6gXoqCqL0KwlBhAZzaQAqui51qaar WSFe7M5v1z86lVmliX6J+yKPlBNJWDYAhnjPkEphqOF3ZlAl+3jNkpSFzJoKCG43Hmgg xu+cq4a2715b3TD1gCuRHATgCQfVXeU+SNbGOqeKDxhqn34uoV5cLDbEzvcgDg7AL/qy PkA3nySA1vKvcZUwl8JU+kw+sJhyEsWrghAKJ1yoL4ZW5Xv73ZitZGWkfwBFYARWaHUI SheQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j0f03PK7GpTXsoMAjMSZo8qzT7Rprl+gDFpZEiQtFEY=; b=nXe/gMgZ6i+/VpXRoDa9X4u8ycWYkyJ2FctMHUAllGhSZGFhGUyFSn1+1YsInmRuhf AzwKTktDXZH8Fo5d/x97ILsVrWYgOhlXjUG0tRW0hkKpJhM6DhVHTwcPcAvHjWG5/tIU keT66WOM2YBa3y3zsLd53g6fmQlAGzOv98HVOueDPJJsWGgZzp+/QWW9wEvcZZAw+Sdp YmC5u0MF8QqJVy6Xuv3L4jWvsjg8U3hOp/k5/Befed5IRKGEenE0ApsMxLLiGsRo2Fsv oi1bJeFP7yIhWeal4Nd3Tomo4kMqBrF8geCvCfSnWvTtgyak0Qn3P6Gmy2WtjqyyLEOe BWqw== X-Gm-Message-State: AOAM530zLiKX7TNix8qrH5Fo45dKnKW2Hem3kOu5ogaiy5O8bJKzwAV+ jvCnokqVFhYDfWPqTdPj4YB56Q== X-Google-Smtp-Source: ABdhPJyBm7ZbXqIf4eDnemzio7E3X+HH5kYK6J09FnMZyfY2A+OYmlNKpY7Hox2pqCkFc1AA6Q4P9g== X-Received: by 2002:a05:6a00:2385:b029:1b6:1603:4ea3 with SMTP id f5-20020a056a002385b02901b616034ea3mr3662536pfc.40.1613149056388; Fri, 12 Feb 2021 08:57:36 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id h191sm4387760pge.85.2021.02.12.08.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 08:57:35 -0800 (PST) Date: Fri, 12 Feb 2021 09:57:34 -0700 From: Mathieu Poirier To: Anshuman Khandual Subject: Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver Message-ID: <20210212165734.GA2692426@xps15> References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-12-git-send-email-anshuman.khandual@arm.com> <20210211190024.GD2186000@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_115739_498314_74F2BF56 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lcherian@marvell.com, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [...] > > > > > >> + if (nr_pages < 2) > >> + return NULL; > >> + > >> + buf = kzalloc_node(sizeof(*buf), GFP_KERNEL, trbe_alloc_node(event)); > >> + if (IS_ERR(buf)) > >> + return ERR_PTR(-ENOMEM); > >> + > >> + pglist = kcalloc(nr_pages, sizeof(*pglist), GFP_KERNEL); > >> + if (IS_ERR(pglist)) { > >> + kfree(buf); > >> + return ERR_PTR(-ENOMEM); > >> + } > >> + > >> + for (i = 0; i < nr_pages; i++) > >> + pglist[i] = virt_to_page(pages[i]); > >> + > >> + buf->trbe_base = (unsigned long) vmap(pglist, nr_pages, VM_MAP, PAGE_KERNEL); > >> + if (IS_ERR((void *)buf->trbe_base)) { > > > > Why not simply make buf->trbe_base a void * instead of having to do all this > > There are many arithmetic and comparison operations involving trbe_base > element. Hence it might be better to keep it as unsigned long, also to > keeps it consistent with other pointers i.e trbe_write, trbe_limit. That is a fair point. Please add a comment to explain your design choice and make sure the sparse checker is happy with all of it. > > Snippet from $cat drivers/hwtracing/coresight/coresight-trbe.c | grep "trbe_base" > There are just two places type casting trbe_base back to (void *). > > memset((void *)buf->trbe_base + head, ETE_IGNORE_PACKET, len); > return buf->trbe_base + offset; > WARN_ON(buf->trbe_write < buf->trbe_base); > set_trbe_base_pointer(buf->trbe_base); > buf->trbe_base = (unsigned long)vmap(pglist, nr_pages, VM_MAP, PAGE_KERNEL); > if (IS_ERR((void *)buf->trbe_base)) { > return ERR_PTR(buf->trbe_base); > buf->trbe_limit = buf->trbe_base + nr_pages * PAGE_SIZE; > buf->trbe_write = buf->trbe_base; > vunmap((void *)buf->trbe_base); > base = get_trbe_base_pointer(); > buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); > if (buf->trbe_limit == buf->trbe_base) { > buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); > if (buf->trbe_limit == buf->trbe_base) { > offset = get_trbe_limit_pointer() - get_trbe_base_pointer(); > buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); > if (buf->trbe_limit == buf->trbe_base) { > WARN_ON(buf->trbe_base != get_trbe_base_pointer()); > if (get_trbe_write_pointer() == get_trbe_base_pointer()) > > > casting? And IS_ERR() doesn't work with vmap(). > > Sure, will drop IS_ERR() here. > [...] > > > >> + > >> +static ssize_t dbm_show(struct device *dev, struct device_attribute *attr, char *buf) > >> +{ > >> + struct trbe_cpudata *cpudata = dev_get_drvdata(dev); > >> + > >> + return sprintf(buf, "%d\n", cpudata->trbe_dbm); > >> +} > >> +static DEVICE_ATTR_RO(dbm); > > > > What does "dbm" stand for? Looking at the documentation for TRBIDR_EL1.F, I > > don't see what "dbm" relates to. > > I made it up to refer TRBIDR_EL1.F as "Dirty (and Access Flag) Bit Management". > Could change it as "afdbm" to be more specific or if it is preferred. > I don't see "afdbm" being a better solution - why not simply "flag"? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel