From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E683EC433E0 for ; Fri, 12 Feb 2021 18:47:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7EB764E99 for ; Fri, 12 Feb 2021 18:47:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7EB764E99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qiyD31Pcpt4N0ROt9klJ7D2OBdhWqIOWbA7QM3+hDFc=; b=ylPJOTss9DU5yg5pO+M4bf4Oh Pr7PE1Tdh2PCLBE8P2Ldq3Wk5fMWDj1cyzuy7AFCv9kfqrVZ5TCrJz/3TmBpMvaHknZ/Fzzbzi9T7 6UldoAlKB5zO0mctRJE2IAOmZ9S3i1xIMzRQF88xYlgsEQb2WlHJl8KQ4SzB3SrcpEy522jzExmJv 664wTR4u3I4lQM28TpPLCi5Tq26en9QagPB0ZqnQZs7GQoy4GcDDI0X5+vsjVPQwcWCkMYsG7IOPa o2DsU7KPNFqwuYOAYiHaLS/0pnWM6efbaRJNc0vUmWtcMeZGOnsKF/TZlkCkcX6qm/+S53OvK76BT W4W+p2G7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAdSO-0000SX-Ai; Fri, 12 Feb 2021 18:46:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAdSM-0000Ry-6S for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 18:46:18 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50D0764E8E; Fri, 12 Feb 2021 18:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613155577; bh=zP8CXtfdzYg8GZduBGIiauSpipKWLXxVJL/muVPE1oY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YMPmC+4a31rklT/0aspd1UMMidJsHkzvQWxJOZNO+9VeYpGk6TI0OWBUMlp/cqzo+ OodtCewrShT6A7CFaatlVG5WujuJ5ZCclK/VwG368gP4NT+njMIR0Xsr3IKShQcFwS Ze4kmcW7EN0YxhwFt88Q7a+kMTFn7KaY0sEo92+M+LB2fqwWoqxgZhin+cbZuZl1PG D/ZC7QeNtfFm67yE7DoEOEddORTT55YNEtD8XSqkv67RqctccRG6dyIGRxYBAP4f8G 9Ir/hWqtmbUATnekpsub1HtlM5zKYVrOl7/tguXwpS5oJmlqxX+xkuL2F3hfG9Az09 lc+MsFIpYEFMw== Date: Fri, 12 Feb 2021 18:46:11 +0000 From: Will Deacon To: Dave Martin Subject: Re: [PATCH v5 1/5] uapi: Move the aux vector AT_MINSIGSTKSZ define to uapi Message-ID: <20210212184610.GA31608@willie-the-truck> References: <20210203172242.29644-1-chang.seok.bae@intel.com> <20210203172242.29644-2-chang.seok.bae@intel.com> <20210204155519.GA21837@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210204155519.GA21837@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_134618_322401_6C8A8D22 X-CRM114-Status: GOOD ( 25.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, len.brown@intel.com, tony.luck@intel.com, libc-alpha@sourceware.org, ravi.v.shankar@intel.com, jannh@google.com, carlos@redhat.com, mpe@ellerman.id.au, "Chang S. Bae" , x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@intel.com, luto@kernel.org, linux-api@vger.kernel.org, hjl.tools@gmail.com, tglx@linutronix.de, bp@suse.de, mingo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 04, 2021 at 03:55:30PM +0000, Dave Martin wrote: > On Wed, Feb 03, 2021 at 09:22:38AM -0800, Chang S. Bae wrote: > > Move the AT_MINSIGSTKSZ definition to generic Linux from arm64. It is > > already used as generic ABI in glibc's generic elf.h, and this move will > > prevent future namespace conflicts. In particular, x86 will re-use this > > generic definition. > > > > Signed-off-by: Chang S. Bae > > Reviewed-by: Len Brown > > Cc: Carlos O'Donell > > Cc: Dave Martin > > Cc: libc-alpha@sourceware.org > > Cc: linux-arch@vger.kernel.org > > Cc: linux-api@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > --- > > Change from v4: > > * Added as a new patch (Carlos O'Donell) > > --- > > arch/arm64/include/uapi/asm/auxvec.h | 1 - > > include/uapi/linux/auxvec.h | 1 + > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/include/uapi/asm/auxvec.h b/arch/arm64/include/uapi/asm/auxvec.h > > index 743c0b84fd30..767d710c92aa 100644 > > --- a/arch/arm64/include/uapi/asm/auxvec.h > > +++ b/arch/arm64/include/uapi/asm/auxvec.h > > @@ -19,7 +19,6 @@ > > > > /* vDSO location */ > > #define AT_SYSINFO_EHDR 33 > > -#define AT_MINSIGSTKSZ 51 /* stack needed for signal delivery */ > > Since this is UAPI, I'm wondering whether we should try to preserve this > definition for users of . (Indeed, it is not uncommon to > include headers in userspace hackery, since the headers > tend to interact badly with the the libc headers.) > > In C11 at least, duplicate #defines are not an error if the definitions > are the same. I don't know about the history, but I suspect this was > true for older standards too. So maybe we can just keep this definition > with a duplicate definition in the common header. > > Otherwise, we could have > > #ifndef AT_MINSIGSTKSZ > #define AT_MINSIGSTKSZ 51 > #endif > > in include/linux/uapi/auxvec.h, and keep the arm64 header unchanged. I think it just boils down to whether or not anything breaks. If it does, then we'll have to revert the patch, so anything we can do now to minimise that possibility would be good. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel