Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

Hector Martin
2021-02-21T13:45:28Z

On 21/02/2021 04.11, Krzysztof Kozlowski wrote:
> On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote:
>> This should've gone in the next patch. A previous reviewer told me to put
>> declarations at the top of the file, so I put it there and moved this one
>> along with it, but I'll keep it to the additon only for v3.
>
> Maybe I missed something in the context but it looked like
> forward declaration s3c24xx_serial_tx_chars() was not needed? In such
> case no need to move it.

It's needed in patch #22 in this series; having it in this patch was a
mistake I made while splitting up the changes. I have moved that line to
the Apple support patch for v3.

--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub