Re: [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure

Hector Martin
2021-02-18T13:26:43Z

On 16/02/2021 03.06, Krzysztof Kozlowski wrote:
> On Mon, Feb 15, 2021 at 09:17:05PM +0900, Hector Martin wrote:
>> +static void s3c64xx_serial_shutdown(struct uart_port *port)
>> +{
>> + struct s3c24xx_uart_port *ourport = to_ourport(port);
>> +
>> + free_irq(port->irq, ourport);
>> +
>> + wr_regl(port, S3C64XX_UINTP, 0xf);
>> + wr_regl(port, S3C64XX_UINTM, 0xf);
>> +
>> + ourport->tx_enabled = 0;
>> + ourport->tx_mode = 0;
>> + ourport->rx_enabled = 0;
>
> For S3C64xx type this is not equivalent: the assignments were
> happening before free_irq() and wr_regl(). Honestly I don't know whether
> it matters (except some barriers coming from these functions) but please
> do not change the order of code in this patch. If needed, the
> re-ordering should be a patch on its own. With explanation why.

Honestly, I think if anything the masking should happen first (to make
sure no IRQs go off), but at this point it's probably better to play it
safe and not introduce any logic changes, so I've moved the assignments
first to retain the old behavior.

> Make the s3c24xx_serial_ops const as well.

Done for v3, thanks.

--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub