Re: [PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type

Hector Martin
2021-02-18T13:39:23Z

On 16/02/2021 03.26, Krzysztof Kozlowski wrote:
>> This removes s3c24xx_serial_has_interrupt_mask, which was just checking
>> for a specific type anyway, and adds the ucon_mask port info member to
>> avoid having S3C2440 as a distinct type.
>
> Please split setting the ucon_mask to separate patch. It's a nice
> code simplification on its own.

Done for v3.

>> /* Unmask Tx interrupt */
>> - if (s3c24xx_serial_has_interrupt_mask(port))
>> - s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD,
>> - S3C64XX_UINTM);
>> - else
>> + switch (ourport->info->type) {
>> + case TYPE_S3C6400:
>> + s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD, S3C64XX_UINTM);
>
> Please do not re-wrap. It makes reviewing more difficult. You can
> perform proper re-wrapping as a separate cleanup patch.

>> if (ourport->rx_enabled) {
>> dev_dbg(port->dev, "stopping rx\n");
>> - if (s3c24xx_serial_has_interrupt_mask(port))
>> - s3c24xx_set_bit(port, S3C64XX_UINTM_RXD,
>> - S3C64XX_UINTM);
>
> The same.

Reverted those two lines for v3.

--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub