Re: [PATCH v2 02/25] dt-bindings: arm: apple: Add bindings for Apple ARM platforms

Krzysztof Kozlowski
2021-02-15T17:49:12Z

On Mon, Feb 15, 2021 at 09:16:50PM +0900, Hector Martin wrote:
> This introduces bindings for all three 2020 Apple M1 devices:
>
> * apple,j274 - Mac mini (M1, 2020)
> * apple,j293 - MacBook Pro (13-inch, M1, 2020)
> * apple,j313 - MacBook Air (M1, 2020)
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> .../devicetree/bindings/arm/apple.yaml | 36 +++++++++++++++++++
> MAINTAINERS | 10 ++++++
> 2 files changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/apple.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> new file mode 100644
> index 000000000000..e44d308d6bde
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/apple.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple ARM Machine Device Tree Bindings
> +
> +maintainers:
> + - Hector Martin <marcan@marcan.st>
> +
> +description: |
> + Apple ARM ("Apple Silicon") platforms should contain compatible strings
> + in the following format:
> +
> + - apple,j274 (board/device ID)
> + - apple,m1 (SoC name)
> + - apple,arm-platform (Apple Silicon)

This description is irrelevant because the rules come from schema below.
Maybe instead write few words about the platform? Or describe how to get
the board/device ID if it is not obvious?

Best regards,
Krzysztof