From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74C9C433DB for ; Mon, 15 Feb 2021 18:41:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A541E60C40 for ; Mon, 15 Feb 2021 18:41:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A541E60C40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=whp9WFZ4teLHPU//Z+9zxtpNW7eGz82mIpFk8/b9PTo=; b=JXDdw0JEl7CdDRuj04eGiZNK4 9rnxL33zQtRgO5mbSwW0xV0P50qdBm9QK33J4B+yV6hhtkMf2UDiWyGDxxwRLxdxr+2ifA0XpM5BF H1TUMDbiPGukxLzHdowHarHobo7ZWqSz6OkiWlr+VS7jtJ+Rpe9dHLLkmEctbG8EA0X/wwyIoQTKn Scn2LdcLgqfnIm+MUiAiOrwfxpV3mYwi5kbH+7NXSwPTa3I9PK5GD45+8O8xNKgb6DcudUryXGVj4 dyNp4E7vQjtiJX4zXXLU/Wq0UM3PD8PWR+FLeXXrQFq9cufKIg7+XsIY7+Xj0FSKId03jAcG5W6Se E9HzH29dg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBinD-0004VB-6K; Mon, 15 Feb 2021 18:40:19 +0000 Received: from mail-wr1-f41.google.com ([209.85.221.41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBinA-0004UD-6W for linux-arm-kernel@lists.infradead.org; Mon, 15 Feb 2021 18:40:17 +0000 Received: by mail-wr1-f41.google.com with SMTP id 7so10214674wrz.0 for ; Mon, 15 Feb 2021 10:40:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ndRKNNc8/xGtpRkqHnsCIvQWf569YNGGMO1MNEH3zpI=; b=B09+bvjzJSAU35VWoMFyH3K3NeCYQYLQXxAyXmfYW9OtpP0TIePJAG9p20KNv9Sgvb 7Bqsg1bUEU0a3vaDTlr4QFt1bsPEGkOkAy+zNceM6A5xzzR8YH6lMushWwFMSChiS55e n9SOiV3F7JwficjKge+BCTRtCB8QRjdNN5c9QEX8MzSZqv6y+VhMly+7hho2SRtzQqIe pLOWBlBwanB4AP+e4NxeBVj3Rfx1v3k6E3zERDw+iGTdRIe8RCLp3zgKSDqB5snDfTgR bmSCZtphrCJJ/1ddjs0hUYqZQ7Z8ufAIyopTEM8Vvg5gfg8WNBHvBZYxs3OW+nJF+yPG 0f+A== X-Gm-Message-State: AOAM531DHDLXLm913raBA3Cape2HaEHn1RN8E+L34ERxrIRU4T8IiZgw uoHFXGj5+I86dy7wE8LxXG4= X-Google-Smtp-Source: ABdhPJyVcBQ0bLHE/Ww5ODhUu055JCyMWzRGPGh5VzxkxdbACBpfAYOFZTNu53lo6BDz8n0NbJD8Zg== X-Received: by 2002:adf:8084:: with SMTP id 4mr18715152wrl.49.1613414414946; Mon, 15 Feb 2021 10:40:14 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id s5sm191052wmh.45.2021.02.15.10.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 10:40:13 -0800 (PST) Date: Mon, 15 Feb 2021 19:40:12 +0100 From: Krzysztof Kozlowski To: Hector Martin Subject: Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework Message-ID: <20210215184012.sf6p6dbk5c25phdm@kozik-lap> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-20-marcan@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210215121713.57687-20-marcan@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210215_134016_293901_FC930117 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 15, 2021 at 09:17:07PM +0900, Hector Martin wrote: > * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq, > where only the latter acquires the port lock. I miss here information why you do all this. > > * For S3C64xx, return IRQ_NONE if no flag bits were set, so the > interrupt core can detect IRQ storms. Note that both IRQ handlers > always return IRQ_HANDLED anyway, so 'or' logic isn't necessary here, > if either handler ran we are always going to return IRQ_HANDLED. It looks like separate patch. Your patches should do only one thing at once. The fact that you have here three bullet points is a warning sign. This is even more important if you do some refactorings and cleanups which should not affect functionality. Hiding there changes which could affect functionality is a no-go. > > * Rename s3c24xx_serial_rx_chars to s3c24xx_serial_rx_irq for > consistency with the above. All it does now is call two other > functions anyway. Separate patch for trivial renaming. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 41 +++++++++++++++++++------------- > 1 file changed, 24 insertions(+), 17 deletions(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 21955be680a4..821cd0e4f870 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -151,6 +151,9 @@ struct s3c24xx_uart_port { > #endif > }; > > +static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport); > +static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport); > + > /* conversion functions */ > > #define s3c24xx_dev_to_port(__dev) dev_get_drvdata(__dev) > @@ -316,8 +319,6 @@ static void s3c24xx_serial_stop_tx(struct uart_port *port) > ourport->tx_mode = 0; > } > > -static void s3c24xx_serial_start_next_tx(struct s3c24xx_uart_port *ourport); > - Why moving this? Why adding s3c24xx_serial_tx_chars() forward declaration? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel