From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AE5C433E6 for ; Mon, 15 Feb 2021 18:53:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D57CB64E31 for ; Mon, 15 Feb 2021 18:53:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D57CB64E31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=74GH/GHtbKmADoq69u/oPRxEmHkc35OAvFx0dgfTyNI=; b=L7Mni43nIiKqj2TIUO0h7kmi/ LkkSsjm6dglMmrWGrWxlb1ibptQmebz3mHACsKkjHPDitXSZRU/qrQK2I5v0JHj0LfgxHiyQeg5FP 4sLca5ZaG4Bu5Fat3KCoR0k1/rh7oEzxdSVK2iOFSU4z0oJThIru9NKa1MUDpUUtgKolb6sbEGquK he7NIr/c8khXbGyegomMIPqINc176Ftx1vUjOnkxw2JbxslMrE32aUV+0+61u6LyLw9qxBexCUf+d 9NTDJqSDzCyTuKbtd5lPxdEVt9o3XKa10ITdZiO0zi6a+Q4Akw444Z+RW8QWNznalWoaXAqsMQB8r 3e9tD7tkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBiyE-0005Iw-B2; Mon, 15 Feb 2021 18:51:42 +0000 Received: from mail-wm1-f52.google.com ([209.85.128.52]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBiyC-0005IA-75 for linux-arm-kernel@lists.infradead.org; Mon, 15 Feb 2021 18:51:41 +0000 Received: by mail-wm1-f52.google.com with SMTP id m1so10270319wml.2 for ; Mon, 15 Feb 2021 10:51:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7VLbDmBh1F/YGMxpE9NHm5x49D+lAFFocqDiTimIiEw=; b=JZ7dXwesXumCqFueIgJH14Xm5lfhaThRTNjIZg45bBHquisud4RyZ9VfA9Vjhz8wvm zRIqBbZcx8gC5tLz8XvRfTetuiwHKsrlXyIThBPZa2CTmwjYaPM14ugmgG4zmpEPYca8 A13bjuxtO4cInsfjhZ3X5hri99A6hzvxSt/sQXbobfkS2QmEX7NDepgVs5P7OnonHeZ4 tuP4cMq8QP/JLV4yfMXlMWXMRyhwh26lyuEJxuXJhZzpdMEIMR8IcpygzQFhWCIPSosS Xq+PuwgkpOfsulj1avE8qAWfh7swjI0F8b7gwTkCT7CbtQQNxFushGUJlET96wP9xrNm O2zQ== X-Gm-Message-State: AOAM533AqvBOYGlaB9xZ9q0aL6tH5ZHVXOFiqfeLJOoAWtCKQrouyiiQ 00HGQk9zqOpf+hs5n/tMXr4= X-Google-Smtp-Source: ABdhPJzvSfb8WcTXHlyM9/N9punv4dhA6JbySGAa4T1NjeEp8641RYR8Z87lla8aUegaRoPw1jTtdg== X-Received: by 2002:a05:600c:28d3:: with SMTP id h19mr191379wmd.147.1613415098130; Mon, 15 Feb 2021 10:51:38 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t6sm15658631wrn.96.2021.02.15.10.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 10:51:36 -0800 (PST) Date: Mon, 15 Feb 2021 19:51:35 +0100 From: Krzysztof Kozlowski To: Hector Martin Subject: Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource Message-ID: <20210215185135.onivzktfscv5myh2@kozik-lap> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-21-marcan@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210215121713.57687-21-marcan@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210215_135140_305856_2836C32C X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 15, 2021 at 09:17:08PM +0900, Hector Martin wrote: > This picks up the non-posted I/O mode needed for Apple platforms to > work properly. > > This removes the request/release functions, which are no longer > necessary, since devm_ioremap_resource takes care of that already. Most > other drivers already do it this way, anyway. > > Also fix a bug checking the return value, which should use IS_ERR(). No, no, no. We never, never combine fixing bugs with some rework. However devm_ioremap() returns NULL so where is the error? Did you test your patches on existing platforms? If not, please mark all of them as RFT on next submission, so Greg does not pick them too fast. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel